mirror of
https://github.com/facebook/react-native.git
synced 2025-11-01 09:14:26 +00:00
Kudo ChienandFacebook GitHub Bot
2d46dbe6ce
Summary: https://github.com/facebook/react-native/commit/7af288e5 introduced a breaking change for whoever importing HermesExecutorFactory.h, because the `hermes/inspector-modern/chrome/HermesRuntimeTargetDelegate.h` is not a public header. Also the nested import is not ideal for CocoaPods or use_frameworks. I think HermesRuntimeTargetDelegate could be an implementation detail that hide from header. This PR tries to turn the ownership declaration from std::optional to std::unique_ptr, so that we could hide the concrete type. ## Changelog: [IOS] [FIXED] - Fixed `HermesExecutorFactory.h` build error when importing its private header Pull Request resolved: https://github.com/facebook/react-native/pull/44423 Test Plan: should introduce no breaking change and ci passed Reviewed By: cipolleschi Differential Revision: D57041498 Pulled By: huntie fbshipit-source-id: bfa10c7307458813d99c52313682dd62bea80f19