mirror of
https://github.com/facebook/react-native.git
synced 2025-11-01 09:14:26 +00:00
d1a33cd139
Summary: https://github.com/facebook/react-native/issues/29099 introduced a regression where non-rounded borders on Android would render partly outside of the bounds of the view as I reported in https://github.com/facebook/react-native/issues/32393. This PR addresses that by rendering the borders completely inside the view like it works on iOS, previous version of RN and for rounded corners. ## Changelog <!-- Help reviewers and the release process by writing your own changelog entry. For an example, see: https://github.com/facebook/react-native/wiki/Changelog --> [Android] [Fixed] - Fix Android border positioning regression Pull Request resolved: https://github.com/facebook/react-native/pull/32398 Test Plan: Rendering the following code (as reported in the issue) in the RN Tester app: ```jsx <View style={{ aspectRatio: 1, backgroundColor: 'green', borderWidth: 8, borderColor: 'black', borderStyle: 'dashed', }} /> ``` |Before|After| |--|--| ||| Reviewed By: yungsters Differential Revision: D31623647 Pulled By: lunaleaps fbshipit-source-id: c38d172ae4a9dc48f800c63258223a59e2f621ed
Building React Native for Android
See the docs on the wiki.
Running tests
When you submit a pull request CircleCI will automatically run all tests. To run tests locally, see Testing.