mirror of
https://github.com/facebook/react-native.git
synced 2025-11-01 09:14:26 +00:00
48cb80892d
Summary:
Generating this diff was difficult. We _will_ fix the issues with jscodeshift, but i don't want to block the syntax change on that.
To get this diff, I first codemodded all of xplat to use exact-by-default. Then i turned on implicit-inexact-object:error enforcement to get a list of errors showing places that violated the lint. With that, I used this to generate a list of `sed` commands to add `...`:
```
flow --json | jq '.errors | .[] | .message | .[] | .loc | {source, "line": .end."line", "column": .end."column"} | "\(.column),\(.line),\(.source)"' | sort -n -r | sed 's/"//g' | while read -r line; do echo $line; awk -F',' "{ print \"sed -i '\"\$2\"s/./...&/\"\$1\"' \" \$3 }"; done
```
Then I ran prettier, reverted generated files, and manually fixed up suppressions that got messed up.
Changelog: [Internal]
Reviewed By: gkz
Differential Revision: D18516431
fbshipit-source-id: 6cf940dce411fb179e7ebaff764bd5113a07989f
137 lines
3.0 KiB
JavaScript
137 lines
3.0 KiB
JavaScript
/**
|
|
* Copyright (c) Facebook, Inc. and its affiliates.
|
|
*
|
|
* This source code is licensed under the MIT license found in the
|
|
* LICENSE file in the root directory of this source tree.
|
|
*
|
|
* @flow
|
|
* @format
|
|
*/
|
|
|
|
'use strict';
|
|
|
|
const React = require('react');
|
|
const SectionList = require('../SectionList');
|
|
|
|
function renderMyListItem(info: {
|
|
item: {title: string, ...},
|
|
index: number,
|
|
...
|
|
}) {
|
|
return <span />;
|
|
}
|
|
|
|
const renderMyHeader = ({
|
|
section,
|
|
}: {
|
|
section: {fooNumber: number, ...} & Object,
|
|
...
|
|
}) => <span />;
|
|
|
|
module.exports = {
|
|
testGoodDataWithGoodItem(): React.Node {
|
|
const sections = [
|
|
{
|
|
key: 'a',
|
|
data: [
|
|
{
|
|
title: 'foo',
|
|
key: 1,
|
|
},
|
|
],
|
|
},
|
|
];
|
|
return <SectionList renderItem={renderMyListItem} sections={sections} />;
|
|
},
|
|
|
|
testBadRenderItemFunction(): $TEMPORARY$array<React.Node> {
|
|
const sections = [
|
|
{
|
|
key: 'a',
|
|
data: [
|
|
{
|
|
title: 'foo',
|
|
key: 1,
|
|
},
|
|
],
|
|
},
|
|
];
|
|
return [
|
|
// $FlowExpectedError - title should be inside `item`
|
|
<SectionList
|
|
renderItem={(info: {title: string, ...}) => <span />}
|
|
sections={sections}
|
|
/>,
|
|
<SectionList
|
|
// $FlowExpectedError - bad index type string, should be number
|
|
renderItem={(info: {index: string}) => <span />}
|
|
sections={sections}
|
|
/>,
|
|
// EverythingIsFine
|
|
<SectionList
|
|
renderItem={(info: {item: {title: string, ...}, ...}) => <span />}
|
|
sections={sections}
|
|
/>,
|
|
];
|
|
},
|
|
|
|
testBadInheritedDefaultProp(): React.Element<*> {
|
|
const sections = [];
|
|
return (
|
|
<SectionList
|
|
renderItem={renderMyListItem}
|
|
sections={sections}
|
|
// $FlowExpectedError - bad windowSize type "big"
|
|
windowSize="big"
|
|
/>
|
|
);
|
|
},
|
|
|
|
testMissingData(): React.Element<*> {
|
|
// $FlowExpectedError - missing `sections` prop
|
|
return <SectionList renderItem={renderMyListItem} />;
|
|
},
|
|
|
|
testBadSectionsShape(): React.Element<*> {
|
|
const sections = [
|
|
/* $FlowFixMe(>=0.63.0 site=react_native_fb) This comment suppresses an
|
|
* error found when Flow v0.63 was deployed. To see the error delete this
|
|
* comment and run Flow. */
|
|
{
|
|
key: 'a',
|
|
items: [
|
|
{
|
|
title: 'foo',
|
|
key: 1,
|
|
},
|
|
],
|
|
},
|
|
];
|
|
// $FlowExpectedError - section missing `data` field
|
|
return <SectionList renderItem={renderMyListItem} sections={sections} />;
|
|
},
|
|
|
|
testBadSectionsMetadata(): React.Element<*> {
|
|
const sections = [
|
|
{
|
|
key: 'a',
|
|
// $FlowExpectedError - section has bad meta data `fooNumber` field of type string
|
|
fooNumber: 'string',
|
|
data: [
|
|
{
|
|
title: 'foo',
|
|
key: 1,
|
|
},
|
|
],
|
|
},
|
|
];
|
|
return (
|
|
<SectionList
|
|
renderSectionHeader={renderMyHeader}
|
|
renderItem={renderMyListItem}
|
|
sections={sections}
|
|
/>
|
|
);
|
|
},
|
|
};
|