mirror of
https://github.com/facebook/react-native.git
synced 2025-11-01 09:14:26 +00:00
Christopher Chedeau
bd36e40258
Summary: https://github.com/facebook/css-layout/commit/8f6a96adbcb2b0389f948b8113d8b7cb8991bb2d added a test in isDimDefined that checks if `value > 0.0`, but unfortunately, it did not faithfully port the JavaScript version which is `value >= 0.0`: https://github.com/facebook/css-layout/blob/master/src/Layout.js#L306. Sadly, no test covered this so it went unnoticed. Closes https://github.com/facebook/css-layout/pull/134 Reviewed By: @svcscm Differential Revision: D2481773 Pulled By: @vjeux
The source of truth for css-layout is: https://github.com/facebook/css-layout The code here should be kept in sync with GitHub. HEAD at the time this code was synced: https://github.com/facebook/css-layout/commit/f51c2d004de7744f9cefb98aa2a9c1c22168d49c There is generated code in: - README (this file) - java/com/facebook/csslayout (this folder) - javatests/com/facebook/csslayout The code was generated by running 'make' in the css-layout folder and copied to React Native.