mirror of
https://github.com/facebook/react-native.git
synced 2025-11-01 09:14:26 +00:00
243070afe2
Summary: Now RN has only ReactActivity which extends AppCompatActivity, subclass of FragmentActivity, therefore no need to check if activity is FragmentActivity or not. This PR changes DialogModule to work only with FragmentActivity. Also DialogFragment from Android is deprecated in API 28, and recommends to use DialogFragment from Support Library. Excerpt from DialogFragment documentation. > **This class was deprecated in API level 28.** > Use the Support Library DialogFragment for consistent behavior across all devices and access to Lifecycle. **BREAKING CHANGE**: Brown field apps must extend FragmentActivity or its subclasses. [Android] [Changed] - DialogModule supports only FragmentActivity Pull Request resolved: https://github.com/facebook/react-native/pull/23365 Differential Revision: D14021986 Pulled By: cpojer fbshipit-source-id: b0ede60ef19cec48111a12701659a8bc1f66c331
Building React Native for Android
See the docs on the website.
Running tests
When you submit a pull request CircleCI will automatically run all tests. To run tests locally, see Testing.