mirror of
https://github.com/facebook/react-native.git
synced 2025-11-01 09:14:26 +00:00
gabrieldonadelandFacebook GitHub Bot
28e1ca9873
Summary:
This PR proposes the removal of the ability to use remote JS debugging (a.k.a Chrome Debugging) from the DevMenu.
This change has been suggested previously on the contributor's Discord server and it is motivated by the fact that generally speaking, this feature does not work with the new architecture and most of the popular modules these days. The remote JS debugging is basically broken if you use Turbo Modules, Fabric, or sync native module calls.
People tend to assume that if something is part of the dev tools UI, it is going to work reliably. However, when it comes to remote debugging using JSC that's increasingly unlikely to be the case. Having it continue to exist as an option has created some confusion, or at least that's what we've seen within the Expo community.
### How to manually enable remote debugging
If your project depends on remote debugging, you can still enable it manually through the `NativeDevSettings`. E.g.
```jsx
import NativeDevSettings from 'react-native/Libraries/NativeModules/specs/NativeDevSettings';
export default function App() {
return (
<Button
title="Enable remote debugging"
onPress={() => NativeDevSettings.setIsDebuggingRemotely(!true)}
/>
);
}
```
### Next steps
Once this has been released and we are sure that this doesn't cause a lot of problems for people we can remove the ability entirely in a follow-up PR
## Changelog:
[General] [Removed] - Remove remote debugging from the dev menu
Pull Request resolved: https://github.com/facebook/react-native/pull/36754
Test Plan:
Locally run rn-tester using JSC on Android and iOS and open the dev menu
<table>
<tr><th>iOS</th><th>Android</th></tr>
<tr>
<td>
<img src="https://user-images.githubusercontent.com/11707729/229229079-03f98eed-0765-4cc8-b972-0c4ff041b611.png" />
</td>
<td>
<img src="https://user-images.githubusercontent.com/11707729/229229103-b57e8fd2-9aca-4780-8a8f-0fd5b2e53590.png" />
</td>
</tr>
</table>
Reviewed By: christophpurrer
Differential Revision: D45278061
Pulled By: huntie
fbshipit-source-id: 842c33102cd34730c14acece8e318cb263e5c9e5
