react-native

mirror of https://github.com/facebook/react-native.git synced 2025-11-01 09:14:26 +00:00

Files

T

Nicola Corti 7fb0bb40d2 Simplify the Android.mk file in the App Template (#34080 )

Summary:
I'm simplifying the `Android.mk` file inside the template as it was confusing. There are two ways to include the generated code from the codegen:
1. Importing the generated Android.mk file
2. Include the generate source files in the `_appmodules` source files.

Those two approaches are mutually exclusive (as doing both will lead to duplicate symbols). Our template comments were confusing and were suggesting a combination of both.

I'm simplifying the comments here by removing the one suggesting to go with option `1` instead.

## Changelog

[Android][Changed] - Simplify the Android.mk file in the App Template

Pull Request resolved: https://github.com/facebook/react-native/pull/34080

Test Plan: Nothing to test here as it's a comments only change

Reviewed By: cipolleschi

Differential Revision: D37463222

Pulled By: cortinico

fbshipit-source-id: 30ecc6fbbbcaf484272b4c724600cda588146506

2022-06-28 04:35:11 -07:00

src

Simplify the Android.mk file in the App Template (#34080 )

2022-06-28 04:35:11 -07:00

_BUCK

Move react-native template

2018-12-07 07:49:19 -08:00

build_defs.bzl

Move react-native template

2018-12-07 07:49:19 -08:00

build.gradle

Make Hermes the default engine on Android. (#34049 )