mirror of
https://github.com/facebook/react-native.git
synced 2025-11-01 09:14:26 +00:00
Chiara Mooney
42b391775f
Summary: Changes to MapBuffer code in https://github.com/facebook/react-native/compare/aaff15c...d287598 broke build for Windows. Errors included incompatible type conversions, the use of `__attribute__(__packed__)` which is only supported by GCC and Clang, and the usage of designated initializers which are only supported on C++20. Changes here restore build on Windows. ## Changelog <!-- Help reviewers and the release process by writing your own changelog entry. For an example, see: https://github.com/facebook/react-native/wiki/Changelog --> [General] [Fixed] - Fix build break on Windows with ReactCommon Pull Request resolved: https://github.com/facebook/react-native/pull/33047 Test Plan: React Native project built on Windows and passes react-native-windows repository pipeline. These edits are currently merged into the main branch of react-native-windows. Reviewed By: ShikaSD Differential Revision: D34101367 Pulled By: philIip fbshipit-source-id: 1596365c2e92f377c6375805b33de5e1c7b78e66
60 lines
1.3 KiB
C++
60 lines
1.3 KiB
C++
/*
|
|
* Copyright (c) Meta Platforms, Inc. and affiliates.
|
|
*
|
|
* This source code is licensed under the MIT license found in the
|
|
* LICENSE file in the root directory of this source tree.
|
|
*/
|
|
|
|
#pragma once
|
|
|
|
#include <react/debug/react_native_assert.h>
|
|
#include <react/renderer/mapbuffer/MapBuffer.h>
|
|
|
|
namespace facebook {
|
|
namespace react {
|
|
|
|
// Default reserved size for buckets_ vector
|
|
constexpr uint32_t INITIAL_BUCKETS_SIZE = 10;
|
|
|
|
/**
|
|
* MapBufferBuilder is a builder class for MapBuffer
|
|
*/
|
|
class MapBufferBuilder {
|
|
public:
|
|
MapBufferBuilder(uint32_t initialSize = INITIAL_BUCKETS_SIZE);
|
|
|
|
static MapBuffer EMPTY();
|
|
|
|
void putInt(MapBuffer::Key key, int32_t value);
|
|
|
|
void putBool(MapBuffer::Key key, bool value);
|
|
|
|
void putDouble(MapBuffer::Key key, double value);
|
|
|
|
void putString(MapBuffer::Key key, std::string const &value);
|
|
|
|
void putMapBuffer(MapBuffer::Key key, MapBuffer const &map);
|
|
|
|
MapBuffer build();
|
|
|
|
private:
|
|
MapBuffer::Header header_;
|
|
|
|
std::vector<MapBuffer::Bucket> buckets_{};
|
|
|
|
std::vector<uint8_t> dynamicData_{};
|
|
|
|
uint16_t lastKey_{0};
|
|
|
|
bool needsSort_{false};
|
|
|
|
void storeKeyValue(
|
|
MapBuffer::Key key,
|
|
MapBuffer::DataType type,
|
|
uint8_t const *value,
|
|
uint32_t valueSize);
|
|
};
|
|
|
|
} // namespace react
|
|
} // namespace facebook
|