mirror of
https://github.com/facebook/react-native.git
synced 2025-11-01 09:14:26 +00:00
Samuel Susla
283512cc42
Summary: Changelog: [internal] Yoga offsets content view of scrollview in RTL environment. React Native Classis deals with it by using a separate component [ScrollContentView](https://github.com/facebook/react-native/blob/6e6443afd04a847ef23fb6254a84e48c70b45896/React/Views/ScrollView/RCTScrollContentShadowView.m#L18-L25 ) and making the adjustment there. In New React Native Renderer, it can be handled inside `ScrollViewShadowNode`. Reviewed By: JoshuaGross Differential Revision: D26817121 fbshipit-source-id: ad48374ef19b802d25e919ac0aae05c5890762f2
69 lines
2.0 KiB
C++
69 lines
2.0 KiB
C++
/*
|
|
* Copyright (c) Facebook, Inc. and its affiliates.
|
|
*
|
|
* This source code is licensed under the MIT license found in the
|
|
* LICENSE file in the root directory of this source tree.
|
|
*/
|
|
|
|
#include "ScrollViewShadowNode.h"
|
|
|
|
#include <react/debug/react_native_assert.h>
|
|
#include <react/renderer/core/LayoutMetrics.h>
|
|
|
|
namespace facebook {
|
|
namespace react {
|
|
|
|
const char ScrollViewComponentName[] = "ScrollView";
|
|
|
|
void ScrollViewShadowNode::updateStateIfNeeded() {
|
|
ensureUnsealed();
|
|
|
|
auto contentBoundingRect = Rect{};
|
|
for (const auto &childNode : getLayoutableChildNodes()) {
|
|
contentBoundingRect.unionInPlace(childNode->getLayoutMetrics().frame);
|
|
}
|
|
|
|
auto state = getStateData();
|
|
|
|
if (state.contentBoundingRect != contentBoundingRect) {
|
|
state.contentBoundingRect = contentBoundingRect;
|
|
setStateData(std::move(state));
|
|
}
|
|
}
|
|
|
|
void ScrollViewShadowNode::updateScrollContentOffsetIfNeeded() {
|
|
#ifndef ANDROID
|
|
react_native_assert(
|
|
children_->size() == 1 && "ScrollView only has single child");
|
|
if (getLayoutMetrics().layoutDirection == LayoutDirection::RightToLeft) {
|
|
// Yoga place `contentView` on the right side of `scrollView` when RTL
|
|
// layout is enforced. To correct for this, in RTL setting, correct the
|
|
// frame's origin. React Native Classic does this as well in
|
|
// `RCTScrollContentShadowView.m`.
|
|
for (auto layoutableNode : getLayoutableChildNodes()) {
|
|
auto layoutMetrics = layoutableNode->getLayoutMetrics();
|
|
if (layoutMetrics.frame.origin.x != 0) {
|
|
layoutMetrics.frame.origin.x = 0;
|
|
layoutableNode->setLayoutMetrics(layoutMetrics);
|
|
}
|
|
}
|
|
}
|
|
#endif
|
|
}
|
|
|
|
#pragma mark - LayoutableShadowNode
|
|
|
|
void ScrollViewShadowNode::layout(LayoutContext layoutContext) {
|
|
ConcreteViewShadowNode::layout(layoutContext);
|
|
updateScrollContentOffsetIfNeeded();
|
|
updateStateIfNeeded();
|
|
}
|
|
|
|
Point ScrollViewShadowNode::getContentOriginOffset() const {
|
|
auto contentOffset = getStateData().contentOffset;
|
|
return {-contentOffset.x, -contentOffset.y};
|
|
}
|
|
|
|
} // namespace react
|
|
} // namespace facebook
|