mirror of
https://github.com/facebook/react-native.git
synced 2025-11-01 09:14:26 +00:00
Alex Hunt
24f7bd7445
Summary: Pull Request resolved: https://github.com/facebook/react-native/pull/42941 I noticed that programatically running `npm set registry <value>` would fail within the repo root dir (intended run location) (`node` version `18.18.2`). ``` npm ERR! This command does not support workspaces. ``` It turns out this is no longer supported from npm 9.x: https://github.com/npm/cli/issues/6099. **Note**: The workaround discussed in this thread is incompatible/nontrivial with `npx`, so I've opted to remove this behaviour. **Changes** - Remove `npm set registry http://localhost:4873` call. - This is non-breaking due to the [explicit `--registry` arg already present in `run-e2e-ci-tests.js`](https://github.com/facebook/react-native/blob/b366b4b42e0f91eb2b1850c404fadd0f0322fc61/scripts/run-ci-e2e-tests.js#L102). The previous `.npmrc` config value is unnecessary, and probably was being ignored (will be validated for this PR in CircleCI run). - Add comment against remaining `.npmrc` write, convert to `fs` call. - Remove unused params on `setupVerdaccio` (moved to constants which will be exported and referenced in the next diff). Changelog: [Internal] Reviewed By: cipolleschi Differential Revision: D53609308 fbshipit-source-id: 77d3666b42963cd61f6d3fd0be00cdc19bbb1ec8