react-native

mirror of https://github.com/facebook/react-native.git synced 2025-11-01 09:14:26 +00:00

Files

T

Lorenzo Sciandra e509007f57 fix(internal, dangerfile): fix changelog entries for dangerfiles and PR template (#35541 )

Summary:
A few days back leotm pointed out how the dangerfile was disaligned with the docs around the valid changelog entries for categories and types here: https://github.com/facebook/react-native/pull/35443#issuecomment-1327449113

I dug a bit deeper into the whole thing and went to the source of truth, which is the changelog generator, in particular here: https://github.com/microsoft/rnx-kit/blob/main/incubator/rn-changelog-generator/src/utils/getChangeDimensions.ts

So I've updated the dangerfile to respect the options listed there. Also did a parallel PR on the website side: https://github.com/facebook/react-native-website/pull/3447

So now all comms will be aligned.

## Changelog

<!-- Help reviewers and the release process by writing your own changelog entry. For an example, see:
https://reactnative.dev/contributing/changelogs-in-pull-requests
-->

[INTERNAL] [FIXED] - fix changelog entries for dangerfiles and PR template

Pull Request resolved: https://github.com/facebook/react-native/pull/35541

Test Plan: N/A

Reviewed By: sammy-SC

Differential Revision: D41686913

Pulled By: cortinico

fbshipit-source-id: 2297b4a3209188bda4a609b60860de35c5e7e6df

2022-12-05 02:38:42 -08:00

.babelrc

Add bots as a yarn workspace and update danger action (#34652 )

2022-09-12 22:03:34 -07:00

code-analysis-bot.js

Add bots as a yarn workspace and update danger action (#34652 )

2022-09-12 22:03:34 -07:00

dangerfile.js

fix(internal, dangerfile): fix changelog entries for dangerfiles and PR template (#35541 )

2022-12-05 02:38:42 -08:00

datastore.js

Add bots as a yarn workspace and update danger action (#34652 )

2022-09-12 22:03:34 -07:00

make-comment.js

Add bots as a yarn workspace and update danger action (#34652 )

2022-09-12 22:03:34 -07:00

package.json

chore(deps): add wanted dependencies to remove yarn warnings (#35122 )

2022-10-28 13:01:48 -07:00

post-artifacts-link.js

Add bots as a yarn workspace and update danger action (#34652 )

2022-09-12 22:03:34 -07:00

README.md

Add bots as a yarn workspace and update danger action (#34652 )

2022-09-12 22:03:34 -07:00

report-bundle-size.js

Add bots as a yarn workspace and update danger action (#34652 )

2022-09-12 22:03:34 -07:00

README.md

Danger

Danger is a JavaScript runtime which helps you provide continuous feedback inside GitHub. It's used inside Github Actions to analyze the contents of a GitHub pull request.

If you want to test changes to Danger, I'd recommend checking out an existing PR and then running the danger pr command. You'll need a GitHub Public Access Token (PAT). It will look like ghp_<REDACTED>.

So, for example:

DANGER_GITHUB_API_TOKEN=ghp_<REDACTED> yarn danger pr https://github.com/facebook/react-native/pull/1234

Code Analysis Bot

The code analysis bot provides lint and other results as inline reviews on GitHub. It runs as part of the Circle CI analysis workflow.

If you want to test changes to the Code Analysis Bot, I'd recommend checking out an existing PR and then running the analyze pr command. You'll need a GitHub token. You can re-use this one: 312d354b5c36f082cfe9 07973d757026bdd9f196 (just remove the space). So, for example:

GITHUB_TOKEN=[ENV_ABOVE] GITHUB_PR_NUMBER=1234 yarn lint-ci