mirror of
https://github.com/facebook/react-native.git
synced 2025-11-01 09:14:26 +00:00
Ramanpreet Nara
03bd7d799e
Summary:
## Summary
Please check out D21035209.
## Changes
- Codemod all ObjC NativeModule `getTurboModuleWithJsInvoker:nativeInvoker:perfLogger` methods to `getTurboModule:(const ObjCTurboModule::Args)`
## Script
```
var withSpaces = (...args) => args.join('\s*')
var regexString = withSpaces(
'-',
'\(',
'std::shared_ptr',
'<',
'(?<turboModuleClass>(facebook::react::|react::|::|)TurboModule)',
'>',
'\)',
'getTurboModuleWithJsInvoker',
':',
'\(',
'std::shared_ptr',
'<',
'(?<fbNamespace>(facebook::react::|react::|::|))CallInvoker',
'>',
'\)',
'(?<jsInvokerInstance>[A-Za-z0-9]+)',
'nativeInvoker',
':',
'\(',
'std::shared_ptr',
'<',
'(facebook::react::|react::|::|)CallInvoker',
'>',
'\)',
'(?<nativeInvokerInstance>[A-Za-z0-9]+)',
'perfLogger',
':',
'\(',
'id',
'<',
'RCTTurboModulePerformanceLogger',
'>',
'\)',
'(?<perfLoggerInstance>[A-Za-z0-9]+)',
'{',
'return',
'std::make_shared',
'<',
'(?<specName>(facebook::react::|react::|::|)Native[%A-Za-z0-9]+SpecJSI)',
'>',
'\(',
'self',
',',
'\k<jsInvokerInstance>',
',',
'\k<nativeInvokerInstance>',
',',
'\k<perfLoggerInstance>',
'\)',
';',
'}',
)
var replaceString = `- (std::shared_ptr<$<turboModuleClass>>) getTurboModule:(const $<fbNamespace>ObjCTurboModule::InitParams &)params
{
return std::make_shared<$<specName>>(params);
}`
const exec = require('../lib/exec');
const abspath = require('../lib/abspath');
const relpath = require('../lib/relpath');
const readFile = (filename) => require('fs').readFileSync(filename, 'utf8');
const writeFile = (filename, content) => require('fs').writeFileSync(filename, content);
function main() {
const tmFiles = exec('cd ~/fbsource && xbgs -n 10000 -l getTurboModuleWithJsInvoker:').split('\n').filter(Boolean);
tmFiles
.filter((filename) => !filename.includes('microsoft-fork-of-react-native'))
.map(abspath)
.forEach((filename) => {
const source = readFile(filename);
const newSource = source.replace(new RegExp(regexString, 'g'), replaceString);
if (source == newSource) {
console.log(relpath(filename));
}
writeFile(filename, newSource);
});
}
if (!module.parent) {
main();
}
```
## Re-generating diff
```
> hg revert -r .^ --all
> node index.js # run script
```
Changelog: [iOS][Changed] - Make all ObjC NativeModules create TurboModules using ObjCTurboModule::Args
Reviewed By: PeteTheHeat
Differential Revision: D21036265
fbshipit-source-id: 404bcc548d1775ef23d793527606d02fe384a0a2
126 lines
3.1 KiB
Plaintext
126 lines
3.1 KiB
Plaintext
/*
|
|
* Copyright (c) Facebook, Inc. and its affiliates.
|
|
*
|
|
* This source code is licensed under the MIT license found in the
|
|
* LICENSE file in the root directory of this source tree.
|
|
*/
|
|
|
|
#import <React/RCTSettingsManager.h>
|
|
|
|
#import <FBReactNativeSpec/FBReactNativeSpec.h>
|
|
#import <React/RCTBridge.h>
|
|
#import <React/RCTConvert.h>
|
|
#import <React/RCTEventDispatcher.h>
|
|
#import <React/RCTUtils.h>
|
|
|
|
#import "RCTSettingsPlugins.h"
|
|
|
|
@interface RCTSettingsManager() <NativeSettingsManagerSpec>
|
|
@end
|
|
|
|
@implementation RCTSettingsManager
|
|
{
|
|
BOOL _ignoringUpdates;
|
|
NSUserDefaults *_defaults;
|
|
}
|
|
|
|
@synthesize bridge = _bridge;
|
|
|
|
RCT_EXPORT_MODULE()
|
|
|
|
+ (BOOL)requiresMainQueueSetup
|
|
{
|
|
return NO;
|
|
}
|
|
|
|
- (instancetype)init
|
|
{
|
|
return [self initWithUserDefaults:[NSUserDefaults standardUserDefaults]];
|
|
}
|
|
|
|
- (instancetype)initWithUserDefaults:(NSUserDefaults *)defaults
|
|
{
|
|
if ((self = [super init])) {
|
|
_defaults = defaults;
|
|
|
|
|
|
[[NSNotificationCenter defaultCenter] addObserver:self
|
|
selector:@selector(userDefaultsDidChange:)
|
|
name:NSUserDefaultsDidChangeNotification
|
|
object:_defaults];
|
|
}
|
|
return self;
|
|
}
|
|
|
|
- (facebook::react::ModuleConstants<JS::NativeSettingsManager::Constants>)constantsToExport
|
|
{
|
|
return (facebook::react::ModuleConstants<JS::NativeSettingsManager::Constants>)[self getConstants];
|
|
}
|
|
|
|
- (facebook::react::ModuleConstants<JS::NativeSettingsManager::Constants>)getConstants
|
|
{
|
|
return facebook::react::typedConstants<JS::NativeSettingsManager::Constants>({
|
|
.settings = RCTJSONClean([_defaults dictionaryRepresentation])
|
|
});
|
|
}
|
|
|
|
- (void)userDefaultsDidChange:(NSNotification *)note
|
|
{
|
|
if (_ignoringUpdates) {
|
|
return;
|
|
}
|
|
|
|
#pragma clang diagnostic push
|
|
#pragma clang diagnostic ignored "-Wdeprecated-declarations"
|
|
[_bridge.eventDispatcher
|
|
sendDeviceEventWithName:@"settingsUpdated"
|
|
body:RCTJSONClean([_defaults dictionaryRepresentation])];
|
|
#pragma clang diagnostic pop
|
|
}
|
|
|
|
/**
|
|
* Set one or more values in the settings.
|
|
* TODO: would it be useful to have a callback for when this has completed?
|
|
*/
|
|
RCT_EXPORT_METHOD(setValues:(NSDictionary *)values)
|
|
{
|
|
_ignoringUpdates = YES;
|
|
[values enumerateKeysAndObjectsUsingBlock:^(NSString *key, id json, BOOL *stop) {
|
|
id plist = [RCTConvert NSPropertyList:json];
|
|
if (plist) {
|
|
[self->_defaults setObject:plist forKey:key];
|
|
} else {
|
|
[self->_defaults removeObjectForKey:key];
|
|
}
|
|
}];
|
|
|
|
[_defaults synchronize];
|
|
_ignoringUpdates = NO;
|
|
}
|
|
|
|
/**
|
|
* Remove some values from the settings.
|
|
*/
|
|
RCT_EXPORT_METHOD(deleteValues:(NSArray<NSString *> *)keys)
|
|
{
|
|
_ignoringUpdates = YES;
|
|
for (NSString *key in keys) {
|
|
[_defaults removeObjectForKey:key];
|
|
}
|
|
|
|
[_defaults synchronize];
|
|
_ignoringUpdates = NO;
|
|
}
|
|
|
|
- (std::shared_ptr<facebook::react::TurboModule>)getTurboModule:(const facebook::react::ObjCTurboModule::InitParams &)params
|
|
{
|
|
return std::make_shared<facebook::react::NativeSettingsManagerSpecJSI>(params);
|
|
}
|
|
|
|
@end
|
|
|
|
Class RCTSettingsManagerCls(void)
|
|
{
|
|
return RCTSettingsManager.class;
|
|
}
|