mirror of
https://github.com/facebook/react-native.git
synced 2025-11-01 09:14:26 +00:00
Ramanpreet Nara
f89ed90a1e
Summary: The onChange event for slider isn't necessary. Instead, it uses onValueChanged. ## What motivated this change? After D33933403, the SliderNativeComponent starts generating an onChange: true entry in its static ViewConfig's validAttributes map. **The Problem:** Slider inherits the onChange event from RCTViewManager. And in RCTViewManager, onChange is defined as an event that doesn't generate a ViewConfig validAttribute: 1. onChange is exported from [RCTViewManager customBubblingEventTypes](https://www.internalfb.com/code/fbsource/[210a214c9da7a847dd8840cae9f8341ed39a2ff6]/xplat/js/react-native-github/React/Views/RCTViewManager.m?lines=99%2C105%2C118) 2. Events exported from customBubblingEventTypes [don't insert into validAttributes](https://www.internalfb.com/code/fbsource/[8237815744b8cf7e38d9cf107a55c015f7b1545b]/xplat/js/react-native-github/React/Views/RCTComponentData.m?lines=393-398). To summarize: - onChange isn't used by slider - onChange generates an onChange: true entry in SVCs - onChange **doesn't** generate an onChange: true entry in NVC Changelog: [Internal] Reviewed By: mdvacca Differential Revision: D34052662 fbshipit-source-id: 76bfd75c1ecbaa40d33e2b097b1f4458bf200ac2
58 lines
1.5 KiB
JavaScript
58 lines
1.5 KiB
JavaScript
/**
|
|
* Copyright (c) Meta Platforms, Inc. and affiliates.
|
|
*
|
|
* This source code is licensed under the MIT license found in the
|
|
* LICENSE file in the root directory of this source tree.
|
|
*
|
|
* @format
|
|
* @flow strict-local
|
|
*/
|
|
|
|
import type {
|
|
BubblingEventHandler,
|
|
DirectEventHandler,
|
|
Double,
|
|
WithDefault,
|
|
} from '../../Types/CodegenTypes';
|
|
|
|
import codegenNativeComponent from '../../Utilities/codegenNativeComponent';
|
|
import type {HostComponent} from '../../Renderer/shims/ReactNativeTypes';
|
|
|
|
import type {ColorValue} from '../../StyleSheet/StyleSheet';
|
|
import type {ImageSource} from '../../Image/ImageSource';
|
|
import type {ViewProps} from '../View/ViewPropTypes';
|
|
|
|
type Event = $ReadOnly<{|
|
|
value: Double,
|
|
fromUser?: boolean,
|
|
|}>;
|
|
|
|
type NativeProps = $ReadOnly<{|
|
|
...ViewProps,
|
|
|
|
// Props
|
|
disabled?: WithDefault<boolean, false>,
|
|
enabled?: WithDefault<boolean, true>,
|
|
maximumTrackImage?: ?ImageSource,
|
|
maximumTrackTintColor?: ?ColorValue,
|
|
maximumValue?: WithDefault<Double, 1>,
|
|
minimumTrackImage?: ?ImageSource,
|
|
minimumTrackTintColor?: ?ColorValue,
|
|
minimumValue?: WithDefault<Double, 0>,
|
|
step?: WithDefault<Double, 0>,
|
|
testID?: WithDefault<string, ''>,
|
|
thumbImage?: ?ImageSource,
|
|
thumbTintColor?: ?ColorValue,
|
|
trackImage?: ?ImageSource,
|
|
value?: WithDefault<Double, 0>,
|
|
|
|
// Events
|
|
onValueChange?: ?BubblingEventHandler<Event>,
|
|
onSlidingComplete?: ?DirectEventHandler<Event>,
|
|
|}>;
|
|
|
|
export default (codegenNativeComponent<NativeProps>('Slider', {
|
|
interfaceOnly: true,
|
|
paperComponentName: 'RCTSlider',
|
|
}): HostComponent<NativeProps>);
|