mirror of
https://github.com/facebook/react-native.git
synced 2025-11-01 09:14:26 +00:00
Rick Hanlon
7927437a6d
Summary: ## Overview This diff switches the RCTSlider onSlidingComplete event on iOS from a bubbling event to a direct (non-bubbling) event to match the non-bubbling type on android. Note that in this case these seems like a bug. I will still explain the motivation and reasoning as this will come up in future diffs. ## Changelog [Slider][BREAKING] Switch Slider onSlidingComplete event to a non-bubbling event on iOS to match Android ## Motivation: The motivation here is that when we codgen the view configs, we'll need to unify all of the events and props across platforms for components that have the same name on iOS and Android. In this case, the view configs (below) conflict for onSlidingComplete. On iOS this is under bubblingEventTypes, on Android this is under directEventTypes. We have code [here](https://fburl.com/3s1dahm2) in the react native renderer which ensures an event is not listed as both. ``` // iOS const SliderViewConfig = { bubblingEventTypes: { onSlidingComplete: { phasedRegistrationNames: { captured: 'onChangeCapture', bubbled: 'onChange' } } }, directEventTypes: { // None }, validAttributes: { // ... } }; ``` ``` // Android const SliderViewConfig = { bubblingEventTypes: { // None }, directEventTypes: { onSlidingComplete: { registrationName: 'onEventDirect' } }, validAttributes: { // ... } }; ``` ## Solutions There are three solutions to this issue: 1. Don't generate view configs 2. Rename the component on one platform 3. Make a breaking change in the event behavior on one platform to make it consistent across both platforms Here we've chosen option #3 Reviewed By: TheSavior Differential Revision: D15322304 fbshipit-source-id: ff1ab86efe9e2bc50fd3f7619e6760ab5c1c5090
98 lines
2.5 KiB
Objective-C
98 lines
2.5 KiB
Objective-C
/**
|
|
* Copyright (c) Facebook, Inc. and its affiliates.
|
|
*
|
|
* This source code is licensed under the MIT license found in the
|
|
* LICENSE file in the root directory of this source tree.
|
|
*/
|
|
|
|
#import "RCTSliderManager.h"
|
|
|
|
#import "RCTBridge.h"
|
|
#import "RCTEventDispatcher.h"
|
|
#import "RCTSlider.h"
|
|
#import "UIView+React.h"
|
|
|
|
@implementation RCTSliderManager
|
|
|
|
RCT_EXPORT_MODULE()
|
|
|
|
- (UIView *)view
|
|
{
|
|
RCTSlider *slider = [RCTSlider new];
|
|
[slider addTarget:self action:@selector(sliderValueChanged:)
|
|
forControlEvents:UIControlEventValueChanged];
|
|
[slider addTarget:self action:@selector(sliderTouchEnd:)
|
|
forControlEvents:(UIControlEventTouchUpInside |
|
|
UIControlEventTouchUpOutside |
|
|
UIControlEventTouchCancel)];
|
|
return slider;
|
|
}
|
|
|
|
static void RCTSendSliderEvent(RCTSlider *sender, BOOL continuous)
|
|
{
|
|
float value = sender.value;
|
|
|
|
if (sender.step > 0 &&
|
|
sender.step <= (sender.maximumValue - sender.minimumValue)) {
|
|
|
|
value =
|
|
MAX(sender.minimumValue,
|
|
MIN(sender.maximumValue,
|
|
sender.minimumValue + round((sender.value - sender.minimumValue) / sender.step) * sender.step
|
|
)
|
|
);
|
|
|
|
[sender setValue:value animated:YES];
|
|
}
|
|
|
|
if (continuous) {
|
|
if (sender.onValueChange && sender.lastValue != value) {
|
|
sender.onValueChange(@{
|
|
@"value": @(value),
|
|
});
|
|
}
|
|
} else {
|
|
if (sender.onSlidingComplete) {
|
|
sender.onSlidingComplete(@{
|
|
@"value": @(value),
|
|
});
|
|
}
|
|
}
|
|
|
|
sender.lastValue = value;
|
|
}
|
|
|
|
- (void)sliderValueChanged:(RCTSlider *)sender
|
|
{
|
|
RCTSendSliderEvent(sender, YES);
|
|
}
|
|
|
|
- (void)sliderTouchEnd:(RCTSlider *)sender
|
|
{
|
|
RCTSendSliderEvent(sender, NO);
|
|
}
|
|
|
|
RCT_EXPORT_VIEW_PROPERTY(value, float);
|
|
RCT_EXPORT_VIEW_PROPERTY(step, float);
|
|
RCT_EXPORT_VIEW_PROPERTY(trackImage, UIImage);
|
|
RCT_EXPORT_VIEW_PROPERTY(minimumTrackImage, UIImage);
|
|
RCT_EXPORT_VIEW_PROPERTY(maximumTrackImage, UIImage);
|
|
RCT_EXPORT_VIEW_PROPERTY(minimumValue, float);
|
|
RCT_EXPORT_VIEW_PROPERTY(maximumValue, float);
|
|
RCT_EXPORT_VIEW_PROPERTY(minimumTrackTintColor, UIColor);
|
|
RCT_EXPORT_VIEW_PROPERTY(maximumTrackTintColor, UIColor);
|
|
RCT_EXPORT_VIEW_PROPERTY(onValueChange, RCTBubblingEventBlock);
|
|
RCT_EXPORT_VIEW_PROPERTY(onSlidingComplete, RCTDirectEventBlock);
|
|
RCT_EXPORT_VIEW_PROPERTY(thumbTintColor, UIColor);
|
|
RCT_EXPORT_VIEW_PROPERTY(thumbImage, UIImage);
|
|
RCT_CUSTOM_VIEW_PROPERTY(disabled, BOOL, RCTSlider)
|
|
{
|
|
if (json) {
|
|
view.enabled = !([RCTConvert BOOL:json]);
|
|
} else {
|
|
view.enabled = defaultView.enabled;
|
|
}
|
|
}
|
|
|
|
@end
|