react-native

mirror of https://github.com/facebook/react-native.git synced 2025-11-01 09:14:26 +00:00

Files

T

Vojtech Novak 8a82503b54 fix SectionList scrollToLocation and prevent regressions (#25997 )

Summary:
Recently there were quite a few changes to this functionality, and they caused breakages

https://github.com/facebook/react-native/issues/21577
https://github.com/facebook/react-native/issues/24034
https://github.com/facebook/react-native/issues/24734
https://github.com/facebook/react-native/issues/24735

Currently,  whichever `viewOffset` I pass, it will be overridden (either by 0 or something computed in the if body). This fixes the issue and also adds tests to make sure there is no regression.

## Changelog

[Javascript] [Fixed] - VirtualizedSectionList scrollToLocation viewOffset param ignored
Pull Request resolved: https://github.com/facebook/react-native/pull/25997

Test Plan: tests pass

Differential Revision: D16784036

Pulled By: cpojer

fbshipit-source-id: 46421250993785176634b30a2629a6e12f0c2278

2019-08-13 07:52:54 -07:00

__snapshots__

VirtualizedList.RenderItem throws when using function component with hooks (#24832 )

2019-05-20 07:46:03 -07:00

FillRateHelper-test.js

Migrate "Libraries" from Haste to standard path-based requires (sans vendor & renderers) (#24749 )

2019-05-08 08:48:59 -07:00

FlatList-test.js

VirtualizedList.RenderItem throws when using function component with hooks (#24832 )

2019-05-20 07:46:03 -07:00

SectionList-test.js

Migrate "Libraries" from Haste to standard path-based requires (sans vendor & renderers) (#24749 )