mirror of https://github.com/facebook/react-native.git synced 2025-11-01 09:14:26 +00:00

Files

T

Alpha 15656342a8 Resolve android crash on display modal (#35380 )

Summary:
From exception logging, found crashes due to `Attempt to invoke virtual method 'int android.view.ViewGroup.getChildCount()' on a null object reference`. Tracing through the stack, it appears the constructor for `ViewGroup` conditionally calls `initializeScrollbarsInternal()`, which in turn calls `getChildCount()`.  However `ReactModalHostView` overrides `getChildCount()`, so `getChildCount()` is called before `ReactModalHostView` constructor completes, resulting in null reference when accessing `mHostView` from `getChildCount()`.

## Changelog

<!-- Help reviewers and the release process by writing your own changelog entry. For an example, see:
https://reactnative.dev/contributing/changelogs-in-pull-requests
-->

[Android] [Fixed] - Fix crash on initialize modal

Pull Request resolved: https://github.com/facebook/react-native/pull/35380

Test Plan: In the rn-tester project, display a modal.

Reviewed By: javache, cipolleschi

Differential Revision: D41392235

Pulled By: ryancat

fbshipit-source-id: ce78e4d458ad41769e78139ea0a8a038384e830d

2022-11-18 04:06:32 -08:00

cmake-utils

Fix variable expansion in ReactNative-application.cmake (#35306 )

2022-11-12 09:11:46 -08:00

external-artifacts

Publish both Hermes Debug and Release inside react-native-artifacts

2022-10-19 09:53:49 -07:00

hermes-engine

Bump NDK to 23 and fbjni to 0.3.0 (#35066 )

2022-10-25 02:31:10 -07:00

libs

Upgrade Android support library to version 28 in RN