mirror of
https://github.com/facebook/react-native.git
synced 2025-11-01 09:14:26 +00:00
Summary: This allow adding ReadableNativeArray/Map to a WritableNativeArray/Map. There is no reason why this can't be allowed, the types were actually updated in https://github.com/facebook/react-native/commit/1a2937151b8d36e8741ef9d4fbe7d2ebf65cb775#diff-d1dc45892b3ba242aed9a1bf7219d2838fae8c7a654c402ba70bc4b100149624, but the assertion remains. ## Changelog <!-- Help reviewers and the release process by writing your own changelog entry. For an example, see: https://github.com/facebook/react-native/wiki/Changelog --> [Internal] [Added] - Allow passing ReadableNativeMap/Array to push/put methods Pull Request resolved: https://github.com/facebook/react-native/pull/32910 Test Plan: Tested that RN tester builds and run correctly on android. Reviewed By: christophpurrer Differential Revision: D33646510 Pulled By: yungsters fbshipit-source-id: 878f1994b73ed1cf830966ab296b9c0325630da1
66 lines
1.8 KiB
Java
66 lines
1.8 KiB
Java
/*
|
|
* Copyright (c) Meta Platforms, Inc. and affiliates.
|
|
*
|
|
* This source code is licensed under the MIT license found in the
|
|
* LICENSE file in the root directory of this source tree.
|
|
*/
|
|
|
|
package com.facebook.react.bridge;
|
|
|
|
import androidx.annotation.Nullable;
|
|
import com.facebook.infer.annotation.Assertions;
|
|
import com.facebook.jni.HybridData;
|
|
import com.facebook.proguard.annotations.DoNotStrip;
|
|
|
|
/**
|
|
* Implementation of a write-only array stored in native memory. Use {@link Arguments#createArray()}
|
|
* if you need to stub out creating this class in a test. TODO(5815532): Check if consumed on read
|
|
*/
|
|
@DoNotStrip
|
|
public class WritableNativeArray extends ReadableNativeArray implements WritableArray {
|
|
static {
|
|
ReactBridge.staticInit();
|
|
}
|
|
|
|
public WritableNativeArray() {
|
|
super(initHybrid());
|
|
}
|
|
|
|
@Override
|
|
public native void pushNull();
|
|
|
|
@Override
|
|
public native void pushBoolean(boolean value);
|
|
|
|
@Override
|
|
public native void pushDouble(double value);
|
|
|
|
@Override
|
|
public native void pushInt(int value);
|
|
|
|
@Override
|
|
public native void pushString(@Nullable String value);
|
|
|
|
// Note: this consumes the map so do not reuse it.
|
|
@Override
|
|
public void pushArray(@Nullable ReadableArray array) {
|
|
Assertions.assertCondition(
|
|
array == null || array instanceof ReadableNativeArray, "Illegal type provided");
|
|
pushNativeArray((ReadableNativeArray) array);
|
|
}
|
|
|
|
// Note: this consumes the map so do not reuse it.
|
|
@Override
|
|
public void pushMap(@Nullable ReadableMap map) {
|
|
Assertions.assertCondition(
|
|
map == null || map instanceof ReadableNativeMap, "Illegal type provided");
|
|
pushNativeMap((ReadableNativeMap) map);
|
|
}
|
|
|
|
private static native HybridData initHybrid();
|
|
|
|
private native void pushNativeArray(ReadableNativeArray array);
|
|
|
|
private native void pushNativeMap(ReadableNativeMap map);
|
|
}
|