mirror of
https://github.com/facebook/react-native.git
synced 2025-11-01 09:14:26 +00:00
Andrew Coates
4d87d8c6b2
Summary: react-native-windows runs with a more strict set of warnings as errors. This fixes a bunch of warnings being hit while compiling core react-native code as part of react-native-windows. In particular warnings about mismatched signed/unsigned comparisons, lossy conversions, and variable names that conflict with names in outer scopes (yoga has a global for `leading` and `trailing` that conflicts with some local variable names) ## Changelog [Internal] [Fixed] - Fix various C++ warnings Pull Request resolved: https://github.com/facebook/react-native/pull/31399 Test Plan: I've run these changes in react-native-windows. -- Shouldn't have any functionality difference. Reviewed By: sammy-SC Differential Revision: D28290188 Pulled By: rozele fbshipit-source-id: 2f7cf87f58d73a3f43510ac888dbcb9ab177d134
58 lines
1.6 KiB
C++
58 lines
1.6 KiB
C++
/*
|
|
* Copyright (c) Facebook, Inc. and its affiliates.
|
|
*
|
|
* This source code is licensed under the MIT license found in the
|
|
* LICENSE file in the root directory of this source tree.
|
|
*/
|
|
|
|
#include "TelemetryController.h"
|
|
|
|
#include <react/renderer/mounting/MountingCoordinator.h>
|
|
|
|
namespace facebook {
|
|
namespace react {
|
|
|
|
TelemetryController::TelemetryController(
|
|
MountingCoordinator const &mountingCoordinator) noexcept
|
|
: mountingCoordinator_(mountingCoordinator) {}
|
|
|
|
bool TelemetryController::pullTransaction(
|
|
std::function<void(MountingTransactionMetadata metadata)> willMount,
|
|
std::function<void(ShadowViewMutationList const &mutations)> doMount,
|
|
std::function<void(MountingTransactionMetadata metadata)> didMount) const {
|
|
auto optional = mountingCoordinator_.pullTransaction();
|
|
if (!optional.has_value()) {
|
|
return false;
|
|
}
|
|
|
|
auto transaction = std::move(*optional);
|
|
|
|
auto surfaceId = transaction.getSurfaceId();
|
|
auto number = transaction.getNumber();
|
|
auto telemetry = transaction.getTelemetry();
|
|
auto numberOfMutations = static_cast<int>(transaction.getMutations().size());
|
|
|
|
mutex_.lock();
|
|
auto compoundTelemetry = compoundTelemetry_;
|
|
mutex_.unlock();
|
|
|
|
willMount({surfaceId, number, telemetry, compoundTelemetry});
|
|
|
|
telemetry.willMount();
|
|
doMount(std::move(transaction.getMutations()));
|
|
telemetry.didMount();
|
|
|
|
compoundTelemetry.incorporate(telemetry, numberOfMutations);
|
|
|
|
didMount({surfaceId, number, telemetry, compoundTelemetry});
|
|
|
|
mutex_.lock();
|
|
compoundTelemetry_ = compoundTelemetry;
|
|
mutex_.unlock();
|
|
|
|
return true;
|
|
}
|
|
|
|
} // namespace react
|
|
} // namespace facebook
|