mirror of
https://github.com/facebook/react-native.git
synced 2025-11-01 09:14:26 +00:00
Joshua Gross
64c93977bd
Summary: Improve debuggability of ShadowViewTree failures by logging ShadowView hashes. This allows us to track down exactly where a change to the tree was introduced. If necessary, if specific repros are found, logging can also be added to LayoutAnimations or other places to find out where a specific ShadowView version (identified by hash) was introduced. Changelog: [Internal] Reviewed By: mdvacca Differential Revision: D27488766 fbshipit-source-id: f4866f771fc6494435fb46f09953ea69fb280a5b
100 lines
2.8 KiB
C++
100 lines
2.8 KiB
C++
/*
|
|
* Copyright (c) Facebook, Inc. and its affiliates.
|
|
*
|
|
* This source code is licensed under the MIT license found in the
|
|
* LICENSE file in the root directory of this source tree.
|
|
*/
|
|
|
|
#include "StubView.h"
|
|
|
|
#ifdef STUB_VIEW_TREE_VERBOSE
|
|
#include <glog/logging.h>
|
|
#endif
|
|
|
|
namespace facebook {
|
|
namespace react {
|
|
|
|
StubView::operator ShadowView() const {
|
|
auto shadowView = ShadowView{};
|
|
shadowView.componentName = componentName;
|
|
shadowView.componentHandle = componentHandle;
|
|
shadowView.surfaceId = surfaceId;
|
|
shadowView.tag = tag;
|
|
shadowView.props = props;
|
|
shadowView.eventEmitter = eventEmitter;
|
|
shadowView.layoutMetrics = layoutMetrics;
|
|
shadowView.state = state;
|
|
return shadowView;
|
|
}
|
|
|
|
void StubView::update(ShadowView const &shadowView) {
|
|
componentName = shadowView.componentName;
|
|
componentHandle = shadowView.componentHandle;
|
|
surfaceId = shadowView.surfaceId;
|
|
tag = shadowView.tag;
|
|
props = shadowView.props;
|
|
eventEmitter = shadowView.eventEmitter;
|
|
layoutMetrics = shadowView.layoutMetrics;
|
|
state = shadowView.state;
|
|
}
|
|
|
|
bool operator==(StubView const &lhs, StubView const &rhs) {
|
|
if (lhs.props != rhs.props) {
|
|
#ifdef STUB_VIEW_TREE_VERBOSE
|
|
LOG(ERROR) << "StubView: props do not match. lhs hash: "
|
|
<< std::hash<ShadowView>{}((ShadowView)lhs)
|
|
<< " rhs hash: " << std::hash<ShadowView>{}((ShadowView)rhs);
|
|
#endif
|
|
return false;
|
|
}
|
|
if (lhs.layoutMetrics != rhs.layoutMetrics) {
|
|
#ifdef STUB_VIEW_TREE_VERBOSE
|
|
LOG(ERROR) << "StubView: layoutMetrics do not match lhs hash: "
|
|
<< std::hash<ShadowView>{}((ShadowView)lhs)
|
|
<< " rhs hash: " << std::hash<ShadowView>{}((ShadowView)rhs);
|
|
#endif
|
|
return false;
|
|
}
|
|
return true;
|
|
}
|
|
|
|
bool operator!=(StubView const &lhs, StubView const &rhs) {
|
|
return !(lhs == rhs);
|
|
}
|
|
|
|
#if RN_DEBUG_STRING_CONVERTIBLE
|
|
|
|
std::string getDebugName(StubView const &stubView) {
|
|
return std::string{"Stub"} +
|
|
std::string{
|
|
stubView.componentHandle ? stubView.componentName : "[invalid]"};
|
|
}
|
|
|
|
std::vector<DebugStringConvertibleObject> getDebugProps(
|
|
StubView const &stubView,
|
|
DebugStringConvertibleOptions options) {
|
|
return {
|
|
{"surfaceId", getDebugDescription(stubView.surfaceId, options)},
|
|
{"tag", getDebugDescription(stubView.tag, options)},
|
|
{"props", getDebugDescription(stubView.props, options)},
|
|
{"eventEmitter", getDebugDescription(stubView.eventEmitter, options)},
|
|
{"layoutMetrics", getDebugDescription(stubView.layoutMetrics, options)},
|
|
{"state", getDebugDescription(stubView.state, options)},
|
|
};
|
|
}
|
|
|
|
std::vector<StubView> getDebugChildren(
|
|
StubView const &stubView,
|
|
DebugStringConvertibleOptions options) {
|
|
std::vector<StubView> result;
|
|
for (auto const &child : stubView.children) {
|
|
result.push_back(*child);
|
|
}
|
|
return result;
|
|
}
|
|
|
|
#endif
|
|
|
|
} // namespace react
|
|
} // namespace facebook
|