react-native

mirror of https://github.com/facebook/react-native.git synced 2025-11-01 09:14:26 +00:00

Files

T

Valentin SherginandFacebook Github Bot 0eb7c7bc43 Fabric: Resetting *all* ShadowNode pointers in MountingCoordinator::revoke

Summary:
With this diff (and maybe other coming in the future), we are enforcing a model where Fabric Core actively/architecturally prevents `jsi::Object` to overlive `UIManager`. That never was a promise that but I think it's achievable; it should help to eliminate the whole class of possible crashes (application layer still must ensure that Scheduler is deallocated before `jsi::Runtime`).

Clearing all pointers to `ShadowNode`s in `MountingCoordinator` prevents from extending the lifetime of ShadowNodes stored inside revoked `MountingCoordinator` (the lifetime of `MountingCoordinator` is up to application layer).

That should help prevent crashes (not all of them!) caused by `jsi::Object`s overliving `jsi::Runtime`.

Changelog: [Internal]

Reviewed By: sammy-SC

Differential Revision: D18333708

fbshipit-source-id: 4391998b8f805563cfaff834fc56e85b98bc4d68

2019-11-08 22:20:39 -08:00

better

Tidy up license headers [2/n]

2019-10-16 10:06:34 -07:00

callinvoker

Tidy up license headers [2/n]

2019-10-16 10:06:34 -07:00

config

Tidy up license headers [2/n]

2019-10-16 10:06:34 -07:00

cxxreact

Replace folly::make_unique with std::make_unique (#26730 )