mirror of
https://github.com/facebook/react-native.git
synced 2025-11-01 09:14:26 +00:00
Nick Gerleman
7136be22fa
Summary: Pull Request resolved: https://github.com/facebook/react-native/pull/50147 Noticed a couple bugs here, around a crash from assertion internal to the caching map which hashes on the AttributedString, that may or may not be related. 1. We are missing `baseTextAttributes` for both hashing and equality (which is mostly innocuous, but still wrong) 2. We were not hashing or comparing `textAlignVertical` 3. For equality, we were comparing parent shadow view tag and metrics, but for hashing, we were hashing the whole ShadowView. I think #3 could cause issues, since we could see different hash despite equality, which could break invariants. Changelog: [Internal] Reviewed By: lunaleaps Differential Revision: D71500246 fbshipit-source-id: 462749d5ca10d10bf0dab88089253a2bb8e603fb
302 lines
11 KiB
C++
302 lines
11 KiB
C++
/*
|
|
* Copyright (c) Meta Platforms, Inc. and affiliates.
|
|
*
|
|
* This source code is licensed under the MIT license found in the
|
|
* LICENSE file in the root directory of this source tree.
|
|
*/
|
|
|
|
#include "TextAttributes.h"
|
|
|
|
#include <react/renderer/attributedstring/conversions.h>
|
|
#include <react/renderer/core/conversions.h>
|
|
#include <react/renderer/core/graphicsConversions.h>
|
|
#include <react/utils/FloatComparison.h>
|
|
#include <cmath>
|
|
|
|
#include <react/renderer/debug/debugStringConvertibleUtils.h>
|
|
|
|
namespace facebook::react {
|
|
|
|
void TextAttributes::apply(TextAttributes textAttributes) {
|
|
// Color
|
|
foregroundColor = textAttributes.foregroundColor
|
|
? textAttributes.foregroundColor
|
|
: foregroundColor;
|
|
backgroundColor = textAttributes.backgroundColor
|
|
? textAttributes.backgroundColor
|
|
: backgroundColor;
|
|
opacity =
|
|
!std::isnan(textAttributes.opacity) ? textAttributes.opacity : opacity;
|
|
|
|
// Font
|
|
fontFamily = !textAttributes.fontFamily.empty() ? textAttributes.fontFamily
|
|
: fontFamily;
|
|
fontSize =
|
|
!std::isnan(textAttributes.fontSize) ? textAttributes.fontSize : fontSize;
|
|
fontSizeMultiplier = !std::isnan(textAttributes.fontSizeMultiplier)
|
|
? textAttributes.fontSizeMultiplier
|
|
: fontSizeMultiplier;
|
|
fontWeight = textAttributes.fontWeight.has_value() ? textAttributes.fontWeight
|
|
: fontWeight;
|
|
fontStyle = textAttributes.fontStyle.has_value() ? textAttributes.fontStyle
|
|
: fontStyle;
|
|
fontVariant = textAttributes.fontVariant.has_value()
|
|
? textAttributes.fontVariant
|
|
: fontVariant;
|
|
allowFontScaling = textAttributes.allowFontScaling.has_value()
|
|
? textAttributes.allowFontScaling
|
|
: allowFontScaling;
|
|
maxFontSizeMultiplier = !std::isnan(textAttributes.maxFontSizeMultiplier)
|
|
? textAttributes.maxFontSizeMultiplier
|
|
: maxFontSizeMultiplier;
|
|
dynamicTypeRamp = textAttributes.dynamicTypeRamp.has_value()
|
|
? textAttributes.dynamicTypeRamp
|
|
: dynamicTypeRamp;
|
|
letterSpacing = !std::isnan(textAttributes.letterSpacing)
|
|
? textAttributes.letterSpacing
|
|
: letterSpacing;
|
|
textTransform = textAttributes.textTransform.has_value()
|
|
? textAttributes.textTransform
|
|
: textTransform;
|
|
|
|
// Paragraph Styles
|
|
lineHeight = !std::isnan(textAttributes.lineHeight)
|
|
? textAttributes.lineHeight
|
|
: lineHeight;
|
|
alignment = textAttributes.alignment.has_value() ? textAttributes.alignment
|
|
: alignment;
|
|
baseWritingDirection = textAttributes.baseWritingDirection.has_value()
|
|
? textAttributes.baseWritingDirection
|
|
: baseWritingDirection;
|
|
lineBreakStrategy = textAttributes.lineBreakStrategy.has_value()
|
|
? textAttributes.lineBreakStrategy
|
|
: lineBreakStrategy;
|
|
lineBreakMode = textAttributes.lineBreakMode.has_value()
|
|
? textAttributes.lineBreakMode
|
|
: lineBreakMode;
|
|
|
|
// Decoration
|
|
textDecorationColor = textAttributes.textDecorationColor
|
|
? textAttributes.textDecorationColor
|
|
: textDecorationColor;
|
|
textDecorationLineType = textAttributes.textDecorationLineType.has_value()
|
|
? textAttributes.textDecorationLineType
|
|
: textDecorationLineType;
|
|
textDecorationStyle = textAttributes.textDecorationStyle.has_value()
|
|
? textAttributes.textDecorationStyle
|
|
: textDecorationStyle;
|
|
|
|
// Shadow
|
|
textShadowOffset = textAttributes.textShadowOffset.has_value()
|
|
? textAttributes.textShadowOffset.value()
|
|
: textShadowOffset;
|
|
textShadowRadius = !std::isnan(textAttributes.textShadowRadius)
|
|
? textAttributes.textShadowRadius
|
|
: textShadowRadius;
|
|
textShadowColor = textAttributes.textShadowColor
|
|
? textAttributes.textShadowColor
|
|
: textShadowColor;
|
|
|
|
// Special
|
|
isHighlighted = textAttributes.isHighlighted.has_value()
|
|
? textAttributes.isHighlighted
|
|
: isHighlighted;
|
|
// TextAttributes "inherits" the isPressable value from ancestors, so this
|
|
// only applies the current node's value for isPressable if it is truthy.
|
|
isPressable =
|
|
textAttributes.isPressable.has_value() && *textAttributes.isPressable
|
|
? textAttributes.isPressable
|
|
: isPressable;
|
|
layoutDirection = textAttributes.layoutDirection.has_value()
|
|
? textAttributes.layoutDirection
|
|
: layoutDirection;
|
|
accessibilityRole = textAttributes.accessibilityRole.has_value()
|
|
? textAttributes.accessibilityRole
|
|
: accessibilityRole;
|
|
role = textAttributes.role.has_value() ? textAttributes.role : role;
|
|
|
|
textAlignVertical = textAttributes.textAlignVertical.has_value()
|
|
? textAttributes.textAlignVertical
|
|
: textAlignVertical;
|
|
}
|
|
|
|
#pragma mark - Operators
|
|
|
|
bool TextAttributes::operator==(const TextAttributes& rhs) const {
|
|
return std::tie(
|
|
foregroundColor,
|
|
backgroundColor,
|
|
fontFamily,
|
|
fontWeight,
|
|
fontStyle,
|
|
fontVariant,
|
|
allowFontScaling,
|
|
dynamicTypeRamp,
|
|
alignment,
|
|
textAlignVertical,
|
|
baseWritingDirection,
|
|
lineBreakStrategy,
|
|
textDecorationColor,
|
|
textDecorationLineType,
|
|
textDecorationStyle,
|
|
textShadowOffset,
|
|
textShadowColor,
|
|
isHighlighted,
|
|
isPressable,
|
|
layoutDirection,
|
|
accessibilityRole,
|
|
role,
|
|
textTransform,
|
|
textAlignVertical) ==
|
|
std::tie(
|
|
rhs.foregroundColor,
|
|
rhs.backgroundColor,
|
|
rhs.fontFamily,
|
|
rhs.fontWeight,
|
|
rhs.fontStyle,
|
|
rhs.fontVariant,
|
|
rhs.allowFontScaling,
|
|
rhs.dynamicTypeRamp,
|
|
rhs.alignment,
|
|
rhs.textAlignVertical,
|
|
rhs.baseWritingDirection,
|
|
rhs.lineBreakStrategy,
|
|
rhs.textDecorationColor,
|
|
rhs.textDecorationLineType,
|
|
rhs.textDecorationStyle,
|
|
rhs.textShadowOffset,
|
|
rhs.textShadowColor,
|
|
rhs.isHighlighted,
|
|
rhs.isPressable,
|
|
rhs.layoutDirection,
|
|
rhs.accessibilityRole,
|
|
rhs.role,
|
|
rhs.textTransform,
|
|
rhs.textAlignVertical) &&
|
|
floatEquality(maxFontSizeMultiplier, rhs.maxFontSizeMultiplier) &&
|
|
floatEquality(opacity, rhs.opacity) &&
|
|
floatEquality(fontSize, rhs.fontSize) &&
|
|
floatEquality(fontSizeMultiplier, rhs.fontSizeMultiplier) &&
|
|
floatEquality(letterSpacing, rhs.letterSpacing) &&
|
|
floatEquality(lineHeight, rhs.lineHeight) &&
|
|
floatEquality(textShadowRadius, rhs.textShadowRadius);
|
|
}
|
|
|
|
TextAttributes TextAttributes::defaultTextAttributes() {
|
|
static auto textAttributes = [] {
|
|
auto textAttributes = TextAttributes{};
|
|
// Non-obvious (can be different among platforms) default text attributes.
|
|
textAttributes.foregroundColor = blackColor();
|
|
textAttributes.backgroundColor = clearColor();
|
|
textAttributes.fontSize = 14.0;
|
|
textAttributes.fontSizeMultiplier = 1.0;
|
|
return textAttributes;
|
|
}();
|
|
return textAttributes;
|
|
}
|
|
|
|
#pragma mark - DebugStringConvertible
|
|
|
|
#if RN_DEBUG_STRING_CONVERTIBLE
|
|
SharedDebugStringConvertibleList TextAttributes::getDebugProps() const {
|
|
const auto& textAttributes = TextAttributes::defaultTextAttributes();
|
|
return {
|
|
// Color
|
|
debugStringConvertibleItem(
|
|
"backgroundColor", backgroundColor, textAttributes.backgroundColor),
|
|
debugStringConvertibleItem(
|
|
"foregroundColor", foregroundColor, textAttributes.foregroundColor),
|
|
debugStringConvertibleItem("opacity", opacity, textAttributes.opacity),
|
|
|
|
// Font
|
|
debugStringConvertibleItem(
|
|
"fontFamily", fontFamily, textAttributes.fontFamily),
|
|
debugStringConvertibleItem("fontSize", fontSize, textAttributes.fontSize),
|
|
debugStringConvertibleItem(
|
|
"fontSizeMultiplier",
|
|
fontSizeMultiplier,
|
|
textAttributes.fontSizeMultiplier),
|
|
debugStringConvertibleItem(
|
|
"fontWeight", fontWeight, textAttributes.fontWeight),
|
|
debugStringConvertibleItem(
|
|
"fontStyle", fontStyle, textAttributes.fontStyle),
|
|
debugStringConvertibleItem(
|
|
"fontVariant", fontVariant, textAttributes.fontVariant),
|
|
debugStringConvertibleItem(
|
|
"allowFontScaling",
|
|
allowFontScaling,
|
|
textAttributes.allowFontScaling),
|
|
debugStringConvertibleItem(
|
|
"maxFontSizeMultiplier",
|
|
maxFontSizeMultiplier,
|
|
textAttributes.maxFontSizeMultiplier),
|
|
debugStringConvertibleItem(
|
|
"dynamicTypeRamp", dynamicTypeRamp, textAttributes.dynamicTypeRamp),
|
|
debugStringConvertibleItem(
|
|
"letterSpacing", letterSpacing, textAttributes.letterSpacing),
|
|
|
|
// Paragraph Styles
|
|
debugStringConvertibleItem(
|
|
"lineHeight", lineHeight, textAttributes.lineHeight),
|
|
debugStringConvertibleItem(
|
|
"alignment", alignment, textAttributes.alignment),
|
|
debugStringConvertibleItem(
|
|
"baseWritingDirection",
|
|
baseWritingDirection,
|
|
textAttributes.baseWritingDirection),
|
|
debugStringConvertibleItem(
|
|
"lineBreakStrategyIOS",
|
|
lineBreakStrategy,
|
|
textAttributes.lineBreakStrategy),
|
|
debugStringConvertibleItem(
|
|
"lineBreakModeIOS", lineBreakMode, textAttributes.lineBreakMode),
|
|
|
|
// Decoration
|
|
debugStringConvertibleItem(
|
|
"textDecorationColor",
|
|
textDecorationColor,
|
|
textAttributes.textDecorationColor),
|
|
debugStringConvertibleItem(
|
|
"textDecorationLineType",
|
|
textDecorationLineType,
|
|
textAttributes.textDecorationLineType),
|
|
debugStringConvertibleItem(
|
|
"textDecorationStyle",
|
|
textDecorationStyle,
|
|
textAttributes.textDecorationStyle),
|
|
|
|
// Shadow
|
|
debugStringConvertibleItem(
|
|
"textShadowOffset",
|
|
textShadowOffset,
|
|
textAttributes.textShadowOffset),
|
|
debugStringConvertibleItem(
|
|
"textShadowRadius",
|
|
textShadowRadius,
|
|
textAttributes.textShadowRadius),
|
|
debugStringConvertibleItem(
|
|
"textShadowColor", textShadowColor, textAttributes.textShadowColor),
|
|
|
|
// Special
|
|
debugStringConvertibleItem(
|
|
"isHighlighted", isHighlighted, textAttributes.isHighlighted),
|
|
debugStringConvertibleItem(
|
|
"isPressable", isPressable, textAttributes.isPressable),
|
|
debugStringConvertibleItem(
|
|
"layoutDirection", layoutDirection, textAttributes.layoutDirection),
|
|
debugStringConvertibleItem(
|
|
"accessibilityRole",
|
|
accessibilityRole,
|
|
textAttributes.accessibilityRole),
|
|
debugStringConvertibleItem("role", role, textAttributes.role),
|
|
|
|
debugStringConvertibleItem(
|
|
"textAlignVertical",
|
|
textAlignVertical,
|
|
textAttributes.textAlignVertical),
|
|
};
|
|
}
|
|
#endif
|
|
|
|
} // namespace facebook::react
|