mirror of
https://github.com/facebook/react-native.git
synced 2025-11-01 09:14:26 +00:00
b782934f3f
Summary: In Windows, if you clicked on a Switch component to toggle it, you could see it "shimmy" back and forth once before settling. The native Switch ends up toggling three times every time it's invoked. `Switch.js` prevents the native switch from toggling to the new value by explicitly setting the switch to `this.props.value` when it receives an `onChange` event. The re-setting of the value wasn't fast enough to prevent the `Switch` from starting to toggle, causing the visual shimmy. The solution is taken from `TextInput`. `TextInput.js` stores `_lastNativeText` when it receives an `onChange` event. In `componentDidUpdate`, it puts `this.props.text` back on the native textbox if the value of `this.props.text` isn't the same as `_lastNativeText`, which is how it ensures that it is a controlled component. Porting this to the `Switch` results in only one toggle happening per invoke, removing the shimmy, while preserving the controlled component behavior. This bug is not visible on Android or iOS, only Windows, however the code causing the bug was in `Switch.js` and it seems reasonable to avoid changing the value of the native switch excessively. ## Changelog [General] [Fixed] - Fix excessive toggles on the Switch component Pull Request resolved: https://github.com/facebook/react-native/pull/26496 Test Plan: Used RNTester on Android and iOS to test the Switch component and made sure that all scenarios behave as expected visually. Also ensured through the debugger that the value of the native switch is only being changed once, instead of three times. Reviewed By: TheSavior Differential Revision: D17468905 Pulled By: JoshuaGross fbshipit-source-id: 92bf511510306968c3573ee4eed6df009850fd77
246 lines
6.7 KiB
JavaScript
246 lines
6.7 KiB
JavaScript
/**
|
|
* Copyright (c) Facebook, Inc. and its affiliates.
|
|
*
|
|
* This source code is licensed under the MIT license found in the
|
|
* LICENSE file in the root directory of this source tree.
|
|
*
|
|
* @flow
|
|
* @format
|
|
*/
|
|
|
|
'use strict';
|
|
|
|
const AndroidSwitchNativeComponent = require('./AndroidSwitchNativeComponent');
|
|
const Platform = require('../../Utilities/Platform');
|
|
const React = require('react');
|
|
const StyleSheet = require('../../StyleSheet/StyleSheet');
|
|
|
|
import type {ColorValue} from '../../StyleSheet/StyleSheetTypes';
|
|
import type {SyntheticEvent} from '../../Types/CoreEventTypes';
|
|
import type {ViewProps} from '../View/ViewPropTypes';
|
|
import SwitchNativeComponent from './SwitchNativeComponent';
|
|
|
|
type SwitchChangeEvent = SyntheticEvent<
|
|
$ReadOnly<{|
|
|
value: boolean,
|
|
|}>,
|
|
>;
|
|
|
|
export type Props = $ReadOnly<{|
|
|
...ViewProps,
|
|
|
|
/**
|
|
* Whether the switch is disabled. Defaults to false.
|
|
*/
|
|
disabled?: ?boolean,
|
|
|
|
/**
|
|
* Boolean value of the switch. Defaults to false.
|
|
*/
|
|
value?: ?boolean,
|
|
|
|
/**
|
|
* Custom color for the switch thumb.
|
|
*/
|
|
thumbColor?: ?ColorValue,
|
|
|
|
/**
|
|
* Custom colors for the switch track.
|
|
*
|
|
* NOTE: On iOS when the switch value is false, the track shrinks into the
|
|
* border. If you want to change the color of the background exposed by the
|
|
* shrunken track, use `ios_backgroundColor`.
|
|
*/
|
|
trackColor?: ?$ReadOnly<{|
|
|
false?: ?ColorValue,
|
|
true?: ?ColorValue,
|
|
|}>,
|
|
|
|
/**
|
|
* On iOS, custom color for the background. This background color can be seen
|
|
* either when the switch value is false or when the switch is disabled (and
|
|
* the switch is translucent).
|
|
*/
|
|
ios_backgroundColor?: ?ColorValue,
|
|
|
|
/**
|
|
* Called when the user tries to change the value of the switch.
|
|
*
|
|
* Receives the change event as an argument. If you want to only receive the
|
|
* new value, use `onValueChange` instead.
|
|
*/
|
|
onChange?: ?(event: SwitchChangeEvent) => Promise<void> | void,
|
|
|
|
/**
|
|
* Called when the user tries to change the value of the switch.
|
|
*
|
|
* Receives the new value as an argument. If you want to instead receive an
|
|
* event, use `onChange`.
|
|
*/
|
|
onValueChange?: ?(value: boolean) => Promise<void> | void,
|
|
|}>;
|
|
|
|
/**
|
|
* A visual toggle between two mutually exclusive states.
|
|
*
|
|
* This is a controlled component that requires an `onValueChange` callback that
|
|
* updates the `value` prop in order for the component to reflect user actions.
|
|
* If the `value` prop is not updated, the component will continue to render the
|
|
* supplied `value` prop instead of the expected result of any user actions.
|
|
*/
|
|
class Switch extends React.Component<Props> {
|
|
_nativeSwitchRef: ?React.ElementRef<
|
|
typeof SwitchNativeComponent | typeof AndroidSwitchNativeComponent,
|
|
>;
|
|
_lastNativeValue: ?boolean;
|
|
|
|
render(): React.Node {
|
|
const {
|
|
disabled,
|
|
ios_backgroundColor,
|
|
onChange,
|
|
onValueChange,
|
|
style,
|
|
thumbColor,
|
|
trackColor,
|
|
value,
|
|
...props
|
|
} = this.props;
|
|
|
|
// Support deprecated color props.
|
|
let _thumbColor = thumbColor;
|
|
let _trackColorForFalse = trackColor?.false;
|
|
let _trackColorForTrue = trackColor?.true;
|
|
|
|
// TODO: Remove support for these props after a couple releases.
|
|
const {thumbTintColor, tintColor, onTintColor} = (props: $FlowFixMe);
|
|
if (thumbTintColor != null) {
|
|
_thumbColor = thumbTintColor;
|
|
if (__DEV__) {
|
|
console.warn(
|
|
'Switch: `thumbTintColor` is deprecated, use `thumbColor` instead.',
|
|
);
|
|
}
|
|
}
|
|
if (tintColor != null) {
|
|
_trackColorForFalse = tintColor;
|
|
if (__DEV__) {
|
|
console.warn(
|
|
'Switch: `tintColor` is deprecated, use `trackColor` instead.',
|
|
);
|
|
}
|
|
}
|
|
if (onTintColor != null) {
|
|
_trackColorForTrue = onTintColor;
|
|
if (__DEV__) {
|
|
console.warn(
|
|
'Switch: `onTintColor` is deprecated, use `trackColor` instead.',
|
|
);
|
|
}
|
|
}
|
|
|
|
if (Platform.OS === 'android') {
|
|
const platformProps = {
|
|
enabled: disabled !== true,
|
|
on: value === true,
|
|
style,
|
|
thumbTintColor: _thumbColor,
|
|
trackColorForFalse: _trackColorForFalse,
|
|
trackColorForTrue: _trackColorForTrue,
|
|
trackTintColor:
|
|
value === true ? _trackColorForTrue : _trackColorForFalse,
|
|
};
|
|
|
|
return (
|
|
<AndroidSwitchNativeComponent
|
|
{...props}
|
|
{...platformProps}
|
|
accessibilityRole={props.accessibilityRole ?? 'button'}
|
|
onChange={this._handleChange}
|
|
onResponderTerminationRequest={returnsFalse}
|
|
onStartShouldSetResponder={returnsTrue}
|
|
ref={this._handleSwitchNativeComponentRef}
|
|
/>
|
|
);
|
|
}
|
|
|
|
const platformProps = {
|
|
disabled,
|
|
onTintColor: _trackColorForTrue,
|
|
style: StyleSheet.compose(
|
|
{height: 31, width: 51},
|
|
StyleSheet.compose(
|
|
style,
|
|
ios_backgroundColor == null
|
|
? null
|
|
: {
|
|
backgroundColor: ios_backgroundColor,
|
|
borderRadius: 16,
|
|
},
|
|
),
|
|
),
|
|
thumbTintColor: _thumbColor,
|
|
tintColor: _trackColorForFalse,
|
|
value: value === true,
|
|
};
|
|
|
|
return (
|
|
<SwitchNativeComponent
|
|
{...props}
|
|
{...platformProps}
|
|
accessibilityRole={props.accessibilityRole ?? 'button'}
|
|
onChange={this._handleChange}
|
|
onResponderTerminationRequest={returnsFalse}
|
|
onStartShouldSetResponder={returnsTrue}
|
|
ref={this._handleSwitchNativeComponentRef}
|
|
/>
|
|
);
|
|
}
|
|
|
|
componentDidUpdate() {
|
|
// This is necessary in case native updates the switch and JS decides
|
|
// that the update should be ignored and we should stick with the value
|
|
// that we have in JS.
|
|
const nativeProps = {};
|
|
const value = this.props.value === true;
|
|
|
|
if (this._lastNativeValue !== value && typeof value === 'boolean') {
|
|
nativeProps.value = value;
|
|
}
|
|
|
|
if (
|
|
Object.keys(nativeProps).length > 0 &&
|
|
this._nativeSwitchRef &&
|
|
this._nativeSwitchRef.setNativeProps
|
|
) {
|
|
this._nativeSwitchRef.setNativeProps(nativeProps);
|
|
}
|
|
}
|
|
|
|
_handleChange = (event: SwitchChangeEvent) => {
|
|
if (this.props.onChange != null) {
|
|
this.props.onChange(event);
|
|
}
|
|
|
|
if (this.props.onValueChange != null) {
|
|
this.props.onValueChange(event.nativeEvent.value);
|
|
}
|
|
|
|
this._lastNativeValue = event.nativeEvent.value;
|
|
this.forceUpdate();
|
|
};
|
|
|
|
_handleSwitchNativeComponentRef = (
|
|
ref: ?React.ElementRef<
|
|
typeof SwitchNativeComponent | typeof AndroidSwitchNativeComponent,
|
|
>,
|
|
) => {
|
|
this._nativeSwitchRef = ref;
|
|
};
|
|
}
|
|
|
|
const returnsFalse = () => false;
|
|
const returnsTrue = () => true;
|
|
|
|
module.exports = Switch;
|