mirror of
https://github.com/facebook/react-native.git
synced 2025-11-01 09:14:26 +00:00
Ramanpreet Nara
d9deee20e7
Summary: ## Context `NativeModuleRegistryBuilder` calls `TurboReactPackage.getNativeModuleIterator()` to access ModuleHolders for all the NativeModules in the `TurboReactPackage`. We then filter out the ModuleHolders that contain `TurboModules`, before using that list to make create the `NativeModuleRegistry`. ## Problem Creating `ModuleHolders` has the side-effect of actually creating the NativeModule if it requires eager initialization. See [ModuleHolder.java](https://fburl.com/diffusion/4avdtio0): ``` class ModuleHolder { // ... public ModuleHolder(ReactModuleInfo moduleInfo, Provider<? extends NativeModule> provider) { mName = moduleInfo.name(); mProvider = provider; mReactModuleInfo = moduleInfo; if (moduleInfo.needsEagerInit()) { mModule = create(); // HERE! } } ``` So, we need to filter out TurboModules before we even create ModuleHolders. Changelog: [Android][Fixed] - Refactor TurboModule filtering in NativeModuleRegistryBuilder Reviewed By: PeteTheHeat, mdvacca Differential Revision: D18814010 fbshipit-source-id: a120d2b619b9280ba70e21d131dccc5a9fc6346d
69 lines
2.8 KiB
Java
69 lines
2.8 KiB
Java
/*
|
|
* Copyright (c) Facebook, Inc. and its affiliates.
|
|
*
|
|
* This source code is licensed under the MIT license found in the
|
|
* LICENSE file in the root directory of this source tree.
|
|
*/
|
|
|
|
package com.facebook.react;
|
|
|
|
import com.facebook.react.bridge.ModuleHolder;
|
|
import com.facebook.react.bridge.NativeModuleRegistry;
|
|
import com.facebook.react.bridge.ReactApplicationContext;
|
|
import java.util.HashMap;
|
|
import java.util.Map;
|
|
|
|
/** Helper class to build NativeModuleRegistry. */
|
|
public class NativeModuleRegistryBuilder {
|
|
|
|
private final ReactApplicationContext mReactApplicationContext;
|
|
private final ReactInstanceManager mReactInstanceManager;
|
|
|
|
private final Map<String, ModuleHolder> mModules = new HashMap<>();
|
|
|
|
public NativeModuleRegistryBuilder(
|
|
ReactApplicationContext reactApplicationContext, ReactInstanceManager reactInstanceManager) {
|
|
mReactApplicationContext = reactApplicationContext;
|
|
mReactInstanceManager = reactInstanceManager;
|
|
}
|
|
|
|
public void processPackage(ReactPackage reactPackage) {
|
|
// We use an iterable instead of an iterator here to ensure thread safety, and that this list
|
|
// cannot be modified
|
|
Iterable<ModuleHolder> moduleHolders;
|
|
if (reactPackage instanceof LazyReactPackage) {
|
|
moduleHolders =
|
|
((LazyReactPackage) reactPackage).getNativeModuleIterator(mReactApplicationContext);
|
|
} else if (reactPackage instanceof TurboReactPackage) {
|
|
moduleHolders =
|
|
((TurboReactPackage) reactPackage).getNativeModuleIterator(mReactApplicationContext);
|
|
} else {
|
|
moduleHolders =
|
|
ReactPackageHelper.getNativeModuleIterator(
|
|
reactPackage, mReactApplicationContext, mReactInstanceManager);
|
|
}
|
|
|
|
for (ModuleHolder moduleHolder : moduleHolders) {
|
|
String name = moduleHolder.getName();
|
|
if (mModules.containsKey(name)) {
|
|
ModuleHolder existingNativeModule = mModules.get(name);
|
|
if (!moduleHolder.getCanOverrideExistingModule()) {
|
|
throw new IllegalStateException(
|
|
"Native module "
|
|
+ name
|
|
+ " tried to override "
|
|
+ existingNativeModule.getClassName()
|
|
+ ". Check the getPackages() method in MainApplication.java, it might be that module is being created twice. If this was your intention, set canOverrideExistingModule=true. "
|
|
+ "This error may also be present if the package is present only once in getPackages() but is also automatically added later during build time by autolinking. Try removing the existing entry and rebuild.");
|
|
}
|
|
mModules.remove(existingNativeModule);
|
|
}
|
|
mModules.put(name, moduleHolder);
|
|
}
|
|
}
|
|
|
|
public NativeModuleRegistry build() {
|
|
return new NativeModuleRegistry(mReactApplicationContext, mModules);
|
|
}
|
|
}
|