mirror of
https://github.com/facebook/react-native.git
synced 2025-11-01 09:14:26 +00:00
Pieter De Baets
0a8164d993
Summary: Pull Request resolved: https://github.com/facebook/react-native/pull/36574 We would previously generate the following codegen for optional args ``` return static_cast<NativeAudioModuleCxxSpecJSI *>(&turboModule)->playAudio( rt, args[0].asString(rt), args[1].isNull() || args[1].isUndefined() ? std::nullopt : std::make_optional(args[1].asString(rt)), args[2].isNull() || args[2].isUndefined() ? std::nullopt : std::make_optional(args[2].asString(rt)), args[3].asNumber(), count < 4 || args[4].isNull() || args[4].isUndefined() ? std::nullopt : std::make_optional(args[4].asObject(rt)), count < 5 || args[5].isNull() || args[5].isUndefined() ? std::nullopt : std::make_optional(args[5].asObject(rt)), count < 6 || args[6].isNull() || args[6].isUndefined() ? std::nullopt : std::make_optional(args[6].asBool()) ); ``` However, the counts checked are off-by-one, causing us to incorrectly process args. Changelog: [General][Fixed] Issue with TurboModule C++ codegen with optional args Differential Revision: D44299193 fbshipit-source-id: f00b9f5e09c2f524f9393137346c256d8b6b2979
81 lines
2.0 KiB
JavaScript
81 lines
2.0 KiB
JavaScript
/**
|
|
* Copyright (c) Meta Platforms, Inc. and affiliates.
|
|
*
|
|
* This source code is licensed under the MIT license found in the
|
|
* LICENSE file in the root directory of this source tree.
|
|
*
|
|
* @flow strict-local
|
|
* @format
|
|
*/
|
|
|
|
import type {TurboModule} from 'react-native/Libraries/TurboModule/RCTExport';
|
|
|
|
import {TurboModuleRegistry} from 'react-native';
|
|
|
|
export enum EnumInt {
|
|
IA = 23,
|
|
IB = 42,
|
|
}
|
|
|
|
export enum EnumFloat {
|
|
FA = 1.23,
|
|
FB = 4.56,
|
|
}
|
|
|
|
export enum EnumNone {
|
|
NA,
|
|
NB,
|
|
}
|
|
|
|
export enum EnumStr {
|
|
SA = 's---a',
|
|
SB = 's---b',
|
|
}
|
|
|
|
export type UnionFloat = 1.44 | 2.88 | 5.76;
|
|
export type UnionString = 'One' | 'Two' | 'Three';
|
|
export type UnionObject = {value: number} | {low: string};
|
|
|
|
export type ConstantsStruct = {|
|
|
const1: boolean,
|
|
const2: number,
|
|
const3: string,
|
|
|};
|
|
|
|
export type ObjectStruct = {|
|
|
a: number,
|
|
b: string,
|
|
c?: ?string,
|
|
|};
|
|
|
|
export type ValueStruct = {|
|
|
x: number,
|
|
y: string,
|
|
z: ObjectStruct,
|
|
|};
|
|
|
|
export interface Spec extends TurboModule {
|
|
+getArray: (arg: Array<ObjectStruct | null>) => Array<ObjectStruct | null>;
|
|
+getBool: (arg: boolean) => boolean;
|
|
+getConstants: () => ConstantsStruct;
|
|
+getCustomEnum: (arg: EnumInt) => EnumInt;
|
|
+getNumEnum: (arg: EnumInt) => EnumFloat;
|
|
+getStrEnum: (arg: EnumNone) => EnumStr;
|
|
+getMap: (arg: {[key: string]: ?number}) => {[key: string]: ?number};
|
|
+getNumber: (arg: number) => number;
|
|
+getObject: (arg: ObjectStruct) => ObjectStruct;
|
|
+getSet: (arg: Array<number>) => Array<number>;
|
|
+getString: (arg: string) => string;
|
|
+getUnion: (x: UnionFloat, y: UnionString, z: UnionObject) => string;
|
|
+getValue: (x: number, y: string, z: ObjectStruct) => ValueStruct;
|
|
+getValueWithCallback: (callback: (value: string) => void) => void;
|
|
+getValueWithPromise: (error: boolean) => Promise<string>;
|
|
+getWithWithOptionalArgs: (optionalArg?: boolean) => boolean;
|
|
+voidFunc: () => void;
|
|
+emitCustomDeviceEvent: (eventName: string) => void;
|
|
}
|
|
|
|
export default (TurboModuleRegistry.get<Spec>(
|
|
'NativeCxxModuleExampleCxx',
|
|
): ?Spec);
|