mirror of
https://github.com/facebook/react-native.git
synced 2025-11-01 09:14:26 +00:00
Pieter De Baets
0a8164d993
Summary: Pull Request resolved: https://github.com/facebook/react-native/pull/36574 We would previously generate the following codegen for optional args ``` return static_cast<NativeAudioModuleCxxSpecJSI *>(&turboModule)->playAudio( rt, args[0].asString(rt), args[1].isNull() || args[1].isUndefined() ? std::nullopt : std::make_optional(args[1].asString(rt)), args[2].isNull() || args[2].isUndefined() ? std::nullopt : std::make_optional(args[2].asString(rt)), args[3].asNumber(), count < 4 || args[4].isNull() || args[4].isUndefined() ? std::nullopt : std::make_optional(args[4].asObject(rt)), count < 5 || args[5].isNull() || args[5].isUndefined() ? std::nullopt : std::make_optional(args[5].asObject(rt)), count < 6 || args[6].isNull() || args[6].isUndefined() ? std::nullopt : std::make_optional(args[6].asBool()) ); ``` However, the counts checked are off-by-one, causing us to incorrectly process args. Changelog: [General][Fixed] Issue with TurboModule C++ codegen with optional args Differential Revision: D44299193 fbshipit-source-id: f00b9f5e09c2f524f9393137346c256d8b6b2979
133 lines
3.6 KiB
C++
133 lines
3.6 KiB
C++
/*
|
|
* Copyright (c) Meta Platforms, Inc. and affiliates.
|
|
*
|
|
* This source code is licensed under the MIT license found in the
|
|
* LICENSE file in the root directory of this source tree.
|
|
*/
|
|
|
|
#pragma once
|
|
|
|
#if __has_include(<React-Codegen/AppSpecsJSI.h>) // CocoaPod headers on Apple
|
|
#include <React-Codegen/AppSpecsJSI.h>
|
|
#elif __has_include("AppSpecsJSI.h") // Cmake headers on Android
|
|
#include "AppSpecsJSI.h"
|
|
#else // BUCK headers
|
|
#include <AppSpecs/AppSpecsJSI.h>
|
|
#endif
|
|
#include <memory>
|
|
#include <set>
|
|
#include <string>
|
|
#include <vector>
|
|
|
|
namespace facebook::react {
|
|
|
|
#pragma mark - Structs
|
|
using ConstantsStruct =
|
|
NativeCxxModuleExampleCxxBaseConstantsStruct<bool, int32_t, std::string>;
|
|
|
|
template <>
|
|
struct Bridging<ConstantsStruct>
|
|
: NativeCxxModuleExampleCxxBaseConstantsStructBridging<
|
|
bool,
|
|
int32_t,
|
|
std::string> {};
|
|
|
|
using ObjectStruct = NativeCxxModuleExampleCxxBaseObjectStruct<
|
|
int32_t,
|
|
std::string,
|
|
std::optional<std::string>>;
|
|
|
|
template <>
|
|
struct Bridging<ObjectStruct>
|
|
: NativeCxxModuleExampleCxxBaseObjectStructBridging<
|
|
int32_t,
|
|
std::string,
|
|
std::optional<std::string>> {};
|
|
|
|
using ValueStruct =
|
|
NativeCxxModuleExampleCxxBaseValueStruct<double, std::string, ObjectStruct>;
|
|
|
|
template <>
|
|
struct Bridging<ValueStruct> : NativeCxxModuleExampleCxxBaseValueStructBridging<
|
|
double,
|
|
std::string,
|
|
ObjectStruct> {};
|
|
|
|
#pragma mark - enums
|
|
enum CustomEnumInt { A = 23, B = 42 };
|
|
|
|
template <>
|
|
struct Bridging<CustomEnumInt> {
|
|
static CustomEnumInt fromJs(jsi::Runtime &rt, int32_t value) {
|
|
if (value == 23) {
|
|
return CustomEnumInt::A;
|
|
} else if (value == 42) {
|
|
return CustomEnumInt::B;
|
|
} else {
|
|
throw jsi::JSError(rt, "Invalid enum value");
|
|
}
|
|
}
|
|
|
|
static jsi::Value toJs(jsi::Runtime &rt, CustomEnumInt value) {
|
|
return bridging::toJs(rt, static_cast<int32_t>(value));
|
|
}
|
|
};
|
|
|
|
#pragma mark - implementation
|
|
class NativeCxxModuleExample
|
|
: public NativeCxxModuleExampleCxxSpec<NativeCxxModuleExample> {
|
|
public:
|
|
NativeCxxModuleExample(std::shared_ptr<CallInvoker> jsInvoker);
|
|
|
|
void getValueWithCallback(
|
|
jsi::Runtime &rt,
|
|
AsyncCallback<std::string> callback);
|
|
|
|
std::vector<std::optional<ObjectStruct>> getArray(
|
|
jsi::Runtime &rt,
|
|
std::vector<std::optional<ObjectStruct>> arg);
|
|
|
|
bool getBool(jsi::Runtime &rt, bool arg);
|
|
|
|
ConstantsStruct getConstants(jsi::Runtime &rt);
|
|
|
|
CustomEnumInt getCustomEnum(jsi::Runtime &rt, CustomEnumInt arg);
|
|
|
|
NativeCxxModuleExampleCxxEnumFloat getNumEnum(
|
|
jsi::Runtime &rt,
|
|
NativeCxxModuleExampleCxxEnumInt arg);
|
|
|
|
NativeCxxModuleExampleCxxEnumStr getStrEnum(
|
|
jsi::Runtime &rt,
|
|
NativeCxxModuleExampleCxxEnumNone arg);
|
|
|
|
std::map<std::string, std::optional<int32_t>> getMap(
|
|
jsi::Runtime &rt,
|
|
std::map<std::string, std::optional<int32_t>> arg);
|
|
|
|
double getNumber(jsi::Runtime &rt, double arg);
|
|
|
|
ObjectStruct getObject(jsi::Runtime &rt, ObjectStruct arg);
|
|
|
|
std::set<float> getSet(jsi::Runtime &rt, std::set<float> arg);
|
|
|
|
std::string getString(jsi::Runtime &rt, std::string arg);
|
|
|
|
std::string getUnion(jsi::Runtime &rt, float x, std::string y, jsi::Object z);
|
|
|
|
ValueStruct
|
|
getValue(jsi::Runtime &rt, double x, std::string y, ObjectStruct z);
|
|
|
|
AsyncPromise<std::string> getValueWithPromise(jsi::Runtime &rt, bool error);
|
|
|
|
bool getWithWithOptionalArgs(
|
|
jsi::Runtime &rt,
|
|
std::optional<bool> optionalArg);
|
|
|
|
void voidFunc(jsi::Runtime &rt);
|
|
|
|
void emitCustomDeviceEvent(jsi::Runtime &rt, jsi::String eventName);
|
|
};
|
|
|
|
} // namespace facebook::react
|