Facebook/react-native
1
0
Fork 0
mirror of https://github.com/facebook/react-native.git synced 2025-11-01 09:14:26 +00:00
Code Issues Packages Projects Releases Wiki Activity
Files
0912ee179c210fb6b2ed9afbb3f2fbc5fb8a2bb3
react-native/React/CoreModules
T
History
Phillip Pan 0912ee179c remove fallbackResource from RCTBundleURLProvider api 
Summary:
if you xgbs for `fallbackResource:`, you'll find only one place is actually passing a non-nil value to this parameter.

https://www.internalfb.com/code/fbsource/fbobjc/Apps/Wilde/FBReactModule2/FBReactModuleAPI/FBReactModuleAPI/FBReactSourceLoaderProd.mm?lines=79

but if we look at the implementation, `@"main"` is the fallback value...

https://www.internalfb.com/code/fbsource/[cd930f5f15cca0feb732317147de318ce6aa1db3]/xplat/js/react-native-github/React/Base/RCTBundleURLProvider.mm?lines=224

let's just simplify this api and get rid of this parameter.

Changelog: [Internal]

Reviewed By: raedle

Differential Revision: D32641476

fbshipit-source-id: 637a8c0f7bea834bfecd804a521155f41aaaff7e
2021-12-16 00:46:14 -08:00
..
BUCK
Move RCT* Buck targets to GitHub
2021-08-04 13:03:21 -07:00
CoreModulesPlugins.h
Make RCTEventDispatcher TurboModule-compatible
2020-10-14 02:40:10 -07:00
CoreModulesPlugins.mm
Fix crash in RCTCoreModulesClassProvider during quit
2021-04-28 13:29:06 -07:00
RCTAccessibilityManager.h
Tidy up license headers [2/n]
2019-10-16 10:06:34 -07:00
RCTAccessibilityManager.mm
feat: support queuing accessibility announcements on ios (#32637)
2021-12-02 00:34:05 -08:00
RCTAccessibilityManager+Internal.h
Daily arc lint --take CLANGFORMAT
2021-10-02 08:33:02 -07:00
RCTActionSheetManager.h
Tidy up license headers [2/n]
2019-10-16 10:06:34 -07:00
RCTActionSheetManager.mm
feat: add cancelButtonTintColor props in ActionSheetIOS for change cancel button tint color (#31972)
2021-09-22 10:44:17 -07:00
RCTAlertController.h
Fix retain cycle in RCTAlertController
2020-12-04 18:12:23 -08:00
RCTAlertController.m
Fix RCTAlertController import when embed in existing iOS projects (#32457)
2021-11-11 15:30:50 -08:00
RCTAlertManager.h
Clang format for all React Native files
2020-03-08 23:01:17 -07:00
RCTAlertManager.mm
Fix retain cycle in RCTAlertController
2020-12-04 18:12:23 -08:00
RCTAppearance.h
Restore react native override preference when live shopping ends.
2021-12-02 07:20:05 -08:00
RCTAppearance.mm
Restore react native override preference when live shopping ends.
2021-12-02 07:20:05 -08:00
RCTAppState.h
Call stopObserving on correct queue
2020-09-21 17:30:34 -07:00
RCTAppState.mm
Make RCTEventDispatcher TurboModule-compatible
2020-10-14 02:40:10 -07:00
RCTAsyncLocalStorage.h
Clang format for all React Native files
2020-03-08 23:01:17 -07:00
RCTAsyncLocalStorage.mm
iOS: Log error when invalid NSNull data is passed to RCTAsyncLocalStorage
2021-08-03 16:41:32 -07:00
RCTClipboard.h
Tidy up license headers [2/n]
2019-10-16 10:06:34 -07:00
RCTClipboard.mm
Part 2: Update ObjC++ codegen classes to use ObjCTurboModule::InitParams
2020-04-16 17:29:55 -07:00
RCTDeviceInfo.h
Remove unneeded NSNotification center removeObserver
2019-11-04 10:19:30 -08:00
RCTDeviceInfo.mm
Move NativeModule initialization logic outside of setModuleRegistry
2021-09-08 12:46:35 -07:00
RCTDevLoadingView.h
Clang format for all React Native files
2020-03-08 23:01:17 -07:00
RCTDevLoadingView.mm
Daily arc lint --take CLANGFORMAT
2021-09-23 07:54:31 -07:00
RCTDevMenu.h
Delete concept of live reloading
2021-03-11 16:12:17 -08:00
RCTDevMenu.mm
remove fallbackResource from RCTBundleURLProvider api
2021-12-16 00:46:14 -08:00
RCTDevSettings.h
Migrate RCTDevSettings to initialize
2021-05-21 14:49:51 -07:00
RCTDevSettings.mm
Setup a new macro to gate the core packager functionality
2021-09-13 12:09:12 -07:00
RCTDevSplitBundleLoader.h
Fix loading from Metro in Bridgeless mode (#29453)
2020-07-23 17:11:32 -07:00
RCTDevSplitBundleLoader.mm
Setup a new macro to gate the core packager functionality
2021-09-13 12:09:12 -07:00
RCTEventDispatcher.h
Migrate NativeModules to initialize
2021-05-21 14:49:51 -07:00
RCTEventDispatcher.mm
Remove RCTRootView.bridge usage from RCTBaseViewController
2021-09-02 16:50:08 -07:00
RCTExceptionsManager.h
Clang format for all React Native files
2020-03-08 23:01:17 -07:00
RCTExceptionsManager.mm
Remove shared responsibility between LogBox and ExceptionsManager native module
2021-10-08 11:08:43 -07:00
RCTFPSGraph.h
Clang format for all React Native files
2020-03-08 23:01:17 -07:00
RCTFPSGraph.m
Clang format for all React Native files
2020-03-08 23:01:17 -07:00
RCTI18nManager.h
Tidy up license headers [2/n]
2019-10-16 10:06:34 -07:00
RCTI18nManager.mm
Part 2: Update ObjC++ codegen classes to use ObjCTurboModule::InitParams
2020-04-16 17:29:55 -07:00
RCTKeyboardObserver.h
Make RCTKeyboardObserver TurboModule-compatible
2019-11-01 12:06:20 -07:00
RCTKeyboardObserver.mm
Bridgeless Mode: Migrate modules away from invokeJS
2021-05-14 09:22:58 -07:00
RCTLogBox.h
Fix Logbox Fullscreen View
2020-08-18 12:29:45 -07:00
RCTLogBox.mm
Daily arc lint --take CLANGFORMAT
2021-10-25 04:08:21 -07:00
RCTLogBoxView.h
Fix Logbox Fullscreen View
2020-08-18 12:29:45 -07:00
RCTLogBoxView.mm
Fix Logbox Fullscreen View
2020-08-18 12:29:45 -07:00
RCTPerfMonitor.mm
Refactor: Assign string label to each case in RCTPLTag enum for startup performance logging
2021-12-08 14:51:04 -08:00
RCTPlatform.h
Tidy up license headers [2/n]
2019-10-16 10:06:34 -07:00
RCTPlatform.mm
Run getConstants method statements on main queue
2020-06-02 23:01:35 -07:00
RCTRedBox.h
Clang format for all React Native files
2020-03-08 23:01:17 -07:00
RCTRedBox.mm
Remove iOS 11 version check (#32151)
2021-09-22 10:37:09 -07:00
RCTSourceCode.h
Tidy up license headers [2/n]
2019-10-16 10:06:34 -07:00
RCTSourceCode.mm
Migrate RCTSourceCode to RCTBundleManager
2021-05-04 18:33:23 -07:00
RCTStatusBarManager.h
remove most of tvOS remnants from the code (#29407)
2020-09-28 21:26:41 -07:00
RCTStatusBarManager.mm
Make RCTEventDispatcher TurboModule-compatible
2020-10-14 02:40:10 -07:00
RCTTiming.h
Migrate NativeModules to initialize
2021-05-21 14:49:51 -07:00
RCTTiming.mm
Migrate NativeModules to initialize
2021-05-21 14:49:51 -07:00
RCTWebSocketExecutor.h
Make RCTWebSocketModule TurboModule-compatible
2019-11-08 14:14:46 -08:00
RCTWebSocketExecutor.mm
Codemod: Give legacy cxx and ObjC-only NativeModules a getTurboModule: method
2021-04-08 21:15:52 -07:00
RCTWebSocketModule.h
Make RCTWebSocketModule TurboModule-compatible
2019-11-08 14:14:46 -08:00
RCTWebSocketModule.mm
fix: crash when insert nil value into a dictionary (#30066)
2020-10-12 01:47:49 -07:00
React-CoreModules.podspec
Move codegen output out of node_modules
2021-10-25 20:48:24 -07:00