react-native

mirror of https://github.com/facebook/react-native.git synced 2025-11-01 09:14:26 +00:00

Files

T

Eric Rozell fe53cae954 Deduct offset from getValue result when detaching

Summary:
The NativeAnimated `getValue` API returns `value + offset`:
Android:
iOS: https://github.com/facebook/react-native/blob/main/Libraries/NativeAnimation/Nodes/RCTValueAnimatedNode.m#L44
Android: https://github.com/facebook/react-native/blob/main/ReactAndroid/src/main/java/com/facebook/react/animated/ValueAnimatedNode.java#L36

When we store the value after detaching the NativeAnimated node, it stores the result of the NativeAnimated `getValue` call to the `_value` property, so if we call `__getValue` at some later point on the `AnimatedValue`, we will count the offset twice.

This change deducts the offset value from the result returned from `getValue` when storing the latest value.

Changelog:
[General][Fixed] - AnimatedValue.__detach should store getValue result with offset deducted

Reviewed By: yungsters

Differential Revision: D32987003

fbshipit-source-id: 488d1fe512f886c7a9de1e5a4de8f19441ebd81e

2021-12-10 08:07:38 -08:00

__tests__

Deduct offset from getValue result when detaching

2021-12-10 08:07:38 -08:00

animations

pre-suppress this typing errors ahead of 154

2021-06-11 14:31:41 -07:00

components

RN: Disable collapsable for Animated Components

2021-09-29 17:22:21 -07:00

nodes

Deduct offset from getValue result when detaching