mirror of
https://github.com/facebook/react-native.git
synced 2025-11-01 09:14:26 +00:00
c540ff7bd1
Summary: This PR is a follow up of https://github.com/facebook/react-native/pull/35075 and https://github.com/facebook/react-native/commit/1546666a6d713ef756b2f11de9581e3b2bbe08dc to ensure that even in the local e2e testing scenario the new maven approach is followed - without this, RNTestProject on Android won't work, like so: <img width="1905" alt="Screenshot 2022-10-27 at 12 15 38" src="https://user-images.githubusercontent.com/16104054/198334105-30fb2037-4e7c-4814-8c3f-2412ba0bd49f.png"> And iOS will always build everything from source every time. This PR addresses both by generating the artifacts locally, and passing them to RNTestProject as if they were coming from a url (mimicking as closely as possible the behaviour for the final user) In doing so, there's been some refactoring to prep the ground for follow up work. * refactor CI to rely less on scripts directly in the CircleCI config, but invoke .js ones * we should be able to trigger more the "manual" artifacts generation so that it will only happen once between RNTester and RNTestProject, and we can pass existing artifacts to the other flows. * once all of this in place, a very good improvement would be to be able to download the maven artifacts kind of like nightlies and stables do. This will only be viable by checking that there's no local changes, after which there needs to be logic to pull down from CircleCI the artifacts based on git commit <-> circleCI job references. --- While at it, I've also fixed the hermes-engine podspec logic for detecting if it's on CI: basically the local e2e script needs to align with the changes done here: https://github.com/facebook/react-native/commit/4b512077354eb4702ce144e9958d7513c1607275 but as you can see there, the condition was actually inconsistent across the various files, so realigned to `CI === 'true'`. We probably didn't catch that so far 'cause the other condition in the hermes podspect (existence of `hermestag_file`) is only true on release branches and this new logic has not been in any release branches yet. ## Changelog <!-- Help reviewers and the release process by writing your own changelog entry. For an example, see: https://reactnative.dev/contributing/changelogs-in-pull-requests --> [Internal] [Fixed] - add logic to local e2e script to handle maven local for iOS and Android accordingly Pull Request resolved: https://github.com/facebook/react-native/pull/35104 Test Plan: Run ` yarn test-e2e-local -t RNTestProject -p Android` successfully. Run ` yarn test-e2e-local -t RNTestProject -p iOS` successfully. On the pod install stage, you will see `[Hermes] Using pre-built Hermes binaries from local path.` Reviewed By: dmytrorykun Differential Revision: D40893239 Pulled By: cipolleschi fbshipit-source-id: a31217ec4f177383c62292d00fabc4cbe4391cfd
250 lines
7.2 KiB
JavaScript
250 lines
7.2 KiB
JavaScript
/**
|
|
* Copyright (c) Meta Platforms, Inc. and affiliates.
|
|
*
|
|
* This source code is licensed under the MIT license found in the
|
|
* LICENSE file in the root directory of this source tree.
|
|
*
|
|
* @format
|
|
*/
|
|
|
|
'use strict';
|
|
|
|
/*
|
|
* This script is a re-interpretation of the old test-manual.e2e.sh script.
|
|
* the idea is to provide a better DX for the manual testing.
|
|
* It's using Javascript over Bash for consistency with the rest of the recent scripts
|
|
* and to make it more accessible for other devs to play around with.
|
|
*/
|
|
|
|
const {exec, exit, pushd, popd, pwd, cd, cp} = require('shelljs');
|
|
const yargs = require('yargs');
|
|
const fs = require('fs');
|
|
const path = require('path');
|
|
const os = require('os');
|
|
|
|
const {
|
|
launchAndroidEmulator,
|
|
isPackagerRunning,
|
|
launchPackagerInSeparateWindow,
|
|
} = require('./testing-utils');
|
|
|
|
const {
|
|
generateAndroidArtifacts,
|
|
saveFilesToRestore,
|
|
generateiOSArtifacts,
|
|
} = require('./release-utils');
|
|
|
|
const {
|
|
downloadHermesSourceTarball,
|
|
expandHermesSourceTarball,
|
|
} = require('./hermes/hermes-utils');
|
|
|
|
const argv = yargs
|
|
.option('t', {
|
|
alias: 'target',
|
|
default: 'RNTester',
|
|
choices: ['RNTester', 'RNTestProject'],
|
|
})
|
|
.option('p', {
|
|
alias: 'platform',
|
|
default: 'iOS',
|
|
choices: ['iOS', 'Android'],
|
|
})
|
|
.option('h', {
|
|
alias: 'hermes',
|
|
type: 'boolean',
|
|
default: true,
|
|
}).argv;
|
|
|
|
/*
|
|
* see the test-local-e2e.js script for clean up process
|
|
*/
|
|
|
|
// command order: we ask the user to select if they want to test RN tester
|
|
// or RNTestProject
|
|
|
|
// if they select RN tester, we ask if iOS or Android, and then we run the tests
|
|
// if they select RNTestProject, we run the RNTestProject test
|
|
|
|
// let's check if Metro is already running, if it is let's kill it and start fresh
|
|
if (isPackagerRunning() === 'running') {
|
|
exec("lsof -i :8081 | grep LISTEN | /usr/bin/awk '{print $2}' | xargs kill");
|
|
}
|
|
|
|
const onReleaseBranch = exec('git rev-parse --abbrev-ref HEAD', {
|
|
silent: true,
|
|
})
|
|
.stdout.trim()
|
|
.endsWith('-stable');
|
|
|
|
if (argv.target === 'RNTester') {
|
|
// FIXME: make sure that the commands retains colors
|
|
// (--ansi) doesn't always work
|
|
// see also https://github.com/shelljs/shelljs/issues/86
|
|
|
|
if (argv.platform === 'iOS') {
|
|
console.info(
|
|
`We're going to test the ${
|
|
argv.hermes ? 'Hermes' : 'JSC'
|
|
} version of RNTester iOS with the new Architecture enabled`,
|
|
);
|
|
|
|
// remember that for this to be successful
|
|
// you should have run bundle install once
|
|
// in your local setup - also: if I'm on release branch, I pick the
|
|
// hermes ref from the hermes ref file (see hermes-engine.podspec)
|
|
exec(
|
|
`cd packages/rn-tester && USE_HERMES=${
|
|
argv.hermes ? 1 : 0
|
|
} CI=${onReleaseBranch} RCT_NEW_ARCH_ENABLED=1 bundle exec pod install --ansi`,
|
|
);
|
|
|
|
// if everything succeeded so far, we can launch Metro and the app
|
|
// start the Metro server in a separate window
|
|
launchPackagerInSeparateWindow();
|
|
|
|
// launch the app on iOS simulator
|
|
pushd('packages/rn-tester');
|
|
exec('npx react-native run-ios --scheme RNTester');
|
|
popd();
|
|
} else {
|
|
// we do the android path here
|
|
|
|
launchAndroidEmulator();
|
|
|
|
console.info(
|
|
`We're going to test the ${
|
|
argv.hermes ? 'Hermes' : 'JSC'
|
|
} version of RNTester Android with the new Architecture enabled`,
|
|
);
|
|
exec(
|
|
`./gradlew :packages:rn-tester:android:app:${
|
|
argv.hermes ? 'installHermesDebug' : 'installJscDebug'
|
|
} --quiet`,
|
|
);
|
|
|
|
// launch the app on Android simulator
|
|
// TODO: we should find a way to make it work like for iOS, via npx react-native run-android
|
|
// currently, that fails with an error.
|
|
|
|
// if everything succeeded so far, we can launch Metro and the app
|
|
// start the Metro server in a separate window
|
|
launchPackagerInSeparateWindow();
|
|
|
|
// launch the app
|
|
exec(
|
|
'adb shell am start -n com.facebook.react.uiapp/com.facebook.react.uiapp.RNTesterActivity',
|
|
);
|
|
|
|
// just to make sure that the Android up won't have troubles finding the Metro server
|
|
exec('adb reverse tcp:8081 tcp:8081');
|
|
}
|
|
} else {
|
|
console.info("We're going to test a fresh new RN project");
|
|
|
|
// create the local npm package to feed the CLI
|
|
|
|
// base setup required (specular to publish-npm.js)
|
|
const tmpPublishingFolder = fs.mkdtempSync(
|
|
path.join(os.tmpdir(), 'rn-publish-'),
|
|
);
|
|
console.info(`The temp publishing folder is ${tmpPublishingFolder}`);
|
|
|
|
saveFilesToRestore(tmpPublishingFolder);
|
|
|
|
// we need to add the unique timestamp to avoid npm/yarn to use some local caches
|
|
const baseVersion = require('../package.json').version;
|
|
|
|
const dateIdentifier = new Date()
|
|
.toISOString()
|
|
.slice(0, -8)
|
|
.replace(/[-:]/g, '')
|
|
.replace(/[T]/g, '-');
|
|
|
|
const releaseVersion = `${baseVersion}-${dateIdentifier}`;
|
|
|
|
// this is needed to generate the Android artifacts correctly
|
|
exec(`node scripts/set-rn-version.js --to-version ${releaseVersion}`).code;
|
|
|
|
// Generate native files for Android
|
|
generateAndroidArtifacts(releaseVersion, tmpPublishingFolder);
|
|
|
|
// Setting up generating native iOS (will be done later)
|
|
const repoRoot = pwd();
|
|
const jsiFolder = `${repoRoot}/ReactCommon/jsi`;
|
|
const hermesCoreSourceFolder = `${repoRoot}/sdks/hermes`;
|
|
|
|
if (!fs.existsSync(hermesCoreSourceFolder)) {
|
|
console.info('The Hermes source folder is missing. Downloading...');
|
|
downloadHermesSourceTarball();
|
|
expandHermesSourceTarball();
|
|
}
|
|
|
|
// need to move the scripts inside the local hermes cloned folder
|
|
// cp sdks/hermes-engine/utils/*.sh <your_hermes_checkout>/utils/.
|
|
cp(
|
|
`${repoRoot}/sdks/hermes-engine/utils/*.sh`,
|
|
`${repoRoot}/sdks/hermes/utils/.`,
|
|
);
|
|
|
|
// for this scenario, we only need to create the debug build
|
|
// (env variable PRODUCTION defines that podspec side)
|
|
const buildType = 'Debug';
|
|
|
|
// the android ones get set into /private/tmp/maven-local
|
|
const localMavenPath = '/private/tmp/maven-local';
|
|
|
|
// Generate native files for iOS
|
|
const tarballOutputPath = generateiOSArtifacts(
|
|
jsiFolder,
|
|
hermesCoreSourceFolder,
|
|
buildType,
|
|
releaseVersion,
|
|
localMavenPath,
|
|
);
|
|
|
|
// create locally the node module
|
|
exec('npm pack');
|
|
|
|
const localNodeTGZPath = `${repoRoot}/react-native-${releaseVersion}.tgz`;
|
|
exec(`node scripts/set-rn-template-version.js "file:${localNodeTGZPath}"`);
|
|
|
|
pushd('/tmp/');
|
|
// need to avoid the pod install step - we'll do it later
|
|
exec(
|
|
`node ${repoRoot}/cli.js init RNTestProject --template ${repoRoot} --skip-install`,
|
|
);
|
|
|
|
cd('RNTestProject');
|
|
exec('yarn install');
|
|
|
|
// need to do this here so that Android will be properly setup either way
|
|
exec(
|
|
'echo "REACT_NATIVE_MAVEN_LOCAL_REPO=/private/tmp/maven-local" >> android/gradle.properties',
|
|
);
|
|
|
|
// doing the pod install here so that it's easier to play around RNTestProject
|
|
cd('ios');
|
|
exec('bundle install');
|
|
exec(
|
|
`HERMES_ENGINE_TARBALL_PATH=${tarballOutputPath} USE_HERMES=${
|
|
argv.hermes ? 1 : 0
|
|
} bundle exec pod install --ansi`,
|
|
);
|
|
|
|
cd('..');
|
|
|
|
if (argv.platform === 'iOS') {
|
|
exec('yarn ios');
|
|
} else {
|
|
// android
|
|
exec('yarn android');
|
|
}
|
|
popd();
|
|
|
|
// just cleaning up the temp folder, the rest is done by the test clean script
|
|
exec(`rm -rf ${tmpPublishingFolder}`);
|
|
}
|
|
|
|
exit(0);
|