Facebook/react-native
1
0
Fork 0
mirror of https://github.com/facebook/react-native.git synced 2025-11-01 09:14:26 +00:00
Code Issues Packages Projects Releases Wiki Activity
Files
07640dce698cce99488f9e3c00a90e7ffd5e2e4b
react-native/Libraries/Network
T
History
Samuel Susla ffc90c7f92 Remove requestToken being nil check from [RCTNetworkTask validateRequestToken] 
Summary:
Changelog: Fix [TypeError: Network request failed] on file upload

# Problem
In https://github.com/facebook/react-native/commit/31980094107ed37f8de70972dbcc319cc9a26339 I made method `loadImageForURL` blocking and nil returning since it was no longer cancellable.

However inside `[RCTNetworkTask validateRequestToken]` was a logic counting on request token being non nil.
This diff removes this check and adds `nullable` to `[RCTImageURLLoader loadImageForURL]` making it explicit.

Reviewed By: PeteTheHeat

Differential Revision: D22767174

fbshipit-source-id: 04d5562e381912233b9c14e8156cbf145288f063
2020-07-28 12:00:57 -07:00
..
__tests__
Back out "Upgrade Prettier from 1.17 to 2.0.2."
2020-03-24 21:47:35 -07:00
convertRequestBody.js
Exact-by-default codemod for react-native-github
2019-11-21 09:42:57 -08:00
fetch.js
Use fetch as a polyfill
2019-06-06 11:34:11 -07:00
FormData.js
Migrate large amount of modules to flow strict and strict-local
2020-07-22 09:46:16 -07:00
NativeNetworkingAndroid.js
TM JS: Revert to import from TurboModuleRegistry.js
2019-11-08 11:44:16 -08:00
NativeNetworkingIOS.js
TM JS: Revert to import from TurboModuleRegistry.js
2019-11-08 11:44:16 -08:00
RCTDataRequestHandler.h
Tidy up license headers [2/n]
2019-10-16 10:06:34 -07:00
RCTDataRequestHandler.mm
Make RCTDataRequestHandler, RCTFileRequestHandler, and RCTHTTPRequestHandler TurboModule-compatible
2019-11-04 16:07:25 -08:00
RCTFileRequestHandler.h
Tidy up license headers [2/n]
2019-10-16 10:06:34 -07:00
RCTFileRequestHandler.mm
Make RCTDataRequestHandler, RCTFileRequestHandler, and RCTHTTPRequestHandler TurboModule-compatible
2019-11-04 16:07:25 -08:00
RCTHTTPRequestHandler.h
Tidy up license headers [2/n]
2019-10-16 10:06:34 -07:00
RCTHTTPRequestHandler.mm
Make RCTDataRequestHandler, RCTFileRequestHandler, and RCTHTTPRequestHandler TurboModule-compatible
2019-11-04 16:07:25 -08:00
RCTNetworking.android.js
EventEmitter: Import {Native,RCTDevice}EventEmitter
2020-06-27 02:18:10 -07:00
RCTNetworking.h
Tidy up license headers [2/n]
2019-10-16 10:06:34 -07:00
RCTNetworking.ios.js
Migrate large amount of modules to flow strict and strict-local
2020-07-22 09:46:16 -07:00
RCTNetworking.mm
Part 2: Update ObjC++ codegen classes to use ObjCTurboModule::InitParams
2020-04-16 17:29:55 -07:00
RCTNetworkPlugins.h
Make RCTDataRequestHandler, RCTFileRequestHandler, and RCTHTTPRequestHandler TurboModule-compatible
2019-11-04 16:07:25 -08:00
RCTNetworkPlugins.mm
Make RCTDataRequestHandler, RCTFileRequestHandler, and RCTHTTPRequestHandler TurboModule-compatible
2019-11-04 16:07:25 -08:00
RCTNetworkTask.h
Tidy up license headers [2/n]
2019-10-16 10:06:34 -07:00
RCTNetworkTask.mm
Remove requestToken being nil check from [RCTNetworkTask validateRequestToken]
2020-07-28 12:00:57 -07:00
React-RCTNetwork.podspec
Fix Cocoapods builds
2020-04-07 19:07:19 -07:00
XHRInterceptor.js
Back out "Upgrade Prettier from 1.17 to 2.0.2."
2020-03-24 21:47:35 -07:00
XMLHttpRequest.js
Back out "Upgrade Prettier from 1.17 to 2.0.2."
2020-03-24 21:47:35 -07:00