mirror of
https://github.com/facebook/react-native.git
synced 2025-11-01 09:14:26 +00:00
Andrei Shikov
1953f6f02e
Summary: With the `MapBuffer`-based props calculated from C++ props, there's no need to keep `rawProps` around for Android views. This change makes sure that the `rawProps` field is only initialized under the feature flag that is responsible for enabling `MapBuffer` for prop diffing, potentially decreasing memory footprint and speeding up node initialization as JS props don't have to be converted to `folly::dynamic` anymore. For layout animations, props rely on C++ values, so there's no need to update `rawProps` values either. Changelog: [Internal][Android] - Do not init `rawProps` when mapbuffer serialization is used for ViewProps. Reviewed By: mdvacca Differential Revision: D33793044 fbshipit-source-id: 35873b10d3ca8b152b25344ef2c27aff9641846f
59 lines
1.5 KiB
C++
59 lines
1.5 KiB
C++
/*
|
|
* Copyright (c) Meta Platforms, Inc. and affiliates.
|
|
*
|
|
* This source code is licensed under the MIT license found in the
|
|
* LICENSE file in the root directory of this source tree.
|
|
*/
|
|
|
|
#pragma once
|
|
|
|
#include <react/renderer/components/view/ConcreteViewShadowNode.h>
|
|
#include <react/renderer/components/view/ViewProps.h>
|
|
|
|
namespace facebook {
|
|
namespace react {
|
|
|
|
extern const char ViewComponentName[];
|
|
|
|
/**
|
|
* Implementation of the ViewProps that propagates feature flag.
|
|
*/
|
|
class ViewShadowNodeProps final : public ViewProps {
|
|
public:
|
|
ViewShadowNodeProps() = default;
|
|
ViewShadowNodeProps(
|
|
const PropsParserContext &context,
|
|
ViewShadowNodeProps const &sourceProps,
|
|
RawProps const &rawProps);
|
|
};
|
|
|
|
/*
|
|
* `ShadowNode` for <View> component.
|
|
*/
|
|
class ViewShadowNode final : public ConcreteViewShadowNode<
|
|
ViewComponentName,
|
|
ViewShadowNodeProps,
|
|
ViewEventEmitter> {
|
|
public:
|
|
static ShadowNodeTraits BaseTraits() {
|
|
auto traits = ConcreteViewShadowNode::BaseTraits();
|
|
traits.set(ShadowNodeTraits::Trait::View);
|
|
return traits;
|
|
}
|
|
|
|
ViewShadowNode(
|
|
ShadowNodeFragment const &fragment,
|
|
ShadowNodeFamily::Shared const &family,
|
|
ShadowNodeTraits traits);
|
|
|
|
ViewShadowNode(
|
|
ShadowNode const &sourceShadowNode,
|
|
ShadowNodeFragment const &fragment);
|
|
|
|
private:
|
|
void initialize() noexcept;
|
|
};
|
|
|
|
} // namespace react
|
|
} // namespace facebook
|