mirror of
https://github.com/facebook/react-native.git
synced 2025-11-01 09:14:26 +00:00
Mike Vitousek
8f5f3d159b
Summary: Flow will soon stop allowing generic types to "escape" out of the scope in which they were defined. The fix will be to add annotations to currently-unannotated variables, parameters, and function returns, so that generics don't become inputs to type inference for those positions. This diff adds new type annotations to xplat where possible to minimize the impact of this change. This diff was generated by running ``` buck run //flow/src/facebook/komodo/binaries:annotate_escaped_generics -- --write ../../xplat/js ``` from within the flow directory, and then reverting changes that led to new errors. Most changes were reverted by running: ``` facebook/flowd check --json --json-version=2 ../../xplat/js &> post-json jq -f j.jq < post-json | xargs hg revert ``` where `j.jq` is ``` def locs: [.primaryLoc.source, (select(.rootLoc.source != null) | .rootLoc.source), .referenceLocs[].source ] | unique; [.errors[] | locs[]] | unique | .[] ``` Changelog: [Internal] Reviewed By: panagosg7 Differential Revision: D24006427 fbshipit-source-id: 0cd6ec8a9611d8b1e9b14c54f9fffd2d7de2fd9e