Facebook/react-native
1
0
Fork 0
mirror of https://github.com/facebook/react-native.git synced 2025-11-01 09:14:26 +00:00
Code Issues Packages Projects Releases Wiki Activity
Files
03174f1cadad92e700fbdd46d94dc63395b88589
react-native/ReactAndroid/src/main/java/com/facebook/react/bridge
T
History
Joshua Gross 03174f1cad Call stopSurface when ReactRootView is unregistered 
Summary:
In the past, in Fabric (Android), we never called stopSurface. Ever! This is bad for memory and can cause other issues, so... let's not do that.

Instead, when the ReactRootView is being torn down, we check the View ID to see if it's a Fabric RootView, and if it is, we call Fabric's stopSurface method.

Fabric stopSurface only has impact on (1) Fabric mount instructions being executed after that point and (2) tells JS to stop running the surface, on the JS thread, asynchronously.

Anecdotally it looks like all the MountItems involved in deleting and removing views from the hierarchy are executed before stopSurface is called.

Changelog: [Internal]

Reviewed By: mdvacca

Differential Revision: D21965837

fbshipit-source-id: 5169c5a1e339fd9e016ae1234d8389b2bd30be70
2020-06-09 23:23:10 -07:00
..
queue
Remove NativeRunnableDeprecated (#27529)
2019-12-17 13:23:59 -08:00
ActivityEventListener.java
Tidy up license headers [1/n]
2019-10-16 10:06:33 -07:00
Arguments.java
Daily arc lint --take GOOGLEJAVAFORMAT
2020-02-13 05:50:42 -08:00
AssertionException.java
Tidy up license headers [2/n]
2019-10-16 10:06:34 -07:00
BaseActivityEventListener.java
Tidy up license headers [1/n]
2019-10-16 10:06:33 -07:00
BaseJavaModule.java
Tidy up license headers [2/n]
2019-10-16 10:06:34 -07:00
bridge.pro
RN: Missing Copyright Headers
2018-10-31 01:37:26 -07:00
BUCK
use xplat BUCK attribution
2020-05-15 21:55:52 -07:00
Callback.java
Tidy up license headers [2/n]
2019-10-16 10:06:34 -07:00
CallbackImpl.java
Tidy up license headers [2/n]
2019-10-16 10:06:34 -07:00
CatalystInstance.java
Expose RuntimeExecutor on CatalystInstance (#28851)
2020-05-08 16:13:42 -07:00
CatalystInstanceImpl.java
Remove TurboModule debug logs
2020-06-02 20:11:53 -07:00
ColorPropConverter.java
PlatformColor implementations for iOS and Android (#27908)
2020-03-02 15:12:09 -08:00
ContextBaseJavaModule.java
Tidy up license headers [2/n]
2019-10-16 10:06:34 -07:00
CxxCallbackImpl.java
Tidy up license headers [1/n]
2019-10-16 10:06:33 -07:00
CxxModuleWrapper.java
Tidy up license headers [1/n]
2019-10-16 10:06:33 -07:00
CxxModuleWrapperBase.java
Tidy up license headers [1/n]
2019-10-16 10:06:33 -07:00
DefaultNativeModuleCallExceptionHandler.java
Tidy up license headers [2/n]
2019-10-16 10:06:34 -07:00
Dynamic.java
Tidy up license headers [2/n]
2019-10-16 10:06:34 -07:00
DynamicFromArray.java
Tidy up license headers [2/n]
2019-10-16 10:06:34 -07:00
DynamicFromMap.java
Tidy up license headers [2/n]
2019-10-16 10:06:34 -07:00
DynamicFromObject.java
Tidy up license headers [2/n]
2019-10-16 10:06:34 -07:00
FallbackJSBundleLoader.java
Tidy up license headers [2/n]
2019-10-16 10:06:34 -07:00
GuardedAsyncTask.java
Tidy up license headers [2/n]
2019-10-16 10:06:34 -07:00
GuardedResultAsyncTask.java
Tidy up license headers [1/n]
2019-10-16 10:06:33 -07:00
GuardedRunnable.java
Tidy up license headers [1/n]
2019-10-16 10:06:33 -07:00
Inspector.java
Tidy up license headers [1/n]
2019-10-16 10:06:33 -07:00
InvalidIteratorException.java
Tidy up license headers [2/n]
2019-10-16 10:06:34 -07:00
JavaJSExecutor.java
Split loadApplicationScript into initializeRuntime and loadBundle (#27844)
2020-04-01 17:52:39 -07:00
JavaMethodWrapper.java
Tidy up license headers [2/n]
2019-10-16 10:06:34 -07:00
JavaModuleWrapper.java
Tidy up license headers [2/n]
2019-10-16 10:06:34 -07:00
JavaOnlyArray.java
Tidy up license headers [2/n]
2019-10-16 10:06:34 -07:00
JavaOnlyMap.java
Tidy up license headers [2/n]
2019-10-16 10:06:34 -07:00
JavaScriptContextHolder.java
Tidy up license headers [1/n]
2019-10-16 10:06:33 -07:00
JavaScriptExecutor.java
Tidy up license headers [2/n]
2019-10-16 10:06:34 -07:00
JavaScriptExecutorFactory.java
Tidy up license headers [2/n]
2019-10-16 10:06:34 -07:00
JavaScriptModule.java
Tidy up license headers [2/n]
2019-10-16 10:06:34 -07:00
JavaScriptModuleRegistry.java
Use JavaScriptModuleRegistry.getJSModuleName()
2020-02-05 15:26:11 -08:00
JSApplicationCausedNativeException.java
Tidy up license headers [2/n]
2019-10-16 10:06:34 -07:00
JSApplicationIllegalArgumentException.java
Tidy up license headers [2/n]
2019-10-16 10:06:34 -07:00
JSBundleLoader.java
Tidy up license headers [2/n]
2019-10-16 10:06:34 -07:00
JSBundleLoaderDelegate.java
Tidy up license headers [2/n]
2019-10-16 10:06:34 -07:00
JSCJavaScriptExecutor.java
Tidy up license headers [2/n]
2019-10-16 10:06:34 -07:00
JSCJavaScriptExecutorFactory.java
Tidy up license headers [2/n]
2019-10-16 10:06:34 -07:00
JSIModule.java
Tidy up license headers [2/n]
2019-10-16 10:06:34 -07:00
JSIModuleHolder.java
Tidy up license headers [2/n]
2019-10-16 10:06:34 -07:00
JSIModulePackage.java
Tidy up license headers [2/n]
2019-10-16 10:06:34 -07:00
JSIModuleProvider.java
Tidy up license headers [2/n]
2019-10-16 10:06:34 -07:00
JSIModuleRegistry.java
Tidy up license headers [2/n]
2019-10-16 10:06:34 -07:00
JSIModuleSpec.java
Tidy up license headers [2/n]
2019-10-16 10:06:34 -07:00
JSIModuleType.java
Tidy up license headers [2/n]
2019-10-16 10:06:34 -07:00
JSInstance.java
Tidy up license headers [2/n]
2019-10-16 10:06:34 -07:00
JsonWriterHelper.java
Tidy up license headers [2/n]
2019-10-16 10:06:34 -07:00
LifecycleEventListener.java
Tidy up license headers [2/n]
2019-10-16 10:06:34 -07:00
MemoryPressure.java
Tidy up license headers [1/n]
2019-10-16 10:06:33 -07:00
MemoryPressureListener.java
Tidy up license headers [1/n]
2019-10-16 10:06:33 -07:00
ModuleHolder.java
Tidy up license headers [1/n]
2019-10-16 10:06:33 -07:00
ModuleSpec.java
Tidy up license headers [2/n]
2019-10-16 10:06:34 -07:00
NativeArgumentsParseException.java
Tidy up license headers [2/n]
2019-10-16 10:06:34 -07:00
NativeArray.java
Tidy up license headers [2/n]
2019-10-16 10:06:34 -07:00
NativeArrayInterface.java
Tidy up license headers [2/n]
2019-10-16 10:06:34 -07:00
NativeMap.java
Tidy up license headers [2/n]
2019-10-16 10:06:34 -07:00
NativeModule.java
Tidy up license headers [2/n]
2019-10-16 10:06:34 -07:00
NativeModuleCallExceptionHandler.java
Tidy up license headers [2/n]
2019-10-16 10:06:34 -07:00
NativeModuleRegistry.java
Tidy up license headers [2/n]
2019-10-16 10:06:34 -07:00
NoSuchKeyException.java
Tidy up license headers [2/n]
2019-10-16 10:06:34 -07:00
NotThreadSafeBridgeIdleDebugListener.java
Tidy up license headers [2/n]
2019-10-16 10:06:34 -07:00
ObjectAlreadyConsumedException.java
Tidy up license headers [2/n]
2019-10-16 10:06:34 -07:00
OnBatchCompleteListener.java
Tidy up license headers [2/n]
2019-10-16 10:06:34 -07:00
PerformanceCounter.java
Tidy up license headers [2/n]
2019-10-16 10:06:34 -07:00
Promise.java
Tidy up license headers [2/n]
2019-10-16 10:06:34 -07:00
PromiseImpl.java
Tidy up license headers [2/n]
2019-10-16 10:06:34 -07:00
ProxyJavaScriptExecutor.java
Tidy up license headers [2/n]
2019-10-16 10:06:34 -07:00
ReactApplicationContext.java
Clean up unused functions on ReactContext
2019-12-03 11:33:00 -08:00
ReactBridge.java
Tidy up license headers [2/n]
2019-10-16 10:06:34 -07:00
ReactCallback.java
Tidy up license headers [2/n]
2019-10-16 10:06:34 -07:00
ReactContext.java
Part 1: Make CatalystInstanceImpl.getNativeModule Nullable
2020-04-28 12:18:17 -07:00
ReactContextBaseJavaModule.java
Check bridgeless mode in getReactApplicationContextIfActiveOrWarn
2019-12-17 18:38:57 -08:00
ReactMarker.java
Tidy up license headers [1/n]
2019-10-16 10:06:33 -07:00
ReactMarkerConstants.java
Tidy up license headers [1/n]
2019-10-16 10:06:33 -07:00
ReactMethod.java
Tidy up license headers [2/n]
2019-10-16 10:06:34 -07:00
ReactModuleWithSpec.java
Tidy up license headers [2/n]
2019-10-16 10:06:34 -07:00
reactnative.pro
RN: Missing Copyright Headers
2018-10-31 01:37:26 -07:00
ReactNoCrashSoftException.java
Only retry ViewCommand mount items if exception is marked as "Retryable"
2020-03-19 23:02:04 -07:00
ReactSoftException.java
Tidy up license headers [1/n]
2019-10-16 10:06:33 -07:00
ReadableArray.java
Tidy up license headers [2/n]
2019-10-16 10:06:34 -07:00
ReadableMap.java
Tidy up license headers [2/n]
2019-10-16 10:06:34 -07:00
ReadableMapKeySetIterator.java
Tidy up license headers [2/n]
2019-10-16 10:06:34 -07:00
ReadableNativeArray.java
Tidy up license headers [2/n]
2019-10-16 10:06:34 -07:00
ReadableNativeMap.java
Tidy up license headers [2/n]
2019-10-16 10:06:34 -07:00
ReadableType.java
Tidy up license headers [2/n]
2019-10-16 10:06:34 -07:00
RetryableMountingLayerException.java
Only retry ViewCommand mount items if exception is marked as "Retryable"
2020-03-19 23:02:04 -07:00
RuntimeExecutor.java
Create JRuntimeExecutor (#28779)
2020-04-28 17:56:44 -07:00
SoftAssertions.java
UiThreadUtil.assertX should only throw in DEBUG mode
2019-11-05 15:36:29 -08:00
Systrace.java
Tidy up license headers [1/n]
2019-10-16 10:06:33 -07:00
UIManager.java
Call stopSurface when ReactRootView is unregistered
2020-06-09 23:23:10 -07:00
UIManagerListener.java
Android Animated timing: interface-only
2020-05-26 11:39:28 -07:00
UiThreadUtil.java
Tidy up license headers [2/n]
2019-10-16 10:06:34 -07:00
UnexpectedNativeTypeException.java
Tidy up license headers [2/n]
2019-10-16 10:06:34 -07:00
WindowFocusChangeListener.java
Tidy up license headers [1/n]
2019-10-16 10:06:33 -07:00
WritableArray.java
Tidy up license headers [2/n]
2019-10-16 10:06:34 -07:00
WritableMap.java
Tidy up license headers [2/n]
2019-10-16 10:06:34 -07:00
WritableNativeArray.java
Tidy up license headers [2/n]
2019-10-16 10:06:34 -07:00
WritableNativeMap.java
Tidy up license headers [2/n]
2019-10-16 10:06:34 -07:00