mirror of
https://github.com/facebook/react-native.git
synced 2025-11-01 09:14:26 +00:00
Summary: Currently we observed many iOS app crashes caused by the `[RCTFileRequestHanlder invalidate]` method, just as the below screenshot. <img width="1008" alt="image" src="https://github.com/user-attachments/assets/d2d6714f-63d9-40ae-8de5-742cfe718a36" /> ## Changelog: <!-- Help reviewers and the release process by writing your own changelog entry. Pick one each for the category and type tags: [IOS] [FIXED] - app crash caused by the `[RCTFileRequestHanlder invalidate]` method For more details, see: https://reactnative.dev/contributing/changelogs-in-pull-requests --> [IOS] [FIXED] - app crash caused by the `[RCTFileRequestHanlder invalidate]` method Pull Request resolved: https://github.com/facebook/react-native/pull/48350 Test Plan: I am not able to reproduce this issue locally either, so the changes in this PR are totally from my inference, I am not sure if it really makes sense, so please help take a deeper look, thanks. Reviewed By: javache Differential Revision: D69751695 Pulled By: cipolleschi fbshipit-source-id: aa4654a30f5dfac99b72ed1bda0dae1e0dc881c9
115 lines
3.3 KiB
Plaintext
115 lines
3.3 KiB
Plaintext
/*
|
|
* Copyright (c) Meta Platforms, Inc. and affiliates.
|
|
*
|
|
* This source code is licensed under the MIT license found in the
|
|
* LICENSE file in the root directory of this source tree.
|
|
*/
|
|
|
|
#import <React/RCTFileRequestHandler.h>
|
|
|
|
#import <mutex>
|
|
|
|
#import <MobileCoreServices/MobileCoreServices.h>
|
|
|
|
#import <React/RCTUtils.h>
|
|
#import <ReactCommon/RCTTurboModule.h>
|
|
|
|
#import "RCTNetworkPlugins.h"
|
|
|
|
@interface RCTFileRequestHandler () <RCTTurboModule>
|
|
@end
|
|
|
|
@implementation RCTFileRequestHandler {
|
|
NSOperationQueue *_fileQueue;
|
|
std::mutex _operationHandlerMutexLock;
|
|
}
|
|
|
|
RCT_EXPORT_MODULE()
|
|
|
|
- (void)invalidate
|
|
{
|
|
std::lock_guard<std::mutex> lock(_operationHandlerMutexLock);
|
|
if (_fileQueue) {
|
|
for (NSOperation *operation in _fileQueue.operations) {
|
|
if (!operation.isCancelled && !operation.isFinished) {
|
|
[operation cancel];
|
|
}
|
|
}
|
|
_fileQueue = nil;
|
|
}
|
|
}
|
|
|
|
- (BOOL)canHandleRequest:(NSURLRequest *)request
|
|
{
|
|
return [request.URL.scheme caseInsensitiveCompare:@"file"] == NSOrderedSame && !RCTIsBundleAssetURL(request.URL);
|
|
}
|
|
|
|
- (NSOperation *)sendRequest:(NSURLRequest *)request withDelegate:(id<RCTURLRequestDelegate>)delegate
|
|
{
|
|
std::lock_guard<std::mutex> lock(_operationHandlerMutexLock);
|
|
// Lazy setup
|
|
if (!_fileQueue) {
|
|
_fileQueue = [NSOperationQueue new];
|
|
_fileQueue.maxConcurrentOperationCount = 4;
|
|
}
|
|
|
|
__weak __block NSBlockOperation *weakOp;
|
|
__block NSBlockOperation *op = [NSBlockOperation blockOperationWithBlock:^{
|
|
// Get content length
|
|
NSError *error = nil;
|
|
NSFileManager *fileManager = [NSFileManager new];
|
|
NSDictionary<NSString *, id> *fileAttributes = [fileManager attributesOfItemAtPath:request.URL.path error:&error];
|
|
if (!fileAttributes) {
|
|
[delegate URLRequest:weakOp didCompleteWithError:error];
|
|
return;
|
|
}
|
|
|
|
// Get mime type
|
|
NSString *fileExtension = [request.URL pathExtension];
|
|
NSString *UTI = (__bridge_transfer NSString *)UTTypeCreatePreferredIdentifierForTag(
|
|
kUTTagClassFilenameExtension, (__bridge CFStringRef)fileExtension, NULL);
|
|
NSString *contentType =
|
|
(__bridge_transfer NSString *)UTTypeCopyPreferredTagWithClass((__bridge CFStringRef)UTI, kUTTagClassMIMEType);
|
|
|
|
// Send response
|
|
NSURLResponse *response = [[NSURLResponse alloc] initWithURL:request.URL
|
|
MIMEType:contentType
|
|
expectedContentLength:[fileAttributes[NSFileSize] ?: @-1 integerValue]
|
|
textEncodingName:nil];
|
|
|
|
[delegate URLRequest:weakOp didReceiveResponse:response];
|
|
|
|
// Load data
|
|
NSData *data = [NSData dataWithContentsOfURL:request.URL options:NSDataReadingMappedIfSafe error:&error];
|
|
if (data) {
|
|
[delegate URLRequest:weakOp didReceiveData:data];
|
|
}
|
|
[delegate URLRequest:weakOp didCompleteWithError:error];
|
|
}];
|
|
|
|
weakOp = op;
|
|
[_fileQueue addOperation:op];
|
|
return op;
|
|
}
|
|
|
|
- (void)cancelRequest:(NSOperation *)op
|
|
{
|
|
std::lock_guard<std::mutex> lock(_operationHandlerMutexLock);
|
|
if (!op.isCancelled && !op.isFinished) {
|
|
[op cancel];
|
|
}
|
|
}
|
|
|
|
- (std::shared_ptr<facebook::react::TurboModule>)getTurboModule:
|
|
(const facebook::react::ObjCTurboModule::InitParams &)params
|
|
{
|
|
return nullptr;
|
|
}
|
|
|
|
@end
|
|
|
|
Class RCTFileRequestHandlerCls(void)
|
|
{
|
|
return RCTFileRequestHandler.class;
|
|
}
|