mirror of
https://github.com/facebook/react-native.git
synced 2025-11-01 09:14:26 +00:00
8131b7bb7b
Summary: This is my proposal for fixing `use_frameworks!` compatibility without breaking all `<React/*>` imports I outlined in https://github.com/facebook/react-native/pull/25393#issuecomment-508457700. If accepted, it will fix https://github.com/facebook/react-native/issues/25349. It builds on the changes I made in https://github.com/facebook/react-native/pull/25496 by ensuring each podspec has a unique value for `header_dir` so that framework imports do not conflict. Every podspec which should be included in the `<React/*>` namespace now includes it's headers from `React-Core.podspec`. The following pods can still be imported with `<React/*>` and so should not have breaking changes: `React-ART`,`React-DevSupport`, `React-CoreModules`, `React-RCTActionSheet`, `React-RCTAnimation`, `React-RCTBlob`, `React-RCTImage`, `React-RCTLinking`, `React-RCTNetwork`, `React-RCTPushNotification`, `React-RCTSettings`, `React-RCTText`, `React-RCTSettings`, `React-RCTVibration`, `React-RCTWebSocket` . There are still a few breaking changes which I hope will be acceptable: - `React-Core.podspec` has been moved to the root of the project. Any `Podfile` that references it will need to update the path. - ~~`React-turbomodule-core`'s headers now live under `<turbomodule/*>`~~ Replaced by https://github.com/facebook/react-native/pull/25619#issuecomment-511091823. - ~~`React-turbomodulesamples`'s headers now live under `<turbomodulesamples/*>`~~ Replaced by https://github.com/facebook/react-native/pull/25619#issuecomment-511091823. - ~~`React-TypeSaferty`'s headers now live under `<TypeSafety/*>`~~ Replaced by https://github.com/facebook/react-native/pull/25619#issuecomment-511040967. - ~~`React-jscallinvoker`'s headers now live under `<jscallinvoker/*>`~~ Replaced by https://github.com/facebook/react-native/pull/25619#issuecomment-511091823. - Each podspec now uses `s.static_framework = true`. This means that a minimum of CocoaPods 1.5 ([released in April 2018](http://blog.cocoapods.org/CocoaPods-1.5.0/)) is now required. This is needed so that the ` __has_include` conditions can still work when frameworks are enabled. Still to do: - ~~Including `React-turbomodule-core` with `use_frameworks!` enabled causes the C++ import failures we saw in https://github.com/facebook/react-native/issues/25349. I'm sure it will be possible to fix this but I need to dig deeper (perhaps a custom modulemap would be needed).~~ Addressed by https://github.com/facebook/react-native/pull/25619/commits/33573511f02f3502a28bad48e085e9a4b8608302. - I haven't got Fabric working yet. I wonder if it would be acceptable to move Fabric out of the `<React/*>` namespace since it is new? � ## Changelog [iOS] [Fixed] - Fixed compatibility with CocoaPods frameworks. Pull Request resolved: https://github.com/facebook/react-native/pull/25619 Test Plan: ### FB ``` buck build catalyst ``` ### Sample Project Everything should work exactly as before, where `use_frameworks!` is not in `Podfile`s. I have a branch on my [sample project](https://github.com/jtreanor/react-native-cocoapods-frameworks) here which has `use_frameworks!` in its `Podfile` to demonstrate this is fixed. You can see that it works with these steps: 1. `git clone git@github.com:jtreanor/react-native-cocoapods-frameworks.git` 2. `git checkout fix-frameworks-subspecs` 3. `cd ios && pod install` 4. `cd .. && react-native run-ios` The sample app will build and run successfully. To see that it still works without frameworks, remove `use_frameworks!` from the `Podfile` and do steps 3 and 4 again. ### RNTesterPods `RNTesterPodsPods` can now work with or without `use_frameworks!`. 1. Go to the `RNTester` directory and run `pod install`. 2. Run the tests in `RNTesterPods.xcworkspace` to see that everything still works fine. 3. Uncomment the `use_frameworks!` line at the top of `RNTester/Podfile` and run `pod install` again. 4. Run the tests again and see that it still works with frameworks enabled. Reviewed By: PeteTheHeat Differential Revision: D16465247 Pulled By: PeteTheHeat fbshipit-source-id: cad837e9cced06d30cc5b372af1c65c7780b9e7a
159 lines
5.0 KiB
Objective-C
159 lines
5.0 KiB
Objective-C
/**
|
|
* Copyright (c) Facebook, Inc. and its affiliates.
|
|
*
|
|
* This source code is licensed under the MIT license found in the
|
|
* LICENSE file in the root directory of this source tree.
|
|
*/
|
|
|
|
#import <React/RCTFrameAnimation.h>
|
|
|
|
#import <UIKit/UIKit.h>
|
|
|
|
#import <React/RCTConvert.h>
|
|
#import <React/RCTDefines.h>
|
|
|
|
#import <React/RCTAnimationUtils.h>
|
|
#import <React/RCTValueAnimatedNode.h>
|
|
|
|
@interface RCTFrameAnimation ()
|
|
|
|
@property (nonatomic, strong) NSNumber *animationId;
|
|
@property (nonatomic, strong) RCTValueAnimatedNode *valueNode;
|
|
@property (nonatomic, assign) BOOL animationHasBegun;
|
|
@property (nonatomic, assign) BOOL animationHasFinished;
|
|
|
|
@end
|
|
|
|
@implementation RCTFrameAnimation
|
|
{
|
|
NSArray<NSNumber *> *_frames;
|
|
CGFloat _toValue;
|
|
CGFloat _fromValue;
|
|
CGFloat _lastPosition;
|
|
NSTimeInterval _animationStartTime;
|
|
NSTimeInterval _animationCurrentTime;
|
|
RCTResponseSenderBlock _callback;
|
|
NSInteger _iterations;
|
|
NSInteger _currentLoop;
|
|
}
|
|
|
|
- (instancetype)initWithId:(NSNumber *)animationId
|
|
config:(NSDictionary *)config
|
|
forNode:(RCTValueAnimatedNode *)valueNode
|
|
callBack:(nullable RCTResponseSenderBlock)callback;
|
|
{
|
|
if ((self = [super init])) {
|
|
_animationId = animationId;
|
|
_lastPosition = _fromValue = valueNode.value;
|
|
_valueNode = valueNode;
|
|
_callback = [callback copy];
|
|
[self resetAnimationConfig:config];
|
|
}
|
|
return self;
|
|
}
|
|
|
|
- (void)resetAnimationConfig:(NSDictionary *)config
|
|
{
|
|
NSNumber *toValue = [RCTConvert NSNumber:config[@"toValue"]] ?: @1;
|
|
NSArray<NSNumber *> *frames = [RCTConvert NSNumberArray:config[@"frames"]];
|
|
NSNumber *iterations = [RCTConvert NSNumber:config[@"iterations"]] ?: @1;
|
|
|
|
_fromValue = _lastPosition;
|
|
_toValue = toValue.floatValue;
|
|
_frames = [frames copy];
|
|
_animationStartTime = _animationCurrentTime = -1;
|
|
_animationHasFinished = iterations.integerValue == 0;
|
|
_iterations = iterations.integerValue;
|
|
_currentLoop = 1;
|
|
}
|
|
|
|
RCT_NOT_IMPLEMENTED(- (instancetype)init)
|
|
|
|
- (void)startAnimation
|
|
{
|
|
_animationStartTime = _animationCurrentTime = -1;
|
|
_animationHasBegun = YES;
|
|
}
|
|
|
|
- (void)stopAnimation
|
|
{
|
|
_valueNode = nil;
|
|
if (_callback) {
|
|
_callback(@[@{
|
|
@"finished": @(_animationHasFinished)
|
|
}]);
|
|
}
|
|
}
|
|
|
|
- (void)stepAnimationWithTime:(NSTimeInterval)currentTime
|
|
{
|
|
if (!_animationHasBegun || _animationHasFinished || _frames.count == 0) {
|
|
// Animation has not begun or animation has already finished.
|
|
return;
|
|
}
|
|
|
|
if (_animationStartTime == -1) {
|
|
_animationStartTime = _animationCurrentTime = currentTime;
|
|
}
|
|
|
|
_animationCurrentTime = currentTime;
|
|
NSTimeInterval currentDuration = (_animationCurrentTime - _animationStartTime) / RCTAnimationDragCoefficient();
|
|
|
|
// Determine how many frames have passed since last update.
|
|
// Get index of frames that surround the current interval
|
|
NSUInteger startIndex = floor(currentDuration / RCTSingleFrameInterval);
|
|
NSUInteger nextIndex = startIndex + 1;
|
|
|
|
if (nextIndex >= _frames.count) {
|
|
if (_iterations == -1 || _currentLoop < _iterations) {
|
|
// Looping, reset to the first frame value.
|
|
_animationStartTime = currentTime;
|
|
_currentLoop++;
|
|
NSNumber *firstValue = _frames.firstObject;
|
|
[self updateOutputWithFrameOutput:firstValue.doubleValue];
|
|
} else {
|
|
_animationHasFinished = YES;
|
|
// We are at the end of the animation
|
|
// Update value and flag animation has ended.
|
|
NSNumber *finalValue = _frames.lastObject;
|
|
[self updateOutputWithFrameOutput:finalValue.doubleValue];
|
|
}
|
|
return;
|
|
}
|
|
|
|
// Do a linear remap of the two frames to safeguard against variable framerates
|
|
NSNumber *fromFrameValue = _frames[startIndex];
|
|
NSNumber *toFrameValue = _frames[nextIndex];
|
|
NSTimeInterval fromInterval = startIndex * RCTSingleFrameInterval;
|
|
NSTimeInterval toInterval = nextIndex * RCTSingleFrameInterval;
|
|
|
|
// Interpolate between the individual frames to ensure the animations are
|
|
//smooth and of the proper duration regardless of the framerate.
|
|
CGFloat frameOutput = RCTInterpolateValue(currentDuration,
|
|
fromInterval,
|
|
toInterval,
|
|
fromFrameValue.doubleValue,
|
|
toFrameValue.doubleValue,
|
|
EXTRAPOLATE_TYPE_EXTEND,
|
|
EXTRAPOLATE_TYPE_EXTEND);
|
|
|
|
[self updateOutputWithFrameOutput:frameOutput];
|
|
}
|
|
|
|
- (void)updateOutputWithFrameOutput:(CGFloat)frameOutput
|
|
{
|
|
CGFloat outputValue = RCTInterpolateValue(frameOutput,
|
|
0,
|
|
1,
|
|
_fromValue,
|
|
_toValue,
|
|
EXTRAPOLATE_TYPE_EXTEND,
|
|
EXTRAPOLATE_TYPE_EXTEND);
|
|
|
|
_lastPosition = outputValue;
|
|
_valueNode.value = outputValue;
|
|
[_valueNode setNeedsUpdate];
|
|
}
|
|
|
|
@end
|