mirror of
https://github.com/facebook/react-native.git
synced 2025-11-01 09:14:26 +00:00
aamalricandFacebook Github Bot
00c8b3cd09
Summary: ScrollView doesn't handle the scrollEnabled property using dpad. When set to false, the directionnal pad still allows to scroll in the view. ## Changelog [ANDROID] [ADDED] - Prevent scrollView to scroll with dpad when scrollEnabled property is set to false. Pull Request resolved: https://github.com/facebook/react-native/pull/25309 Test Plan: Add P67680731 to Playground.js and start the Catalyst Android app: ```buck install -r catalyst``` Send the following adb commands to the device/emulator: ```adb shell input keyevent DPAD_RIGHT_LEFT``` ```adb shell input keyevent DPAD_RIGHT_RIGHT``` Make sure the ScrollView doesn't scroll to the left and right. Add ```horizontal={true}``` to ScrollView and send the following adb commands to the device/emulator: ```adb shell input keyevent DPAD_RIGHT_TOP``` ```adb shell input keyevent DPAD_RIGHT_BOTTOM``` Make sure the ScrollView doesn't scroll to the top and bottom. Reviewed By: mdvacca Differential Revision: D15983785 Pulled By: makovkastar fbshipit-source-id: 678cc801a168531d71c8651b986c99ecd9da400e