mirror of
https://github.com/facebook/react-native.git
synced 2025-11-01 09:14:26 +00:00
Hailey
cdab5370af
Summary: Fixes https://github.com/facebook/react-native/issues/41988 Hopefully even if this isn't the right way to go about solving this, it at least points in the right direction for a different fix! Currently - both on Paper and Fabric - the `selectTextOnFocus` prop does not work as expected on a single line text input. It seems that if the `UITextField` has not yet become the first responder, the text will be briefly selected but then deselected immediately afterward. This can be seen in the tester when running for either Fabric or Paper (video using Fabric) https://github.com/facebook/react-native/assets/153161762/aa9c609e-6eb8-4177-a41f-32aae53c06ac Instead, we can move the `selectAll` call to `reactFocus` in `RCTBaseTextInputView` or `focus` `RCTTextInputComponentView` - both of which first call `becomeFirstResponder` - to get the expected result. ## Changelog: [IOS] [FIXED] - fix selectTextOnFocus in Fabric and non-Fabric by calling selectAll after becomeFirstResponder Pull Request resolved: https://github.com/facebook/react-native/pull/44307 Test Plan: * Test changes on RN Tester (iOS) https://pxl.cl/55kDc Reviewed By: cipolleschi Differential Revision: D56699773 Pulled By: fabriziocucci fbshipit-source-id: ed092835f3c602e2c50a4198357653a9cef942d9