mirror of
https://github.com/facebook/react-native.git
synced 2025-11-01 09:14:26 +00:00
Nick GerlemanandFacebook GitHub Bot
99f962627f
Summary: Pull Request resolved: https://github.com/facebook/react-native/pull/49960 Fixes https://github.com/facebook/react-native/issues/49106 RN legacy arch, and web, will clip inline content which appears after elipsized text. This is the correct behavior, compared to new arch, which will put it in a random place depending on the platform. `line-clamp`: https://jsfiddle.net/7xgdke1b/ `text-overflow`: https://jsfiddle.net/7xgdke1b/2/ Fabric renderer does not, funnily enough, having an `isClipped` field on `TextMeasurement::Attachment` that is never used. This change propagates state for whether an attachment is beyond elipsized area to this measurement, then when we see it, we set empty layout results with `DisplayType::None` so that we don't create native views. We don't layout child views either, but this seems to work out okay, even when removing and re-adding `numberOfLines`. Changelog: [General][Fixed] - Fix New Arch handling of inline views when text truncated Reviewed By: mdvacca Differential Revision: D70922174 fbshipit-source-id: 8c1f4aadbf53ff64ce55b44d6c7953d9b2e40bc5