Files
Joshua Gross d1d11c7639 (Attempt to) Fix compilation of new props parsing for MSVC
Summary:
MSVC doesn't like Clang macros. Oops!

Constraints with this bit of code:

1. I'm trying to enforce constexpr in the most obvious, intuitive way possible. Macros are ugly but a "proper" solution would result in 10x as much code that is, totally subjectively, less readable to me.
2. This is evaluating at compile-time a hash of a string which is usually used in the `case` line of a switch statement.

For now I'm just hoping that MSVC will allow us to shadow `hash` which Xcode doesn't like. We might need to add a special pragma(s) for MSVC if it still doesn't like this.

Changelog: [Internal]

Reviewed By: lyahdav

Differential Revision: D37529949

fbshipit-source-id: 9aa605a9786bf5d194819ef8dade778875ae744e
2022-06-29 16:01:24 -07:00

95 lines
4.8 KiB
C++

/*
* Copyright (c) Meta Platforms, Inc. and affiliates.
*
* This source code is licensed under the MIT license found in the
* LICENSE file in the root directory of this source tree.
*/
#pragma once
#include <react/renderer/core/RawPropsPrimitives.h>
// We need to use clang pragmas inside of a macro below,
// so we need to pull out the "if" statement here.
#if __clang__
#define CLANG_PRAGMA(s) _Pragma(s)
#else
#define CLANG_PRAGMA(s)
#endif
// Get hash at compile-time. sizeof(str) - 1 == strlen
#define CONSTEXPR_RAW_PROPS_KEY_HASH(s) \
({ \
CLANG_PRAGMA("clang diagnostic push") \
CLANG_PRAGMA("clang diagnostic ignored \"-Wshadow\"") \
constexpr RawPropsPropNameHash propNameHash = \
folly::hash::fnv32_buf(s, sizeof(s) - 1); \
propNameHash; \
CLANG_PRAGMA("clang diagnostic pop") \
})
#define RAW_PROPS_KEY_HASH(s) folly::hash::fnv32_buf(s, std::strlen(s))
// Convenience for building setProps switch statements.
// This injects `fromRawValue` into source; each file that uses
// this macro must import the proper, respective headers required.
#define RAW_SET_PROP_SWITCH_CASE(field, jsPropName, defaultValue) \
case CONSTEXPR_RAW_PROPS_KEY_HASH(jsPropName): \
fromRawValue(context, value, field, defaultValue); \
return;
// Convenience for building setProps switch statements where the field name is
// the same as the string identifier
#define RAW_SET_PROP_SWITCH_CASE_BASIC(field, defaultValue) \
RAW_SET_PROP_SWITCH_CASE(field, #field, defaultValue)
#define CASE_STATEMENT_SET_FIELD_VALUE_INDEXED( \
struct, field, fieldNameString, value) \
case CONSTEXPR_RAW_PROPS_KEY_HASH(fieldNameString): { \
if (!value.hasValue()) { \
decltype(struct) defaultValues{}; \
struct.field = defaultValues.field; \
return; \
} \
fromRawValue(context, value, struct.field); \
return; \
}
#define SET_CASCADED_RECTANGLE_CORNERS(struct, prefix, suffix, rawValue) \
CASE_STATEMENT_SET_FIELD_VALUE_INDEXED( \
struct, topLeft, prefix "TopLeft" suffix, rawValue) \
CASE_STATEMENT_SET_FIELD_VALUE_INDEXED( \
struct, topRight, prefix "TopRight" suffix, rawValue) \
CASE_STATEMENT_SET_FIELD_VALUE_INDEXED( \
struct, bottomLeft, prefix "BottomLeft" suffix, rawValue) \
CASE_STATEMENT_SET_FIELD_VALUE_INDEXED( \
struct, bottomRight, prefix "BottomRight" suffix, rawValue) \
CASE_STATEMENT_SET_FIELD_VALUE_INDEXED( \
struct, topStart, prefix "TopStart" suffix, rawValue) \
CASE_STATEMENT_SET_FIELD_VALUE_INDEXED( \
struct, topEnd, prefix "TopEnd" suffix, rawValue) \
CASE_STATEMENT_SET_FIELD_VALUE_INDEXED( \
struct, bottomStart, prefix "BottomStart" suffix, rawValue) \
CASE_STATEMENT_SET_FIELD_VALUE_INDEXED( \
struct, bottomEnd, prefix "BottomEnd" suffix, rawValue)
#define SET_CASCADED_RECTANGLE_EDGES(struct, prefix, suffix, rawValue) \
CASE_STATEMENT_SET_FIELD_VALUE_INDEXED( \
struct, left, prefix "Left" suffix, rawValue) \
CASE_STATEMENT_SET_FIELD_VALUE_INDEXED( \
struct, right, prefix "Right" suffix, rawValue) \
CASE_STATEMENT_SET_FIELD_VALUE_INDEXED( \
struct, top, prefix "Top" suffix, rawValue) \
CASE_STATEMENT_SET_FIELD_VALUE_INDEXED( \
struct, bottom, prefix "Bottom" suffix, rawValue) \
CASE_STATEMENT_SET_FIELD_VALUE_INDEXED( \
struct, start, prefix "Start" suffix, rawValue) \
CASE_STATEMENT_SET_FIELD_VALUE_INDEXED( \
struct, end, prefix "End" suffix, rawValue) \
CASE_STATEMENT_SET_FIELD_VALUE_INDEXED( \
struct, horizontal, prefix "Horizontal" suffix, rawValue) \
CASE_STATEMENT_SET_FIELD_VALUE_INDEXED( \
struct, vertical, prefix "Vertical" suffix, rawValue) \
CASE_STATEMENT_SET_FIELD_VALUE_INDEXED( \
struct, all, prefix "" suffix, rawValue)