Lorenzo Sciandra
468161232e
[0.57.4] Bump version numbers
2018-10-25 17:52:59 +01:00
Stephen Cook and Lorenzo Sciandra
ef835b52e7
Android textTransform style support ( #20572 )
...
Summary:
Issue https://github.com/facebook/react-native/issues/2088 (closed, but a bit pre-emptively imo, since Android support was skipped)
Related (merged) iOS PR https://github.com/facebook/react-native/pull/18387
Related documentation PR https://github.com/facebook/react-native-website/pull/500
The basic desire is to have a declarative mechanism to transform text content to uppercase or lowercase or titlecase ("capitalized").
Pull Request resolved: https://github.com/facebook/react-native/pull/20572
Differential Revision: D9311716
Pulled By: hramos
fbshipit-source-id: dfbb855117196958e7ae5e980700d31be07a448d
2018-10-23 09:32:15 +01:00
Eli White and Lorenzo Sciandra
581a6e8822
Add deprecation notice to SwipeableListView
...
Summary: ListView is deprecated and SwipeableListView uses ListView. Thus, it is deprecated as well.
Reviewed By: RSNara
Differential Revision: D10437408
fbshipit-source-id: a08391d5b099e74b6ec179cd940ac404b2e702f4
2018-10-23 09:31:59 +01:00
Mehdi Mulani and Lorenzo Sciandra
346309ec1c
Text: send metrics after rendering (iOS)
...
Summary: This adds a callback for <Text> to get metrics about the rendered text. It's divided by line but that could be changed to "fragments" (which makes more sense for multi-lingual). Right now by line is convenient as you frequently want to know where the first and last line end (though we could make this work with fragments I suppose).
Reviewed By: shergin
Differential Revision: D9440914
fbshipit-source-id: bb011bb7a52438380d3f604ffe7019b98c18d978
2018-10-23 09:30:49 +01:00
Emily Janzer and Lorenzo Sciandra
e27d88f108
Fix issue when inserting text at 0 when maxLength is set
...
Summary:
1. The user inserts a character ('0') at index 0. Because the range matches 0, 0, predictedText is set to that character that was inserted.
2. In textInputDidChange, it discovers a mismatch between the rendered text ('1234') and predicted text ('0')
3. This triggers textInputShouldChangeTextInRange to be called again with the 'new' text that it thinks was just added ('1234')
4. It goes to insert this text, but runs into the maxLength limit, so it gets truncated and then inserted.
(I'm not totally sure why only happens if maxLength is set - I need to look into that.)
One fix for this is to just get rid of the range check, but that'll regress #18374 . I decided to just check and see if the rendered text is empty instead of checking the range where text could be inserted, since that seems like it should properly handle both cases.
Reviewed By: shergin
Differential Revision: D10392176
fbshipit-source-id: 84fb3b6cac9b0aa25b3c1a127d43f9cdc5a1c6a8
2018-10-23 09:30:29 +01:00
Thomas BARRAS and Lorenzo Sciandra
abbad558f2
ListView requestAnimationFrame leak ( #21802 )
...
Summary:
Related to https://github.com/facebook/react-native/pull/21488
Disclaimer: I made this PR.
I think there's some requestAnimationFrame events that are not cleared on unmount because of bad use of `splice` method.
- All flow tests succeed.
- RNTester: iOS (this change should only affect iOS because calculateChildFrames is iOS only)
Show perf monitor, show ListView* screen, start scrolling. UI frame Rate is used at the beginning. When scrolling there is no drop in FPS rate.
- TODO: I'll write a load test for ListView
[GENERAL] [ENHANCEMENT] [ListView.js] - rm TimerMixin
Pull Request resolved: https://github.com/facebook/react-native/pull/21802
Differential Revision: D10391812
Pulled By: RSNara
fbshipit-source-id: 49f0b0a4641ec29bcb4cc04bd3bafb42b3842b69
2018-10-23 09:30:00 +01:00
Thomas BARRAS and Lorenzo Sciandra
c7d36a5eb9
Remove TimerMixin from ListView ( #21488 )
...
Summary:
Related to #21485
- Remove TimerMixin from ListView
- All flow tests succeed.
- RNTester: <ListView> iOS (this change should only affect iOS because calculateChildFrames is iOS only)
Show perf monitor, show ListView* screen, start scrolling. UI frame Rate is used at the beginning. When scrolling there is no drop in FPS rate.
TODO: I think a load test would be more relevant:
- Update props multiple times and scroll
[GENERAL] [ENHANCEMENT] [ListView.js] - rm TimerMixin
Pull Request resolved: https://github.com/facebook/react-native/pull/21488
Differential Revision: D10219088
Pulled By: RSNara
fbshipit-source-id: 946e4fc1319324c5bf4947a2060b18bebb6fc493
2018-10-23 09:29:50 +01:00
Andy Huang and Lorenzo Sciandra
ee2067aa5c
Fix pull to refresh refresh component clipping on Android
...
Summary: Currently the pull to refresh icon on browse feed is super cut off on Android. Expose the progressViewOffset prop from FBPullToRefresh to support offsetting the PTR component to make the component more visible.
Reviewed By: yungsters
Differential Revision: D10274679
fbshipit-source-id: 1735c4d2d98523ccc3d1ec3733465028ae33df7b
2018-10-23 09:29:39 +01:00
Andrey Lunyov and Lorenzo Sciandra
c02432293d
Do not use fbjs/emptyObject
...
Summary: Remove dependency on fbjs/emptyObject in React Native
Reviewed By: yungsters
Differential Revision: D10342631
fbshipit-source-id: 312bb545b66dd5b2132ca67bbaf91cc98a0c6c8a
2018-10-19 15:45:17 +01:00
Lorenzo Sciandra
8fd5bcc888
[0.57.3] Bump version numbers
2018-10-12 12:19:21 +01:00
Radovan Šmitala and Lorenzo Sciandra
b1aed4d376
Normalize scheme for URL on Android ( #21561 )
...
Summary:
Android requires lowercase for URL scheme. This commit https://github.com/facebook/react-native/commit/d00bdb9bb8b9b11bce900689c7e28cebd2eb0807 fixed it but on React Native side.
Because it is Android specific, it should be fixed on Android side.
Android has method to normalize url scheme: https://developer.android.com/reference/android/net/Uri.html#normalizeScheme()
Pull Request resolved: https://github.com/facebook/react-native/pull/21561
Differential Revision: D10287868
Pulled By: hramos
fbshipit-source-id: f5e474164fdb2cfd49bd8ee51da17de3f1341a9c
2018-10-12 11:38:44 +01:00
Hyunjong Lee and Lorenzo Sciandra
09178f8bb9
Resolve protocol http, https when not in lowercase ( #21396 )
...
Summary:
Thank you for sending the PR! We appreciate you spending the time to work on these changes.
Help us understand your motivation by explaining why you decided to make this change.
If this PR fixes an issue, type "Fixes #issueNumber" to automatically close the issue when the PR is merged.
_Pull requests that expand test coverage are more likely to get reviewed. Add a test case whenever possible!_
Pull Request resolved: https://github.com/facebook/react-native/pull/21396
Differential Revision: D10119630
Pulled By: RSNara
fbshipit-source-id: d0fe193eee976b9b18a2eb467b5f3af48bd7d2de
2018-10-12 11:38:38 +01:00
Eli White and Lorenzo Sciandra
c45007b771
Skip flaky Animated test
...
Summary:
This test is disabled internally and flaky in open source causing CI to fail. Skipping it for now.
Related to: https://github.com/facebook/react-native/issues/21517
Reviewed By: RSNara
Differential Revision: D10223498
fbshipit-source-id: 37a3798c0abb7de829bc5b59e02f23d8943da882
2018-10-12 11:03:20 +01:00
Tim Yung and Lorenzo Sciandra
5ec4bab51d
RN: Fix ReactNativeViewAttributes Type Bugs
...
Summary: Fixes the runtime value of `ReactNativeStyleAttributes` to correctly map to `true` instead of strings (as returned by `keyMirror`).
Reviewed By: TheSavior
Differential Revision: D10057235
fbshipit-source-id: dc855cff3a114761098ed5176b2e6e25412481dc
2018-10-12 10:57:37 +01:00
Lorenzo Sciandra
46bb737b98
Revert "[0.57.3] Bump version numbers"
...
This reverts commit 56cde24863 .
2018-10-12 10:28:20 +01:00
Mike Grabowski
56cde24863
[0.57.3] Bump version numbers
2018-10-11 23:39:41 +02:00
Radek Czemerys and Mike Grabowski
e7ea1f840c
Fix deprecation warning message in Switch
...
Summary: Pull Request resolved: https://github.com/facebook/react-native/pull/21479
Differential Revision: D10205122
Pulled By: TheSavior
fbshipit-source-id: a7bbdae3b5dd6b47c4dc995e3c2e8e40abb64f13
2018-10-11 23:13:40 +02:00
Eli White and Mike Grabowski
131db26cbd
Deprecate legacyImplementation
...
Summary: The legacy implementation doesn't provide additional functionality and has a negative impact on performance and user experience. The legacyImplementation prop is deprecated and will be removed in a future release.
Reviewed By: yungsters
Differential Revision: D10212762
fbshipit-source-id: 9b3416434ba392827b538c984c7ab4bcbe156e60
2018-10-11 23:13:28 +02:00
Eli White and Mike Grabowski
25a3cff5a7
Add Deprecation Warning to ListView
...
Summary: This component has long been deprecated in the docs. Adding a warning to the code.
Reviewed By: sahrens
Differential Revision: D10261155
fbshipit-source-id: 462ce30a97f35e52477cfc135fb50c976b56e9cb
2018-10-11 21:42:30 +02:00
Tim Yung and Mike Grabowski
2134102027
FBJS: Upgrade to ^1.0.0
...
Summary: Upgrades all dependents of `fbjs` to the latest version.
Reviewed By: mjesun
Differential Revision: D10100661
fbshipit-source-id: 2e2af616cb2b5eab560872b6c6c60ed264e986b2
2018-10-11 21:40:14 +02:00
Tim Yung and Mike Grabowski
c9948d1d36
React sync for revisions ade5e69...d836010
...
Summary:
This sync includes the following changes:
- **[d83601080](https://github.com/facebook/react/commit/d83601080 )**: Wrap retrySuspendedRoot using SchedulerTracing (#13776 ) //<Sophie Alpert>//
- **[40a521aa7](https://github.com/facebook/react/commit/40a521aa7 )**: Terminology: Functional -> Function Component (#13775 ) //<Dan Abramov>//
- **[605ab10a4](https://github.com/facebook/react/commit/605ab10a4 )**: Add envify transform to scheduler package (#13766 ) //<Michael Ridgway>//
- **[acc7f404c](https://github.com/facebook/react/commit/acc7f404c )**: Restart from root if promise pings before end of render phase (#13774 ) //<Andrew Clark>//
- **[cbc224028](https://github.com/facebook/react/commit/cbc224028 )**: fix - small misspelling (#13768 ) //<Spencer Davies>//
- **[4eabeef11](https://github.com/facebook/react/commit/4eabeef11 )**: Rename ReactSuspenseWithTestRenderer-test -> ReactSuspense-test //<Andrew Clark>//
- **[95a3e1c2e](https://github.com/facebook/react/commit/95a3e1c2e )**: Rename ReactSuspense-test -> ReactSuspenseWithNoopRenderer-test //<Andrew Clark>//
- **[96bcae9d5](https://github.com/facebook/react/commit/96bcae9d5 )**: Jest + test renderer helpers for concurrent mode (#13751 ) //<Andrew Clark>//
- **[5c783ee75](https://github.com/facebook/react/commit/5c783ee75 )**: Remove unreachable code (#13762 ) //<Heaven>//
- **[36c5d69ca](https://github.com/facebook/react/commit/36c5d69ca )**: Always warn about legacy context within StrictMode tree (#13760 ) //<Brian Vaughn>//
- **[3e9a5de88](https://github.com/facebook/react/commit/3e9a5de88 )**: UMD react-cache build (#13761 ) //<Maksim Markelov>//
- **[8315a30b9](https://github.com/facebook/react/commit/8315a30b9 )**: --save is no longer needed (#13756 ) //<Joe Cortopassi>//
- **[ce96e2df4](https://github.com/facebook/react/commit/ce96e2df4 )**: Rename simple-cache-provider to react-cache (#13755 ) //<Andrew Clark>//
- **[c5212646f](https://github.com/facebook/react/commit/c5212646f )**: Removed extra typeof checks for contextType.unstable_read (#13736 ) //<Brian Vaughn>//
- **[806eebdae](https://github.com/facebook/react/commit/806eebdae )**: Enable getDerivedStateFromError (#13746 ) //<Brian Vaughn>//
- **[a0733fe13](https://github.com/facebook/react/commit/a0733fe13 )**: pure (#13748 ) //<Andrew Clark>//
- **[4d17c3f05](https://github.com/facebook/react/commit/4d17c3f05 )**: [scheduler] Improve naive fallback version used in non-DOM environments //<Andrew Clark>//
- **[469005d87](https://github.com/facebook/react/commit/469005d87 )**: Revise `AttributeType` React Native Flow Type (#13737 ) //<Timothy Yung>//
- **[0dc0ddc1e](https://github.com/facebook/react/commit/0dc0ddc1e )**: Rename AsyncMode -> ConcurrentMode (#13732 ) //<Dominic Gannaway>//
- **[7601c3765](https://github.com/facebook/react/commit/7601c3765 )**: Ensure "addEventListener" exists on "window" for "scheduler" package (#13731 ) //<Dominic Gannaway>//
- **[d0c0ec98e](https://github.com/facebook/react/commit/d0c0ec98e )**: Added a PureComponent contextType test (#13729 ) //<Brian Vaughn>//
- **[4b68a6498](https://github.com/facebook/react/commit/4b68a6498 )**: Support class component static contextType attribute (#13728 ) //<Brian Vaughn>//
- **[f305d2a48](https://github.com/facebook/react/commit/f305d2a48 )**: [scheduler] Priority levels, continuations, and wrapped callbacks (#13720 ) //<Andrew Clark>//
- **[970a34bae](https://github.com/facebook/react/commit/970a34bae )**: Bump babel-eslint and remove flow supressions (#13727 ) //<Brian Ng>//
- **[13965b4d3](https://github.com/facebook/react/commit/13965b4d3 )**: Interaction tracking ref-counting bug fixes (WIP) (#13590 ) //<Brian Vaughn>//
- **[17e703cb9](https://github.com/facebook/react/commit/17e703cb9 )**: Restore global window.event after event dispatching (#13688 ) (#13697 ) //<Sergei Startsev>//
- **[a775a767a](https://github.com/facebook/react/commit/a775a767a )**: Remove redundant logic (#13502 ) //<Heaven>//
- **[e1a067dea](https://github.com/facebook/react/commit/e1a067dea )**: Fix circular dependency in TracingSubscriptions (#13689 ) //<Maksim Markelov>//
- **[518812eeb](https://github.com/facebook/react/commit/518812eeb )**: Clarify comment (#13684 ) //<Heaven>//
- **[eeb817785](https://github.com/facebook/react/commit/eeb817785 )**: Remove some old files from stats //<Dan>//
- **[7ea3ca1d1](https://github.com/facebook/react/commit/7ea3ca1d1 )**: Rename schedule to scheduler (#13683 ) //<Dan Abramov>//
- **[bec2ddaf1](https://github.com/facebook/react/commit/bec2ddaf1 )**: Update bundle sizes for 16.5.2 release //<Brian Vaughn>//
- **[4269fafb0](https://github.com/facebook/react/commit/4269fafb0 )**: Updating package versions for release 16.5.2 //<Brian Vaughn>//
- **[4380f9ba1](https://github.com/facebook/react/commit/4380f9ba1 )**: Revert "Updating package versions for release 16.6.0-alpha.0" //<Brian Vaughn>//
- **[72fad84e7](https://github.com/facebook/react/commit/72fad84e7 )**: Revert "Updating dependencies for react-noop-renderer" //<Brian Vaughn>//
- **[c3fad5acf](https://github.com/facebook/react/commit/c3fad5acf )**: Revert "Update bundle sizes for 16.6.0-alpha.0 release" //<Brian Vaughn>//
- **[dd9120561](https://github.com/facebook/react/commit/dd9120561 )**: Kepp calling peformWork consistent (#13596 ) //<Heaven>//
- **[42d12317a](https://github.com/facebook/react/commit/42d12317a )**: Update bundle sizes for 16.6.0-alpha.0 release //<Brian Vaughn>//
- **[489614c4f](https://github.com/facebook/react/commit/489614c4f )**: Updating dependencies for react-noop-renderer //<Brian Vaughn>//
- **[351c9015c](https://github.com/facebook/react/commit/351c9015c )**: Updating package versions for release 16.6.0-alpha.0 //<Brian Vaughn>//
- **[a210b5b44](https://github.com/facebook/react/commit/a210b5b44 )**: Revert "Do not bind topLevelType to dispatch" (#13674 ) //<Dan Abramov>//
- **[1d8a75fef](https://github.com/facebook/react/commit/1d8a75fef )**: remove flow typings from Schedule.js (#13662 ) //<Alexey Raspopov>//
- **[d92114b98](https://github.com/facebook/react/commit/d92114b98 )**: Resubmit: Fix updateWrapper causing re-render textarea, even though their data (#13643 ) //<Nathan Hunzaker>//
- **[0c9c591bf](https://github.com/facebook/react/commit/0c9c591bf )**: Do not bind topLevelType to dispatch (#13618 ) //<Nathan Hunzaker>//
- **[9f819a5ea](https://github.com/facebook/react/commit/9f819a5ea )**: [schedule] Refactor Schedule, remove React-isms (#13582 ) //<Andrew Clark>//
- **[9c961c0a2](https://github.com/facebook/react/commit/9c961c0a2 )**: Fix some iframe edge cases (#13650 ) //<Jérôme Steunou>//
- **[8bc0bcabe](https://github.com/facebook/react/commit/8bc0bcabe )**: Add UMD production+profiling entry points (#13642 ) //<Brian Vaughn>//
- **[b488a5d9c](https://github.com/facebook/react/commit/b488a5d9c )**: Fix test comment typo (#13568 ) //<Heaven>//
- **[4bcee5621](https://github.com/facebook/react/commit/4bcee5621 )**: Rename "tracking" API to "tracing" (#13641 ) //<Brian Vaughn>//
- **[72217d081](https://github.com/facebook/react/commit/72217d081 )**: Update bundle sizes for 16.5.1 release //<Dan Abramov>//
- **[8b93a60c5](https://github.com/facebook/react/commit/8b93a60c5 )**: Updating package versions for release 16.5.1 //<Dan Abramov>//
- **[ecbf7af40](https://github.com/facebook/react/commit/ecbf7af40 )**: Enhance dev warnings for forwardRef render function (#13627 ) (#13636 ) //<Andres Rojas>//
- **[228240085](https://github.com/facebook/react/commit/228240085 )**: Delete TapEventPlugin (#13630 ) //<Dan Abramov>//
- **[a079011f9](https://github.com/facebook/react/commit/a079011f9 )**: ð Stop syncing the value attribute on inputs (behind a feature flag) (#13526 ) //<Nathan Hunzaker>//
- **[a7bd7c3c0](https://github.com/facebook/react/commit/a7bd7c3c0 )**: Allow reading default feature flags from bundle tests (#13629 ) //<Dan Abramov>//
- **[d3bbfe09c](https://github.com/facebook/react/commit/d3bbfe09c )**: Fix IE version in comment //<Dan Abramov>//
- **[1b2646a40](https://github.com/facebook/react/commit/1b2646a40 )**: Fix warning without stack for ie9 (#13620 ) //<Aliaksandr Manzhula>//
- **[e49f3ca08](https://github.com/facebook/react/commit/e49f3ca08 )**: honor displayName set on ForwardRef if available (#13615 ) //<Evan Jacobs>//
Release Notes:
[GENERAL] [FEATURE] [React] - React sync for revisions ade5e69...d836010
Reviewed By: bvaughn
Differential Revision: D10118547
fbshipit-source-id: ecde7ada80331abdc8bd7d279e0f3dbe9acde071
2018-10-11 21:39:13 +02:00
BingBing and Mike Grabowski
ce8dddb506
iOS: fix the baseline issue when displaying a mixture of different-language characters ( #19653 )
...
Summary:
This fixes #19193
Characters of different languages may have different height and different baseline, even with a same font and same font-size. When they mixed together, iOS will adjust their baselines automatically, to display a suitable view of text.
The problem is the behavior of dealing with the text-style property 'lineHeight'.
It once to be a right way at version 0.52.3, to setting a base-line-offset attribute for the whole range of the string. However, in current version, it enumerated the string, and set a different base-line-offset for different font-height characters.
And this behavior broke the baseline adjustment made by the iOS. It just make every character's baseline aligned to a same line. But it is not supposed to displaying characters of different languages like that. Chinese characters' baseline is the bottom of each, however, it is not for English characters.
So maybe it is the better way to give a same value of base-line-offset attribute for the whole string. And this PR just did that: found the biggest value of font-height in the text, and calculate the offset with that biggest value, then set to the whole string. This will keep the origin baseline adjustment for different languages' chars made by iOS.
Since I always got an error when running the snapshot test locally, I can't even pass the them with the unmodified code in master branch.
The error is "Nesting of \<View\> within \<Text\> is not currently supported."
After I comment all of the check of that error from the source code, I got a different snapshot from the reference ones. It seems that all components which will cause that error are not rendered in the reference images.
Since this PR changed the behavior of 'lineHeight' property, it's better to add a new snapshot case for the situation of different-language-characters' mixture. So maybe somebody could help me with that or maybe it should be a issue?
[IOS] [BUGFIX] [Text] - fix the baseline issue when displaying a mixture of different-language characters
Pull Request resolved: https://github.com/facebook/react-native/pull/19653
Differential Revision: D10140131
Pulled By: shergin
fbshipit-source-id: 646a9c4046d497b78a980d82a015168cf940646b
2018-10-11 21:37:46 +02:00
Mehdi Mulani and Mike Grabowski
9ae5bd0c92
Dealloc first time RCTNetInfo reachability callback
...
Summary:
@public
We're seeing a crasher where `self` on line 54 isn't an `RCTNetInfo`. The timing looks related to D9798488, so my theory is that this class is being deallocated before it resolves, and thus causes a crash.
Reviewed By: PeteTheHeat
Differential Revision: D10127341
fbshipit-source-id: 94eaba7def6b118092adcf6b4cce841ccc7d0b59
2018-10-11 21:37:32 +02:00
Hector Ramos
4a440f4018
[0.57.2] Bump version numbers
2018-10-04 13:29:30 -07:00
Hector Ramos
67dca8bbf9
Revert "[0.57.2] Bump version numbers"
...
This reverts commit b7437639df .
2018-10-04 13:29:04 -07:00
Hector Ramos
b7437639df
[0.57.2] Bump version numbers
2018-10-04 11:40:58 -07:00
Hector Ramos
e4607a4ec3
Revert "[0.57.2] Bump version numbers"
...
This reverts commit 8e810838a2 .
2018-10-04 11:40:24 -07:00
Mike Grabowski
8e810838a2
[0.57.2] Bump version numbers
2018-10-04 17:01:57 +02:00
Mike Grabowski
29fb119404
Revert "[0.57.2] Bump version numbers"
...
This reverts commit 4aec7c953e .
2018-10-04 17:01:51 +02:00
Mike Grabowski
4aec7c953e
[0.57.2] Bump version numbers
2018-10-02 14:39:35 +02:00
Mike Grabowski
63cf888161
Revert "[0.57.2] Bump version numbers"
...
This reverts commit aae1e296e9 .
2018-10-02 14:38:01 +02:00
Mike Grabowski
aae1e296e9
[0.57.2] Bump version numbers
2018-10-02 14:30:15 +02:00
Riley Dulin and Mike Grabowski
ddce06ffd1
Change new Date() to Date.now() to save on date allocations
...
Summary:
`new Date().getTime()` is equal to `Date.now()`.
`Date.now()` avoids an allocation, which can save some GC time.
This micro-optimization isn't worth it in most places, but since MessageQueue is one of the hottest pieces of JS in RN, it's worth it.
Reviewed By: javache
Differential Revision: D9972334
fbshipit-source-id: 05d78fd65304f0f27115d76b8b52db11a52c86a0
2018-10-02 14:27:00 +02:00
anthony and Mike Grabowski
9e377c3947
Fix HEAD request failing with Invalid response for blob ( #19567 )
...
Summary:
Fixes #18223
This is a fairly simple solution to what seems to be a recurring issue where certain requests that result in an empty body where JSON is expected throw an error rather than being handled gracefully. Client side error handling is not being hit as this is being thrown at a lower level.
Make a http request that results in an empty blob: ""
[INTERNAL] [BUGFIX] [XMLHttpRequest.js] - Line 262
Pull Request resolved: https://github.com/facebook/react-native/pull/19567
Differential Revision: D8314416
Pulled By: hramos
fbshipit-source-id: a17c49f3620f0abbb936f3a1c2b01aa1b64820fd
2018-10-02 14:20:36 +02:00
Hector Ramos
ba89bf4252
[0.57.1] Bump version numbers
2018-09-21 09:22:17 -07:00
Warren Knox and Lorenzo Sciandra
bf84166571
Update RCTLinkingManager.h to explicitly state the 'nullability' of parameters ( #20798 )
...
Summary:
Fixes #20797
As mentioned in #20797 when running `react-native run-ios Xcode 9.2 will complain about the nullability of pointers in `RCTLinkingManager.h`.
Pull Request resolved: https://github.com/facebook/react-native/pull/20798
Differential Revision: D9988581
Pulled By: hramos
fbshipit-source-id: e3ce7736da97d314a421c2c1ab71577864081642
2018-09-21 15:42:20 +01:00
David Vacca and Lorenzo Sciandra
8dc8071795
Expose AllowFileAccess property in WebView
...
Summary: This diff adds a new property in ReactWebView to be able to configure allowFileAccess
Reviewed By: achen1
Differential Revision: D9789466
fbshipit-source-id: 39d042ac6ef69e44f006a4c4b0c2dd900f84dbc9
2018-09-21 15:39:44 +01:00
Karan Thakkar and Lorenzo Sciandra
4ea3ac7303
fix RCTNetInfo first time connection status ( #20820 )
...
Summary:
Fixes #20804 , #8615 , https://github.com/facebook/react-native/issues/18368#issuecomment-400610022
Pull Request resolved: https://github.com/facebook/react-native/pull/20820
Differential Revision: D9798488
Pulled By: hramos
fbshipit-source-id: bd93a857b622edfbefdbd1baea746f27658f1366
2018-09-21 15:37:26 +01:00
Chun Chen and Lorenzo Sciandra
cd091e8534
Expose scrollEnabled as iOS prop for TextInput ( #20719 )
...
Summary:
Pull Request resolved: https://github.com/facebook/react-native/pull/20719
Expose scrollEnabled as iOS prop for TextInput
Reviewed By: mmmulani
Differential Revision: D9383477
fbshipit-source-id: 7e803767f6b2fafceac932fecd9dd59dc6ab5295
2018-09-21 15:37:18 +01:00
Mike Grabowski
3008c3ccba
[0.57.0] Bump version numbers
2018-09-12 13:21:38 +02:00
Eli White and Hector Ramos
7b57b8c222
Remove view configs from JS
...
Summary: Apparently different apps have different implementations of view managers that support different props. This is a problem that we will need to address. Unfortunately, this means we can't have a static config defined in JS. We will need to find another approach to this problem.
Reviewed By: sahrens
Differential Revision: D9500178
fbshipit-source-id: b591559164fcf29f5fd43e13a0f2da15011491c6
2018-09-11 16:11:16 -07:00
Eli White and Hector Ramos
967d47830b
Require that JS defined Component Attributes match Native ones in dev
...
Summary: As we move these configs to JS from native, until we have codegen that ensures everything stays up to date, this adds a dev mode check to ensure they are consistent.
Reviewed By: yungsters
Differential Revision: D9475011
fbshipit-source-id: 9d6f7b6c649229cae569d840eda3d5f7b7aa7cb2
2018-09-11 16:09:59 -07:00
Eli White and Hector Ramos
499e20766c
Put View ViewConfig in JS
...
Summary: Moving this config to native for android so we skip the native lookup for the config.
Reviewed By: yungsters
Differential Revision: D9415726
fbshipit-source-id: 84cac3f0dfa4f6ea8800de77676f1e2896ee463d
2018-09-11 16:09:49 -07:00
lukedurrant and Hector Ramos
7525f3804c
Correct RCTAnimation import ( #18050 )
...
Summary:
Fixing error
node_modules/react-native/Libraries/NativeAnimation/RCTNativeAnimatedNodesManager.h:12:9: 'RCTAnimation/RCTValueAnimatedNode.h' file not found
I'm integrating react native into an existing app through cocoa pods and similar to other PRs
PR https://github.com/facebook/react-native/pull/16192
PR https://github.com/facebook/react-native/pull/16271
PR https://github.com/facebook/react-native/pull/17764
When integrating with cocoa pods
```
pod 'React', :path => './node_modules/react-native', :subspecs => [
'Core',
'DevSupport', # Include this to enable In-App Devmenu if RN >= 0.43
'RCTText',
'RCTNetwork',
'RCTWebSocket', # needed for debugging
'RCTImage',
'RCTWebSocket',
'BatchedBridge',
'RCTLinkingIOS',
'RCTActionSheet',
'RCTAnimation'
]
```
With `RCTAnimation` being the important part for this PR.
Also note without this PR and the other PR's above if anyone is trying to integrate react native into an existing app i.e. through cocoa pods they won't be able too. I think the latest working version is
My app wouldn't build without changing this line
PR https://github.com/facebook/react-native/pull/16192
PR https://github.com/facebook/react-native/pull/16271
PR https://github.com/facebook/react-native/pull/17764
[IOS] [BREAKING] [PODS] - Fixed RCTAnimation import for integrating with cocoapods
Pull Request resolved: https://github.com/facebook/react-native/pull/18050
Differential Revision: D9235162
Pulled By: hramos
fbshipit-source-id: 426daccf8d8952658e262d5a0e4623c72c38542c
2018-09-11 15:26:54 -07:00
magicien and Hector Ramos
057d3efad8
Fix #18272 TextInput.setNativeProps({text: ''}) to work ( #18278 )
...
Summary:
Fix #18272 . Calling textInputRef.setNativeProps({text: ''}) or textInputRef.clear() should clear the text input.
- All tests of `yarn run test` are passed
- Test with [the sample app](https://github.com/magicien/react-native-textinput-clear ).
- TextInput.clear() and TextInput.setNativeProps({ text: '***' }) worked
- When clear() or setNativeProps() called, onChange/onChangeText wasn't called
- Same behavior as react 0.53.0
- When non-string values are given to `setNativeProps({text: ___})`, its behavior is the same as react 0.53.0.
- Value Type | Result
---------- | ------------
null | same as empty string ''
undefined | nothing changes
number | throw error
function | throw error
object | throw error
- When clear() or setNativeProps() called, attributed text keeps the attributes
- When `value` prop is set, the text can't be changed
- `clear()` doesn't work from the second time
- `setNativeProps({text '***'})` doesn't work from the second time
- Even when `value` prop is set, you can change the text

- `clear()` works every time
- `setNativeProps({text '****'})` works every time


- The text keeps the attributes (font family, size, color, text align)

- If `value` prop is set, the text should not be changed

[IOS] [BUGFIX] [TextInput] - Fix TextInput.clear() and TextInput.setNativeProps({text: ''}) to work
Pull Request resolved: https://github.com/facebook/react-native/pull/18278
Reviewed By: shergin
Differential Revision: D9692561
Pulled By: hramos
fbshipit-source-id: b7ce8f6740fdf666e71d6a85743331ca4805edcb
2018-09-11 15:25:23 -07:00
Tim Yung and Hector Ramos
0b30129cde
React sync for revisions bc1ea9c...ade5e69
...
Summary:
This sync includes the following changes:
- **[ade5e6928](https://github.com/facebook/react/commit/ade5e6928 )**: Manually update schedule dep in react-native-renderer (#13609 ) //<Brian Vaughn>//
- **[f260b14a8](https://github.com/facebook/react/commit/f260b14a8 )**: Fix host bailout for the persistent mode (#13611 ) //<Dan Abramov>//
- **[4a40d7624](https://github.com/facebook/react/commit/4a40d7624 )**: Fix a regression related to isReactComponent prototype check (#13608 ) //<Dan Abramov>//
- **[03ab1efeb](https://github.com/facebook/react/commit/03ab1efeb )**: Improve DX when combining react-dom/profiling and schedule/tracking (#13605 ) //<Brian Vaughn>//
- **[144328fe8](https://github.com/facebook/react/commit/144328fe8 )**: Enable no-use-before-define rule (#13606 ) //<Dan Abramov>//
- **[8a8d973d3](https://github.com/facebook/react/commit/8a8d973d3 )**: Use clearer wording //<Dan>//
- **[7d1169b2d](https://github.com/facebook/react/commit/7d1169b2d )**: Remove injectComponentTree from unstable-native-dependencies, add EventPluginHub (#13598 ) //<Brandon Dail>//
- **[8d1038fc6](https://github.com/facebook/react/commit/8d1038fc6 )**: Break up ReactDOMServerIntegrationForm-test (#13600 ) //<Nathan Hunzaker>//
- **[b87aabdfe](https://github.com/facebook/react/commit/b87aabdfe )**: Drop the year from Facebook copyright headers and the LICENSE file. (#13593 ) //<Héctor Ramos>//
- **[e417e0bf7](https://github.com/facebook/react/commit/e417e0bf7 )**: Update ReactNativeViewConfigRegistry Flow Types (#13579 ) //<Timothy Yung>//
- **[71c0e05ba](https://github.com/facebook/react/commit/71c0e05ba )**: Update bundle sizes for 16.5.0 release //<Brian Vaughn>//
- **[6255cc394](https://github.com/facebook/react/commit/6255cc394 )**: Updating package versions for release 16.5.0 //<Brian Vaughn>//
- **[28cb37978](https://github.com/facebook/react/commit/28cb37978 )**: Added a test for Profiler onRender that throws (#13575 ) //<Brian Vaughn>//
- **[8963118b3](https://github.com/facebook/react/commit/8963118b3 )**: Update react-dom README //<Dan Abramov>//
- **[b47a28cb9](https://github.com/facebook/react/commit/b47a28cb9 )**: Tweak react-dom README //<Dan Abramov>//
- **[f765f0225](https://github.com/facebook/react/commit/f765f0225 )**: When a root expires, flush all expired work in a single batch (#13503 ) //<Andrew Clark>//
- **[550dd1d2e](https://github.com/facebook/react/commit/550dd1d2e )**: Call Profiler onRender after mutations (#13572 ) //<Brian Vaughn>//
- **[34348a45b](https://github.com/facebook/react/commit/34348a45b )**: Add enableSuspenseServerRenderer feature flag (#13573 ) //<Alex Taylor>//
- **[4e744be6e](https://github.com/facebook/react/commit/4e744be6e )**: Added react-dom/profiling entry point to NPM package (#13570 ) //<Brian Vaughn>//
- **[bb627228e](https://github.com/facebook/react/commit/bb627228e )**: test: add test for fragement props (#13565 ) //<laoxiong>//
- **[9a110ebd8](https://github.com/facebook/react/commit/9a110ebd8 )**: Cleaned up 'schedule' API wrt interactions and subscriber ref: (#13561 ) //<Brian Vaughn>//
- **[fb88fd9d8](https://github.com/facebook/react/commit/fb88fd9d8 )**: Fixed schedule/tracking require for www sync script (#13556 ) //<Brian Vaughn>//
- **[955393cab](https://github.com/facebook/react/commit/955393cab )**: refactor: remove emove type judgment when defining warning props (#13553 ) //<laoxiong>//
- **[ff9399602](https://github.com/facebook/react/commit/ff9399602 )**: Fix import of ReactDOM in server env //<Dan Abramov>//
- **[281bd64c0](https://github.com/facebook/react/commit/281bd64c0 )**: Fix test file name //<Dan Abramov>//
- **[d6b59e3d2](https://github.com/facebook/react/commit/d6b59e3d2 )**: Check document.documentMode once //<Dan Abramov>//
- **[52633c84e](https://github.com/facebook/react/commit/52633c84e )**: Try/finally //<Dan Abramov>//
- **[2d4705e75](https://github.com/facebook/react/commit/2d4705e75 )**: Make IE 11 not complain about non-crucial style attribute hydration mismatch (#13534 ) //<Michał Gołębiowski-Owczarek>//
- **[25d48a728](https://github.com/facebook/react/commit/25d48a728 )**: Add gridArea to unitless CSS properties (#13550 ) //<Michał Gołębiowski-Owczarek>//
- **[877f8bc6b](https://github.com/facebook/react/commit/877f8bc6b )**: Renamed schedule UMD forwarding methods to stay in-sync with SECRET_INTERNALS change (#13549 ) //<Brian Vaughn>//
- **[0a96f9057](https://github.com/facebook/react/commit/0a96f9057 )**: Revert "Extract common logic" (#13547 ) //<Dan Abramov>//
- **[17a57adde](https://github.com/facebook/react/commit/17a57adde )**: Fix test //<Dan Abramov>//
- **[605da8b42](https://github.com/facebook/react/commit/605da8b42 )**: Extract common logic (#13535 ) //<Heaven>//
- **[69f9f4127](https://github.com/facebook/react/commit/69f9f4127 )**: Document event bubble order (#13546 ) //<Philipp>//
- **[c1ba7b8cf](https://github.com/facebook/react/commit/c1ba7b8cf )**: Remove www scheduler fork (#13545 ) //<Dan Abramov>//
- **[b473d5f86](https://github.com/facebook/react/commit/b473d5f86 )**: Secret exports: Scheduler => Schedule (#13544 ) //<Dan Abramov>//
- **[6312efc34](https://github.com/facebook/react/commit/6312efc34 )**: Tweak README and description //<Dan Abramov>//
- **[b92f947af](https://github.com/facebook/react/commit/b92f947af )**: Rename "react-scheduler" package to "schedule" (#13543 ) //<Brian Vaughn>//
- **[3c1dcd349](https://github.com/facebook/react/commit/3c1dcd349 )**: Expose less internals for TestUtils (#13539 ) //<Dan Abramov>//
- **[0b74e95d7](https://github.com/facebook/react/commit/0b74e95d7 )**: Ignore noscript content on the client (#13537 ) //<Fredrik Höglund>//
- **[8a1e3962a](https://github.com/facebook/react/commit/8a1e3962a )**: Remove negative lookbehind from Rollup plugin that broke Node <= v8.9 (#13538 ) //<Brian Vaughn>//
- **[9604d26ae](https://github.com/facebook/react/commit/9604d26ae )**: Rename ReactDOMFiber* to ReactDOM* (#13540 ) //<Dan Abramov>//
- **[28b928902](https://github.com/facebook/react/commit/28b928902 )**: Tidied up scheduling UMD API forwarding test (#13533 ) //<Brian Vaughn>//
- **[bf8aa6092](https://github.com/facebook/react/commit/bf8aa6092 )**: Added Jest test to verify UMD API-forwarding for scheduling package (#13532 ) //<Brian Vaughn>//
- **[0040efc8d](https://github.com/facebook/react/commit/0040efc8d )**: Fix a typo (#13531 ) //<Heaven>//
- **[46950a3df](https://github.com/facebook/react/commit/46950a3df )**: Interaction tracking follow up (#13509 ) //<Brian Vaughn>//
- **[0452c9bba](https://github.com/facebook/react/commit/0452c9bba )**: Add a regression test for #4618 //<Dan Abramov>//
- **[c21bab694](https://github.com/facebook/react/commit/c21bab694 )**: Add SSR regression test for #6119 //<Dan Abramov>//
- **[0d3fc9de1](https://github.com/facebook/react/commit/0d3fc9de1 )**: Add regression test for #6119 //<Dan Abramov>//
- **[0f050ad7c](https://github.com/facebook/react/commit/0f050ad7c )**: Make regression test better //<Dan Abramov>//
- **[f94342323](https://github.com/facebook/react/commit/f94342323 )**: Add a more precise regression test for #6219 //<Dan Abramov>//
- **[a3e4d0008](https://github.com/facebook/react/commit/a3e4d0008 )**: Fixed typo (#13519 ) //<Ivan>//
- **[b3d8c5376](https://github.com/facebook/react/commit/b3d8c5376 )**: [RN] Remove isMounted() false positive warning (#13511 ) //<Dan Abramov>//
- **[d2123d656](https://github.com/facebook/react/commit/d2123d656 )**: Sync React Native Flow Changes (#13513 ) //<Timothy Yung>//
- **[1c0ba70b4](https://github.com/facebook/react/commit/1c0ba70b4 )**: Fix test to use AsyncMode //<Dan>//
- **[6e4f7c788](https://github.com/facebook/react/commit/6e4f7c788 )**: Profiler integration with interaction-tracking package (#13253 ) //<Brian Vaughn>//
- **[2967ebdbe](https://github.com/facebook/react/commit/2967ebdbe )**: Remove buggy unstable_deferredUpdates() (#13488 ) //<Dan Abramov>//
- **[1664b08f0](https://github.com/facebook/react/commit/1664b08f0 )**: added flow types to setInnerHTML (#13495 ) //<Bryan M>//
- **[672e859d3](https://github.com/facebook/react/commit/672e859d3 )**: Add warning to prevent setting this.state to this.props referentially (#11658 ) //<Veekas Shrivastava>//
- **[29287f088](https://github.com/facebook/react/commit/29287f088 )**: Rename lowestPendingInteractiveExpirationTime (#13484 ) //<Heaven>//
- **[d400d6d5e](https://github.com/facebook/react/commit/d400d6d5e )**: Replace magic number 1 with ELEMENT_NODE (#13479 ) //<Heaven>//
- **[340bfd939](https://github.com/facebook/react/commit/340bfd939 )**: Rename ReactTypeOfWork to ReactWorkTags, ReactTypeOfSideEffect to ReactSideEffectTags (#13476 ) //<Sophie Alpert>//
- **[5cefd9b1e](https://github.com/facebook/react/commit/5cefd9b1e )**: Stringify <option> children (#13465 ) //<Dan Abramov>//
- **[3661616c2](https://github.com/facebook/react/commit/3661616c2 )**: Improve test harness of submit events (#13463 ) //<Philipp Spieß>//
- **[a1be17140](https://github.com/facebook/react/commit/a1be17140 )**: Revert "Rely on bubbling for submit and reset events (#13358 )" (#13462 ) //<Dan Abramov>//
- **[90c92c700](https://github.com/facebook/react/commit/90c92c700 )**: Fix warning message //<Dan Abramov>//
- **[5cb0f2bf5](https://github.com/facebook/react/commit/5cb0f2bf5 )**: Change www error shim API (#13454 ) //<Dan Abramov>//
- **[e106b8c44](https://github.com/facebook/react/commit/e106b8c44 )**: Warn about unsafe toWarnDev() nesting in tests (#12457 ) //<Brian Vaughn>//
- **[026aa9c97](https://github.com/facebook/react/commit/026aa9c97 )**: Bumped version to 16.4.3-alpha.0 (#13448 ) //<Brian Vaughn>//
- **[d670bdc6b](https://github.com/facebook/react/commit/d670bdc6b )**: Warn about ReactDOM.createPortal usage within ReactTestRenderer (#12895 ) //<Brian Vaughn>//
- **[bf1abf478](https://github.com/facebook/react/commit/bf1abf478 )**: Fix React.lazy(forwardRef) (#13446 ) //<Dan Abramov>//
- **[e8571c798](https://github.com/facebook/react/commit/e8571c798 )**: Tweak ReactTypeOfWork order (#13444 ) //<Dan Abramov>//
- **[973496b40](https://github.com/facebook/react/commit/973496b40 )**: Fix component name for React.lazy (#13443 ) //<Dan Abramov>//
- **[0beb2ee76](https://github.com/facebook/react/commit/0beb2ee76 )**: Fix incorrect legacy context for factory components (#13441 ) //<Dan Abramov>//
- **[004cb21bb](https://github.com/facebook/react/commit/004cb21bb )**: Short circuit the logic for exporting a module (#13392 ) //<Joseph>//
- **[f7a538c91](https://github.com/facebook/react/commit/f7a538c91 )**: Remove getTextContentAccessor (#13434 ) //<Brandon Dail>//
- **[d1c42d2f1](https://github.com/facebook/react/commit/d1c42d2f1 )**: Remove addEventListener check in isEventSupported (#13435 ) //<Brandon Dail>//
- **[a869f992a](https://github.com/facebook/react/commit/a869f992a )**: Remove helper object from FallbackCompositionState (#13430 ) //<Brandon Dail>//
- **[0cd8d470d](https://github.com/facebook/react/commit/0cd8d470d )**: Do not toLowerCase lists of lowercase words (#13428 ) //<Nathan Hunzaker>//
- **[b3a4cfea5](https://github.com/facebook/react/commit/b3a4cfea5 )**: Trap click events for portal root (#11927 ) //<Brandon Dail>//
- **[0da5102cf](https://github.com/facebook/react/commit/0da5102cf )**: Add interaction-tracking/subscriptions (#13426 ) //<Brian Vaughn>//
- **[4b32f525e](https://github.com/facebook/react/commit/4b32f525e )**: Refactor away some namespace imports (#13427 ) //<Dan Abramov>//
- **[d2f5c3fbc](https://github.com/facebook/react/commit/d2f5c3fbc )**: Don't diff memoized host components in completion phase (#13423 ) //<Dan Abramov>//
- **[5e0f073d5](https://github.com/facebook/react/commit/5e0f073d5 )**: interaction-tracking package (#13234 ) //<Brian Vaughn>//
- **[d14e443d6](https://github.com/facebook/react/commit/d14e443d6 )**: Resume onSelect tracking after dragend (#13422 ) //<Dan Abramov>//
- **[d5edc1f51](https://github.com/facebook/react/commit/d5edc1f51 )**: Remove unused ReactCall & ReactReturn types (#13419 ) //<Esteban>//
- **[4fa20b53b](https://github.com/facebook/react/commit/4fa20b53b )**: Don't pass instanceHandle to clones (#13125 ) //<Sebastian Markbåge>//
- **[fe959eea7](https://github.com/facebook/react/commit/fe959eea7 )**: React.lazy (#13398 ) //<Andrew Clark>//
- **[2b3082800](https://github.com/facebook/react/commit/2b3082800 )**: Fix wrong Flow return type //<Andrew Clark>//
- **[5031ebf6b](https://github.com/facebook/react/commit/5031ebf6b )**: Accept promise as element type (#13397 ) //<Andrew Clark>//
- **[77b7a660b](https://github.com/facebook/react/commit/77b7a660b )**: fix: do not reconcile children that are iterable functions (#13416 ) //<Rauno Freiberg>//
- **[cb7745c6c](https://github.com/facebook/react/commit/cb7745c6c )**: remove unused state initialValue from ReactDOMFiberSelect (#13412 ) //<Kartik Lad>//
- **[9832a1b6d](https://github.com/facebook/react/commit/9832a1b6d )**: Avoid setting empty value on reset & submit inputs (#12780 ) //<Ellis Clayton>//
- **[8862172fa](https://github.com/facebook/react/commit/8862172fa )**: Provide a better error message (#12421 ) //<Aaron Brager>//
- **[581682917](https://github.com/facebook/react/commit/581682917 )**: De-duplicate commitUpdateQueue effect commit (#13403 ) //<Ruud Burger>//
- **[1bc975d07](https://github.com/facebook/react/commit/1bc975d07 )**: Don't stop context traversal at matching consumers (#13391 ) //<Andrew Clark>//
- **[83e446e1d](https://github.com/facebook/react/commit/83e446e1d )**: Refactor ReactErrorUtils (#13406 ) //<Dan Abramov>//
- **[13fa96a54](https://github.com/facebook/react/commit/13fa96a54 )**: Improve bad ref invariant (#13408 ) //<Dan Abramov>//
- **[b2adcfba3](https://github.com/facebook/react/commit/b2adcfba3 )**: Don't suppress jsdom error reporting in our tests (#13401 ) //<Dan Abramov>//
- **[69e2a0d73](https://github.com/facebook/react/commit/69e2a0d73 )**: Ability to access window.event in development (#11687 ) (#11696 ) //<Conrad Irwin>//
- **[ade4dd3f6](https://github.com/facebook/react/commit/ade4dd3f6 )**: Fix typo in a comment (#13373 ) //<davidblnc>//
- **[2c59076d2](https://github.com/facebook/react/commit/2c59076d2 )**: Warn when "false" or "true" is the value of a boolean DOM prop (#13372 ) //<Moti Zilberman>//
- **[de5102c4c](https://github.com/facebook/react/commit/de5102c4c )**: Ignore symbols and functions in select tag (#13389 ) //<Rauno Freiberg>//
- **[d04d03e47](https://github.com/facebook/react/commit/d04d03e47 )**: Fix passing symbols and functions to textarea (#13362 ) //<Rauno Freiberg>//
- **[5550ed4a8](https://github.com/facebook/react/commit/5550ed4a8 )**: Ensure arguments are coerced to strings in warnings (#13385 ) //<Nathan Hunzaker>//
- **[3938ccc88](https://github.com/facebook/react/commit/3938ccc88 )**: Allow the user to opt out of seeing "The above error..." addendum (#13384 ) //<Dan Abramov>//
- **[47e217a77](https://github.com/facebook/react/commit/47e217a77 )**: Provide component reference in ReactDOMFiberTextarea warnings (#13361 ) //<Rauno Freiberg>//
- **[a0190f828](https://github.com/facebook/react/commit/a0190f828 )**: Rename SafeValue to ToStringValue (#13376 ) //<Philipp Spieß>//
- **[33602d435](https://github.com/facebook/react/commit/33602d435 )**: Improve soundness of ReactDOMFiberInput typings (#13367 ) //<Philipp Spieß>//
- **[ae855cec2](https://github.com/facebook/react/commit/ae855cec2 )**: Support tangentialPressure and twist fields of pointer events (#13374 ) //<Moti Zilberman>//
- **[725e499cf](https://github.com/facebook/react/commit/725e499cf )**: Rely on bubbling for submit and reset events (#13358 ) //<Philipp Spieß>//
- **[e07a3cd28](https://github.com/facebook/react/commit/e07a3cd28 )**: fix typo on inline comment (#13364 ) //<Alex Rohleder>//
- **[e0204084a](https://github.com/facebook/react/commit/e0204084a )**: Fix typos detected by github.com/client9/misspell (#13349 ) //<Kazuhiro Sera>//
- **[be4533af7](https://github.com/facebook/react/commit/be4533af7 )**: Fix hydration of non-string dangerousSetInnerHTML.__html (#13353 ) //<Dan Abramov>//
- **[0072b5998](https://github.com/facebook/react/commit/0072b5998 )**: Improve scry() error message for bad first argument (#13351 ) //<Dan Abramov>//
- **[d59b993a7](https://github.com/facebook/react/commit/d59b993a7 )**: Make nicer stacks DEV-only //<Dan>//
- **[54d86eb82](https://github.com/facebook/react/commit/54d86eb82 )**: Improve display of filenames in component stack (#12059 ) //<Billy Janitsch>//
- **[067cc24f5](https://github.com/facebook/react/commit/067cc24f5 )**: Profiler actualDuration bugfix (#13313 ) //<Brian Vaughn>//
- **[3cfab14b9](https://github.com/facebook/react/commit/3cfab14b9 )**: Treat focusable as enumerated boolean SVG attribute (#13339 ) //<Dan Abramov>//
- **[3b3b7fcbb](https://github.com/facebook/react/commit/3b3b7fcbb )**: Don't search beyond Sync roots for highest priority work (#13335 ) //<Dan Abramov>//
- **[08e32263f](https://github.com/facebook/react/commit/08e32263f )**: Fix Prettier "No parser" warning while building (#13323 ) //<Bartosz Kaszubowski>//
- **[ac7238856](https://github.com/facebook/react/commit/ac7238856 )**: Add support for auxclick event (#11571 ) //<Jason Quense>//
- **[75491a8f4](https://github.com/facebook/react/commit/75491a8f4 )**: Add a regression test for #12200 (#12242 ) //<Gareth Small>//
- **[2d0356a52](https://github.com/facebook/react/commit/2d0356a52 )**: Make sure that `select` has `multiple` attribute set to appropriate state before appending options (#13270 ) //<Dmytro Zasyadko>//
- **[b179bae0a](https://github.com/facebook/react/commit/b179bae0a )**: Enhance get derived state from props state warning - #12670 (#13317 ) //<Felix Wu>//
- **[15a8f0318](https://github.com/facebook/react/commit/15a8f0318 )**: Fix ambiguity in doc comment for isValidElement (#12826 ) //<Alexey>//
- **[5cff21207](https://github.com/facebook/react/commit/5cff21207 )**: add flowtype to function signature (#13285 ) //<ryota-murakami>//
- **[b565f4953](https://github.com/facebook/react/commit/b565f4953 )**: Minimally support iframes (nested browsing contexts) in selection event handling (#12037 ) //<Andrew Patton>//
- **[1609cf343](https://github.com/facebook/react/commit/1609cf343 )**: Warn about rendering Generators (#13312 ) //<Dan Abramov>//
- **[46d5afc54](https://github.com/facebook/react/commit/46d5afc54 )**: Replace console.error() with a throw in setTimeout() as last resort exception logging (#13310 ) //<Dan Abramov>//
- **[b3b80a483](https://github.com/facebook/react/commit/b3b80a483 )**: Inject react-art renderer into react-devtools (#13173 ) //<Yunchan Cho>//
- **[5e8beec84](https://github.com/facebook/react/commit/5e8beec84 )**: Add a regression test for #11602 //<Dan Abramov>//
- **[470377bbd](https://github.com/facebook/react/commit/470377bbd )**: Remove extraneous condition //<Dan Abramov>//
- **[6db080154](https://github.com/facebook/react/commit/6db080154 )**: Remove irrelevant suggestion of a legacy method from a warning (#13169 ) //<Ideveloper>//
- **[f60a7f722](https://github.com/facebook/react/commit/f60a7f722 )**: Fix SSR crash on a hasOwnProperty attribute (#13303 ) //<Dan Abramov>//
- **[ff41519ec](https://github.com/facebook/react/commit/ff41519ec )**: Sanitize unknown attribute names for SSR (#13302 ) //<Dan Abramov>//
- **[c44c2a216](https://github.com/facebook/react/commit/c44c2a216 )**: More helpful message when passing an element to createElement() (#13131 ) //<Dylan Cutler>//
- **[28cd494bd](https://github.com/facebook/react/commit/28cd494bd )**: Refactor validateDOMNesting a bit (#13300 ) //<Dan Abramov>//
- **[b381f4141](https://github.com/facebook/react/commit/b381f4141 )**: Allow Electrons <webview> tag (#13301 ) //<Philipp Spieß>//
- **[0182a7463](https://github.com/facebook/react/commit/0182a7463 )**: Fix a crash when using dynamic children in <option> tag (#13261 ) //<Konstantin Yakushin>//
- **[2a2ef7e0f](https://github.com/facebook/react/commit/2a2ef7e0f )**: Remove unnecessary branching from updateContextProvider (#13282 ) //<Andrew Clark>//
- **[840cb1a26](https://github.com/facebook/react/commit/840cb1a26 )**: Add an invariant to createRoot() to validate containers (#13279 ) //<Dan Abramov>//
Release Notes:
[GENERAL] [FEATURE] [React] - React sync for revisions bc1ea9c...ade5e69
Reviewed By: bvaughn
Differential Revision: D9561644
fbshipit-source-id: 3be120d7450f310af458897d54993a6c086cff2f
2018-09-11 15:25:16 -07:00
Eli White and Hector Ramos
7b1186c05a
Require all Android View Attributes are defined in flow prop types
...
Summary: This caught a few flow types that weren't defined for attributes that Android exposes. Ensuring that these stay in sync will be necessary for codegen in the future.
Reviewed By: sahrens
Differential Revision: D9444165
fbshipit-source-id: 8ee00af7b732c35d7f6befcdf79f77b73eac6a1b
2018-09-11 15:25:11 -07:00
Eli White and Hector Ramos
3ccc141115
Put View ViewConfig in JS
...
Summary: Moving this config to native for android so we skip the native lookup for the config.
Reviewed By: yungsters
Differential Revision: D9415726
fbshipit-source-id: 84cac3f0dfa4f6ea8800de77676f1e2896ee463d
2018-09-11 15:25:07 -07:00
Eli White and Hector Ramos
cbad15863d
Adding a more complete type for ReactNativeBaseComponentViewConfig
...
Summary:
As we add js view configs to our view managers, we want this type to be a little bit more strict.
This will be especially useful as we start removing certain keys (like NativeProps) which aren't actually necessary, this will make sure we remove them everywhere.
Reviewed By: yungsters
Differential Revision: D9416905
fbshipit-source-id: 6b12e38b9d56969a81ec5d4f2920298e4919f7be
2018-09-11 15:25:03 -07:00
Hector Ramos
8402c97f83
[0.57.0-rc.4] Bump version numbers
2018-09-06 16:13:03 -07:00