Facebook/react-native
1
0
Fork 0
mirror of https://github.com/facebook/react-native.git synced 2025-11-01 09:14:26 +00:00
Code Issues Packages Projects Releases Wiki Activity
16,867 Commits 541 Branches 635 Tags
0.60.2
Commit Graph
5 Commits
Author SHA1 Message Date
Valentin SherginandFacebook Github Bot 4105450c7e Fabric: Collect typenames instead of typehashes to ensure safety in ContextContainer 
Summary:
In ContextContainer, only in Debug mode, we store type information alongside with data to detect typemismatch in runtime. We used type hashes before, but seems they are not so stable and can cause some false negative crashes.
This diff changes that to store mangled typenames instead of hashes, so it should be much more reliable now.

Reviewed By: JoshuaGross

Differential Revision: D15325728

fbshipit-source-id: 3a0f1116e1336af79adb51f38ce83c37aee4cad1
 2019-05-14 10:05:54 -07:00
Valentin SherginandFacebook Github Bot 718ffe5038 Fabric: ContextContainer::findInstance returns an optional intead of throwing an exception 
Summary: Sometimes we don't know for sure if `ContextContainer` has a value or not (and that's perfectly legit use case). In those cases now we can use `findInstance` method that returns an optional intead of throwing an exeption.

Reviewed By: JoshuaGross

Differential Revision: D15039137

fbshipit-source-id: 95ba8cc7b76e37d1bd17e18c0098e56350ff3fef
 2019-04-29 21:21:11 -07:00
Valentin SherginandFacebook Github Bot 2688780394 Fabric: DEBUG-only check for type match in ContextContainer 
Summary: Additional check verifies that requested type matches the type of a stored value.

Reviewed By: mdvacca

Differential Revision: D14944336

fbshipit-source-id: 6d3a1654d9b9a64ced83f553236093f02f2c97c7
 2019-04-22 08:36:08 -07:00
Valentin SherginandFacebook Github Bot 184cfd5594 Fabric: Bunch of small changes in ContextContainer 
Summary:
So, changes:
* Correctness checks only in debug mode (codesize win?);
* `registerInstance` marked as const (because it's thread safe);
* ContextContainer::Shared also enforces constness;
* Using faster better::map;
* Using shared/RW mutex instead of regular one;
* SharedContextContainer got removed.

Reviewed By: sahrens

Differential Revision: D14920284

fbshipit-source-id: f0f8d970e7fae79a1abe3bc32827db9fd2d17e13
 2019-04-16 07:35:07 -07:00
Valentin SherginandFacebook Github Bot 792585fd48 Fabric: ContextContainer was moved to utils module 
Summary: That allows avoiding circular deps and unnecessary deps on uimanager module.

Reviewed By: PeteTheHeat

Differential Revision: D14917227

fbshipit-source-id: fe7962ee528aa659d8bd23e3e46627722551d995
 2019-04-12 15:14:48 -07:00