Facebook/react-native
1
0
Fork 0
mirror of https://github.com/facebook/react-native.git synced 2025-11-01 09:14:26 +00:00
Code Issues Packages Projects Releases Wiki Activity
16,867 Commits 541 Branches 635 Tags
0.60.2
Commit Graph
4 Commits
Author SHA1 Message Date
Rick HanlonandFacebook Github Bot 382846aefd Add viewconfig verification 
Summary: This diff adds a line to the codegen'd view configs which will check that all of the properties in the native view config are also in the JS view config we generate (note that the JS view config may have more properties than one native platform because it includes a union of both platforms)

Reviewed By: TheSavior

Differential Revision: D15278478

fbshipit-source-id: 0fef20c12265b952c69aca4e4c070a7d036db05a
 2019-05-16 10:51:06 -07:00
Eli WhiteandFacebook Github Bot d2c27f5bff Remove view configs from JS 
Summary: Apparently different apps have different implementations of view managers that support different props. This is a problem that we will need to address. Unfortunately, this means we can't have a static config defined in JS. We will need to find another approach to this problem.

Reviewed By: sahrens

Differential Revision: D9500178

fbshipit-source-id: b591559164fcf29f5fd43e13a0f2da15011491c6
 2018-08-24 14:04:09 -07:00
Eli WhiteandFacebook Github Bot 035597566f Explain why and how to keep JS<->Naitve view configs in sync 
Reviewed By: sahrens

Differential Revision: D9485764

fbshipit-source-id: 673748b0ded666b8d17ed221e1208cffefb6c859
 2018-08-24 14:04:09 -07:00
Eli WhiteandFacebook Github Bot 1329d18c6a Require that JS defined Component Attributes match Native ones in dev 
Summary: As we move these configs to JS from native, until we have codegen that ensures everything stays up to date, this adds a dev mode check to ensure they are consistent.

Reviewed By: yungsters

Differential Revision: D9475011

fbshipit-source-id: 9d6f7b6c649229cae569d840eda3d5f7b7aa7cb2
 2018-08-23 13:01:41 -07:00