react-native

Facebook/react-native

Fork 0

mirror of https://github.com/facebook/react-native.git synced 2025-11-01 09:14:26 +00:00

Commit Graph

Author	SHA1	Message	Date
Brandon Carroll	de12b98cd5	WIP: add snapshots for mocked and unmocked components (#24554 ) Summary: Per a conversation with TheSavior, in #24538, this adds snapshot tests for all components whose mocks will be addressed in that PR. Shallow and deep snapshots are included. [General] [Added] - Snapshots Pull Request resolved: https://github.com/facebook/react-native/pull/24554 Differential Revision: D15062197 Pulled By: cpojer fbshipit-source-id: 70ddbaa5e6d1d2c0fd1130ab04c458d9c49d0ee8	2019-04-24 06:52:20 -07:00
Rick Hanlon	c5b80062ea	Fix ActivityIndicator snapshot test, add toMatchShallowSnapshot Summary: This diff adds a custom matcher which will wrap a given component and shallow render it, snapshotting the result with the formatting users will see when they do the same. I also update the ActivityIndicator test to use this new strategy, and add an additional check that the displayName is set. For context see: - https://github.com/facebook/react-native/pull/21950 - https://github.com/rajivshah3/rn-broken-snapshot/blob/broken-example/__tests__/App.spec.js#L3 - https://github.com/facebook/react-native/issues/21937 Reviewed By: TheSavior Differential Revision: D13326689 fbshipit-source-id: 8ed2302a8aad12962fa2498a46d2502ccfb5c737	2018-12-05 17:23:42 -08:00
Michael Blanchard	53da585832	Fix: Add displayName to ActivityIndicator (#22417 ) Summary: Similar to #21950, this adds displayName to `ActivityIndicator`, so it displays the correct component name in snapshots instead of `Component`. Fixes #21937 (a little bit more than it was already fixed). Pull Request resolved: https://github.com/facebook/react-native/pull/22417 Differential Revision: D13205376 Pulled By: TheSavior fbshipit-source-id: 21e71d4980d159a1f33d32d83346b48257ec21d4	2018-11-26 16:49:58 -08:00

Author

SHA1

Message

Date

Brandon Carroll

de12b98cd5

WIP: add snapshots for mocked and unmocked components (#24554 )

Summary:
Per a conversation with TheSavior, in #24538, this adds snapshot tests for all components whose mocks will be addressed in that PR. Shallow and deep snapshots are included.

[General] [Added] - Snapshots
Pull Request resolved: https://github.com/facebook/react-native/pull/24554

Differential Revision: D15062197

Pulled By: cpojer

fbshipit-source-id: 70ddbaa5e6d1d2c0fd1130ab04c458d9c49d0ee8

2019-04-24 06:52:20 -07:00

Rick Hanlon

c5b80062ea

Fix ActivityIndicator snapshot test, add toMatchShallowSnapshot

Summary:
This diff adds a custom matcher which will wrap a given component and shallow render it, snapshotting the result with the formatting users will see when they do the same.

I also update the ActivityIndicator test to use this new strategy, and add an additional check that the displayName is set.

For context see:
- https://github.com/facebook/react-native/pull/21950
- https://github.com/rajivshah3/rn-broken-snapshot/blob/broken-example/__tests__/App.spec.js#L3
- https://github.com/facebook/react-native/issues/21937

Reviewed By: TheSavior

Differential Revision: D13326689

fbshipit-source-id: 8ed2302a8aad12962fa2498a46d2502ccfb5c737

2018-12-05 17:23:42 -08:00

Michael Blanchard

53da585832

Fix: Add displayName to ActivityIndicator (#22417 )

Summary:
Similar to #21950, this adds displayName to `ActivityIndicator`, so it displays the correct component name in snapshots instead of `Component`.

Fixes #21937 (a little bit more than it was already fixed).
Pull Request resolved: https://github.com/facebook/react-native/pull/22417

Differential Revision: D13205376

Pulled By: TheSavior

fbshipit-source-id: 21e71d4980d159a1f33d32d83346b48257ec21d4

2018-11-26 16:49:58 -08:00

3 Commits