3 Commits

Author	SHA1	Message	Date
Kevin Gozali	fb39d45ed5	C++ - better => butter ... Summary: Renaming the `better` utilities to `butter`: - to prevent claims that this library is superior to others - it really depends on use cases - to indicate ease of use throughout the codebase, easily spread like butter Changelog: [C++][Changed] Renaming C++ better util to butter, used by Fabric internals Reviewed By: JoshuaGross Differential Revision: D33242764 fbshipit-source-id: 26dc95d9597c61ce8e66708e44ed545e0fc5cff5	2021-12-20 22:25:14 -08:00
Alex Koller	2e3bcdfda5	Update prop generator to allow value prop name ... Summary: So I was adding a new HTTPCookie prop to our WebView native component and found that my build was [failing](https://www.internalfb.com/diff/D32602297?dst_version_fbid=338931330931416) due to "redefinition of `value`". Looks like we use the name of the prop as a variable name during codegen, and this can conflict with some other hardcoded variable names. Rather than try and come up with a better prop name, I figured we can just append some string to our codegen name to reduce the chance for conflicts. Changelog: [Internal][Changed] - Change codegen variable naming to prevent conflicts to prop names Reviewed By: JoshuaGross Differential Revision: D32967807 fbshipit-source-id: 1b3631ec783b229eddfd3c801ffbb397910fc882	2021-12-09 12:02:29 -08:00
Ramanpreet Nara	857137dc21	Create E2E tests for Component Generators ... Summary: ## Rationale - We actually don't have E2E tests that test the parser + generator together, until now. - **Documentation Value:** These tests show how the Component Spec files in [react-native-codegen/e2e/__test_fixtures__/](https://www.internalfb.com/code/fbsource/[e32a790dfa05]/xplat/js/react-native-github/packages/react-native-codegen/e2e/__test_fixtures__/components/) map to all the different types of codegen output. Changelog: [Internal] Reviewed By: sshic Differential Revision: D32081445 fbshipit-source-id: 02cd17945ef63a42381d6d4adbd0a9b0eaa2a1ef	2021-11-02 10:54:11 -07:00