react-native

Facebook/react-native

Fork 0

mirror of https://github.com/facebook/react-native.git synced 2025-11-01 09:14:26 +00:00

Commit Graph

Author	SHA1	Message	Date
Logan Daniels	9127fb51fc	Manual fixes for xplat/js/react-native-github Summary: Need to add explicit type annotations in these areas to unblock types-first architecture for Flow. These are locations the codemod could not automatically handle. I'll call out areas I need a close eye on in the comments. Reviewed By: panagosg7 Differential Revision: D16659053 fbshipit-source-id: 167dd2abe093019b128676426374c1c62cf71e7f	2019-08-09 10:11:15 -07:00
Michał Osadnik	6e73304401	Follow up e2e testing mechanism with real tests (#25680 ) Summary: Pull Request resolved: https://github.com/facebook/react-native/pull/25680 This diff's adding real e2e tests for skeleton added in previous diff. It verifies many cases for codegen, which should generate cpp code. Reviewed By: rickhanlonii Differential Revision: D16279810 fbshipit-source-id: 4441dd0ed4d95476e4071fbd654ebfb8a47ecbfc	2019-07-17 06:21:48 -07:00

Author

SHA1

Message

Date

Logan Daniels

9127fb51fc

Manual fixes for xplat/js/react-native-github

Summary:
Need to add explicit type annotations in these areas to unblock types-first architecture for Flow. These are locations the codemod could not automatically handle.

I'll call out areas I need a close eye on in the comments.

Reviewed By: panagosg7

Differential Revision: D16659053

fbshipit-source-id: 167dd2abe093019b128676426374c1c62cf71e7f

2019-08-09 10:11:15 -07:00

Michał Osadnik

6e73304401

Follow up e2e testing mechanism with real tests (#25680 )

Summary:
Pull Request resolved: https://github.com/facebook/react-native/pull/25680

This diff's adding real e2e tests for skeleton added in previous diff.

It verifies many cases for codegen, which should generate cpp code.

Reviewed By: rickhanlonii

Differential Revision: D16279810

fbshipit-source-id: 4441dd0ed4d95476e4071fbd654ebfb8a47ecbfc

2019-07-17 06:21:48 -07:00

2 Commits