Janic Duplessis and Facebook Github Bot
c47759a9ae
Fix potential retain cycles in Animated iOS
...
Summary:
Fixes potential retain cycles detected by an internal fb tool.
```
First:
__NSDictionaryM
-> RCTPropsAnimatedNode
-> _parentNodes -> __NSDictionaryM
-> RCTStyleAnimatedNode
-> _childNodes -> __NSDictionaryM
Second:
RCTScrollView
-> _eventDispatcher -> RCTEventDispatcher
-> _observers -> __NSArrayM
-> RCTNativeAnimatedModule
-> _nodesManager -> RCTNativeAnimatedNodesManager
-> _uiManager -> RCTUIManager
-> _viewRegistry -> __NSDictionaryM
-> RCTScrollView
```
First fix:
Use weak map for parent and child nodes, strong refs are managed by RCTNativeAnimatedNodesManager
Second fix:
Make RCTEventDispatcher observers a weak array and make sure we don't keep strong refs to UIManager in RCTNativeAnimatedNodesManager and RCTPropsAnimatedNode.
Tested that native animations still work in UIExplorer
[IOS] [BUGFIX] [NativeAnimated] - Fix potential retain cycles in Animated iOS
Closes https://github.com/facebook/react-native/pull/16506
Differential Revision: D6126400
Pulled By: shergin
fbshipit-source-id: 1ac5083f8ab79a806305edc23ae4796ed428f78b
2017-10-23 13:20:59 -07:00
Ryan Gomba and Facebook Github Bot 3
82dba51f1a
Modulo node
...
Summary:
This diff adds ModuloAnimatedNode on iOS. It separates out code originally submitted in #9048 .
Test plan (required)
Set up an animation with a modulo node, and `useNativeModule: true`. Compare results with `useNativeModule: false`.
Closes https://github.com/facebook/react-native/pull/9626
Differential Revision: D3799636
fbshipit-source-id: 594499f11be41bf3ee709249056a3feedeace9eb
2016-08-31 14:43:43 -07:00
Janic DuplessisandFacebook Github Bot
Ryan GombaandFacebook Github Bot 3