d359c01f53
updated css-layout and fixed callsites
...
Reviewed By: mmahoney, nicklockwood
Differential Revision: D2759669
fb-gh-sync-id: 0b099f9c7d68bbcb62a38d2a3e355dfb6c61eb4e
2015-12-21 10:18:41 -08:00
bd36e40258
Fix width being ignored when has a value of 0
...
Summary: https://github.com/facebook/css-layout/commit/8f6a96adbcb2b0389f948b8113d8b7cb8991bb2d added a test in isDimDefined that checks if `value > 0.0`, but unfortunately, it did not faithfully port the JavaScript version which is `value >= 0.0`: https://github.com/facebook/css-layout/blob/master/src/Layout.js#L306 . Sadly, no test covered this so it went unnoticed.
Closes https://github.com/facebook/css-layout/pull/134
Reviewed By: @svcscm
Differential Revision: D2481773
Pulled By: @vjeux
2015-09-25 15:42:21 -07:00
ec8b5425e5
Fix row height
...
Reviewed By: @frantic
Differential Revision: D2480265
2015-09-25 11:25:57 -07:00
1ad1f45fe6
Reverted D2476924
...
Reviewed By: @mmmulani
Differential Revision: D2479710
2015-09-25 03:08:24 -07:00
03222d66bb
Revert of [Fix dimension check for STRETCH children]
...
Summary: We had a layout issue in Ads Manager after updating to the latest version of css-layout on react-native. I bisected the change to https://github.com/facebook/css-layout/commit/909c14117f118c9b36e6623590e62bff2f996c1b . It changes the condition and breaks the behavior that we had. This change was not covered by a unit test so I added one.
Closes https://github.com/facebook/css-layout/pull/131
Reviewed By: @svcscm
Differential Revision: D2476924
Pulled By: @vjeux
2015-09-24 14:11:47 -07:00
e665acca4b
pull in github css-layout into fbobjc react native
...
Reviewed By: @vjeux
Differential Revision: D2448929
2015-09-20 20:35:29 -07:00
5a2d2007a4
[React Native] Fix infinite loop in css-layout
...
Summary:
Manual pick of https://github.com/facebook/css-layout/commit/9001a3d2 since we're still lagging behind the upstream. Fixes #1378 .
2015-08-19 16:39:35 -07:00
6c812c8124
Fixed layout bug
2015-05-13 13:24:36 -07:00
709aa5f259
Revert "[ReactNative] update Layout"
2015-05-13 13:24:35 -07:00
acafa7e921
[ReactNative] Properly transition RCTTouchHandler state
...
Summary:
When touches end or cancel, update self.state in
RCTTouchHandler to let iOS know that we are in an ended/canceled state.
This way we won't eat other touches because it still thinks we're in a
began/changed state.
@public
Test Plan:
Scrolling in the back swipe area no longer busts gesture
recognition in Wilde.
2015-05-05 06:21:55 -08:00
af921542b5
[ReactNative] update Layout
...
Summary:
I made some changes to css-layout that changes how layout is
computed for absolutely positioned nodes inside absolutely positioned
parents that have borders/padding. There were also some other changes
made to css-layout that haven't been merged in yet.
@public
Test Plan:
Made a node as described above, saw that the layout is
computed differently than in the browser, updated Layout, saw that the
Layout is not computed correctly.
2015-05-04 20:08:49 -08:00
d293bed5ab
[ReactNative] Fix analyze errors on oss
2015-04-24 08:28:35 -08:00
20291a02df
[ReactNative] s/ReactKit/React/g
2015-03-26 02:42:24 -08:00
Martin Kralik
Christopher Chedeau
Cirkos
Aaron Chiu
Ben Alpert
Nick Lockwood
Andrew Rasmussen
Tadeu Zagallo