Eric Lewis
|
38e91e6a9d
|
fix getPhotos params on RNTester XHR example. (#23548)
Summary:
Fixes redscreen on RNTester's XHR page. CameraRoll getPhotos was missing params.
ss: https://i.imgur.com/JLThyrF.png
[iOS] [Fixed] - RNTester XHR Example crash
Pull Request resolved: https://github.com/facebook/react-native/pull/23548
Differential Revision: D14151304
Pulled By: hramos
fbshipit-source-id: 7ff02c7fe32f09aecd50bc7df9f37b7cd2851b1c
|
2019-02-20 09:57:26 -08:00 |
|
Héctor Ramos
|
eb414b7f8d
|
Update iOS Snapshots (#23538)
Summary:
The iOS snapshots needed to be updated after https://github.com/facebook/react-native/commit/cf5f25472df644b65820115986f9eec8306bd1fd updated `ViewExample.js`.
[iOS] [Fixed] - Updated snapshots on iOS.
Pull Request resolved: https://github.com/facebook/react-native/pull/23538
Differential Revision: D14146723
Pulled By: cpojer
fbshipit-source-id: f949d4c7925ab53ef42f42689bc2ed7b254dea48
|
2019-02-19 22:07:32 -08:00 |
|
Woraphot Chokratanasombat
|
27617be9bb
|
RNTesterSnapshotTests update ios snapshot images due to layout changes (#23152)
Summary:
Thank you for sending the PR! We appreciate you spending the time to work on these changes.
Help us understand your motivation by explaining why you decided to make this change:
Changelog:
----------
Currently ci in master fail for `test_ios`. Due to tests in `RNTesterSnapshotTests`. (Related to https://github.com/facebook/react-native/issues/23108)
Root cause is layout in RNTest was changed and snapshot is not updated to reflect changes. https://user-images.githubusercontent.com/4032276/51730680-06609480-20ab-11e9-88cb-d4113e2819f2.png
Reference: https://circleci.com/gh/facebook/react-native/68285?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link
[iOS] [Fixed] - Fix test ios in ci
Pull Request resolved: https://github.com/facebook/react-native/pull/23152
Differential Revision: D13817049
Pulled By: cpojer
fbshipit-source-id: 7df8b6744ae91cf9be0ef9eee476c8f1565ae1f6
|
2019-01-25 05:25:39 -08:00 |
|