5 Commits

Author	SHA1	Message	Date
Michał Osadnik	61e95e5cbf	Force WithDefault not to be an optional value ... Summary: `WithDefault` appears not to be required to be prefixed with `?` because it's option value per se. Fixed tests, removed `?` where needed, updated snapshots and review them. Added mechanism fro throwing error when `?WithDefault` found. Add tests for it. Reviewed By: rubennorte Differential Revision: D16048463 fbshipit-source-id: f55ed7454aacf0b8c42944a9b5c1037ad1b360fe	2019-07-02 03:30:55 -07:00
Michał Osadnik	0f83dfab8e	Transform BubbleEvent and DirectEvent into DirectEventHandler and BubblingEventHandler ... Summary: It appears that `(e: BubblingEvent<T>) = mixed` exists only in given context and it's pointless to keep in this way. It could be simplified to `BubblingEventHandler<T>` without any negative consequences and that's the motivation of this diff. The only tradeoff of this decision is leaving an opportunity to declare Bubbling/Direct event in the top of the file bc then analysing the code becomes much more difficult. However, it's not used anywhere so it's not a problem now and probably any time. Also, changes the names to `DirectEventHandler` and `BubblingEventHandler` which are more related to current state. The names were updated in many places in code. Reviewed By: rubennorte Differential Revision: D16054571 fbshipit-source-id: 741d075eb46b80bac8eb73a6b30fc0b448cb3902	2019-07-01 05:13:53 -07:00
Rick Hanlon	58cd046bb4	Add types for modal ... Summary: Adds codegen types and generated view config for Modal Reviewed By: TheSavior Differential Revision: D15905324 fbshipit-source-id: b430a782bf03f04b5b86757c58b39ddb28d6f06d	2019-06-23 10:03:54 -07:00
James Ide	0ee5f68929	Migrate "Libraries" from Haste to standard path-based requires (sans vendor & renderers) (#24749) ... Summary: This is the next step in moving RN towards standard path-based requires. All the requires in `Libraries` have been rewritten to use relative requires with a few exceptions, namely, `vendor` and `Renderer/oss` since those need to be changed upstream. This commit uses relative requires instead of `react-native/...` so that if Facebook were to stop syncing out certain folders and therefore remove code from the react-native package, internal code at Facebook would not need to change. See the umbrella issue at https://github.com/facebook/react-native/issues/24316 for more detail. [General] [Changed] - Migrate "Libraries" from Haste to standard path-based requires Pull Request resolved: https://github.com/facebook/react-native/pull/24749 Differential Revision: D15258017 Pulled By: cpojer fbshipit-source-id: a1f480ea36c05c659b6f37c8f02f6f9216d5a323	2019-05-08 08:48:59 -07:00
nd-02110114	007e00fa70	RCTModalHostView (#23030) ... Summary: This PR is related to #22990 Changelog: ---------- [iOS] [Changed] - move the call to requireNativeComponent from Modal.js to RCTModalHostViewNativeComponent.js Pull Request resolved: https://github.com/facebook/react-native/pull/23030 Differential Revision: D13710032 Pulled By: cpojer fbshipit-source-id: 822284a639f38721442c67ceff98fc99495c31b9	2019-01-17 02:41:59 -08:00