8 Commits

Author	SHA1	Message	Date
Moti Zilberman	b26ae3e0c9	Move RCT* Buck targets to GitHub ... Summary: Changelog: [Internal] Reviewed By: GijsWeterings Differential Revision: D30030454 fbshipit-source-id: 02a4c36f5c5ca519e4de3d1a3d79708d0d0b6d01	2021-08-04 13:03:21 -07:00
Samuel Susla	9ef995a14a	Enable C++ 17 in React Native ... Summary: Changelog: [Internal] enable support for C++ 17. C++ 17 in React Native targets. Short and comprehensive list of C++ features: https://github.com/AnthonyCalandra/modern-cpp-features#c17-language-features Reviewed By: JoshuaGross Differential Revision: D27431145 fbshipit-source-id: e8da6fe9d70e9b7343a8caec21cdbeb043478575	2021-04-01 04:50:59 -07:00
Joshua Gross	b3930f935f	Convert most Fabric Cxx code to use react_native_assert instead of assert ... Summary: See react_native_assert.{h,cpp}. Because of the BUCK+Android issue where NDEBUG is always defined, we use react_native_assert instead of assert to enable xplat asserts in debug/dev mode. This migrates most of the codebase, but probably not 100%. The goal is to increase assertion coverage on Android, not to get to 100% (yet). Changelog: [Internal] Reviewed By: RSNara Differential Revision: D26562866 fbshipit-source-id: a7bf2055b973e1d3650ed8d68a6d02d556604af9	2021-02-19 20:52:52 -08:00
Ramanpreet Nara	ab21226457	Migrate away from "@fbsource//tools/build_defs/apple:flag_defs.bzl" ... Summary: We still have usages of "fbsource//tools/build_defs/apple:flag_defs.bzl" in react-native-github. But this should get us closer towards not using the fbsource cell. Hopefully, this is enough to unbreak the test_docker CircleCI build. Changelog: [Internal] Reviewed By: fkgozali Differential Revision: D26289304 fbshipit-source-id: 1c6464bb84df4f82f8a797321a73a1ed324e319a	2021-02-08 16:04:51 -08:00
Paige Sun	a7c026e667	Remove unused Fabric image instrumentation ... Summary: Remove the older implementation of image instrumentation in Fabric by removing, RCTImageInstrumentationProxy, ImageInstrumentation from ImageRequest, and trackURLImageContentDidSetForRequest from RCTImageLoaderWithAttributionProtocol. Changelog: [RN][Fabric][Image] Remove unused Fabric image instrumentation Reviewed By: fkgozali Differential Revision: D23990606 fbshipit-source-id: 004d04025d031af11377a73e5bfb64b1e0449962	2020-09-29 14:19:09 -07:00
Paige Sun	d4e1202b4e	2/6 Track image request metadata in ImageTelemetry, to be passed from ImageShadowNode into RCTImageComponentView ... Summary: * Create `ImageTelemetry` as a property of ImageRequest to pass image metadata from the ImageShadowNode into RCTImageComponentView * ImageRequest is a object in the ImageShadowNode::ConcreteState Reviewed By: fkgozali Differential Revision: D23239664 fbshipit-source-id: db0f08bb889af8ce63fbe1abe88744edddb86150	2020-09-11 15:09:11 -07:00
David Vacca	cc7dd18080	Fix codegen for CXX build ... Summary: Fabric codegen is failing with running without specifying a specific platform. This diff fixes that. Steps to reproduce: ``` buck build //xplat/js/react-native-github:generated_components-rncore --show-output ``` Error: ``` #include <react/renderer/imagemanager/primitives.h> ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ 1 error generated. ``` changelog: [internal] internal Reviewed By: fkgozali Differential Revision: D23114403 fbshipit-source-id: 50210e74f2a99ae5a77087988c3323bdacf04128	2020-08-13 17:45:03 -07:00
David Vacca	3093010ea5	move fabric to ReactCommon/react/renderer ... Summary: This diff moves fabric C++ code from ReactCommon/fabric to ReactCommon/react/renderer As part of this diff I also refactored components, codegen and callsites on CatalystApp, FB4A and venice Script: P137350694 changelog: [internal] internal refactor Reviewed By: fkgozali Differential Revision: D22852139 fbshipit-source-id: f85310ba858b6afd81abfd9cbe6d70b28eca7415	2020-07-31 13:34:29 -07:00