4 Commits

Author	SHA1	Message	Date
Samuel Susla	7ee2a998f0	Avoid copy of shared_ptr in ConcreteComponentDescriptor::adopt ... Summary: Changelog: [internal] Differential Revision: D27406634 fbshipit-source-id: f01422ebbcfd89337b98c4e6144aed7a2b9914b8	2021-04-05 11:48:56 -07:00
Joshua Gross	b3930f935f	Convert most Fabric Cxx code to use react_native_assert instead of assert ... Summary: See react_native_assert.{h,cpp}. Because of the BUCK+Android issue where NDEBUG is always defined, we use react_native_assert instead of assert to enable xplat asserts in debug/dev mode. This migrates most of the codebase, but probably not 100%. The goal is to increase assertion coverage on Android, not to get to 100% (yet). Changelog: [Internal] Reviewed By: RSNara Differential Revision: D26562866 fbshipit-source-id: a7bf2055b973e1d3650ed8d68a6d02d556604af9	2021-02-19 20:52:52 -08:00
Samuel Susla	b179c4bebe	Fix incorrect padding in SafeAreaView ... Summary: Changelog: [Internal] `SafeAreaViewShadowNode` we made incorrect assumption that setting `style` on YGNode and then copying it, always copies the style. This is incorrect, style is only copied once `YGNodeCalculateLayout` has been called on either the node or its parent. Reviewed By: JoshuaGross Differential Revision: D22945677 fbshipit-source-id: 9c063c2dfe4d2390cf2fd10a96d2de418fa69376	2020-08-05 11:39:25 -07:00
David Vacca	3093010ea5	move fabric to ReactCommon/react/renderer ... Summary: This diff moves fabric C++ code from ReactCommon/fabric to ReactCommon/react/renderer As part of this diff I also refactored components, codegen and callsites on CatalystApp, FB4A and venice Script: P137350694 changelog: [internal] internal refactor Reviewed By: fkgozali Differential Revision: D22852139 fbshipit-source-id: f85310ba858b6afd81abfd9cbe6d70b28eca7415	2020-07-31 13:34:29 -07:00